From patchwork Fri Oct 17 15:48:54 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Thompson X-Patchwork-Id: 38894 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f198.google.com (mail-wi0-f198.google.com [209.85.212.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3F0FE2054E for ; Fri, 17 Oct 2014 15:49:17 +0000 (UTC) Received: by mail-wi0-f198.google.com with SMTP id hi2sf712747wib.9 for ; Fri, 17 Oct 2014 08:49:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=eARNZcbjFOYMvL54zqPSaC9Jdq5wRs8H2p9xpjNHcWk=; b=KWPqCZrSTuEP3lEfvFOotTQAFLFB/ADnqD+RcT/G8n9L3lYsjR3CYu58G2VenWAQ4i LKam7JxnQUd7ZjtWDYPWx8lofa61YNnd9x6MCkSHTDvO7l5915N61WAlxZu56MeShIKc YXxtvx0mt87yOqjHPrfzRdG/0znQe873M/wRUN/FOfwyaZY7f3o87qgv/Tvecbf0EhTx p/bfbOIMKO9dCQrc8c3h0Cob7wI+wRjcuE1FvtyoGJD7EHeoKo+ZaWP7u4pwx+ibz9z7 tLN4lDxFs6pnaksWYhrIMlSquFxarDcyYMBkHYyMWFFfY8e1EgUbVdNPdlbZ/tbXc0qh CvVA== X-Gm-Message-State: ALoCoQnJ8pG+hnkszNnYsLJJfkC554FH3jlB1J1kChYenIQFwHcnCesYnP2nF5K78q+QMT9KCd9C X-Received: by 10.112.225.135 with SMTP id rk7mr1523783lbc.6.1413560956107; Fri, 17 Oct 2014 08:49:16 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.18.131 with SMTP id w3ls297285lad.79.gmail; Fri, 17 Oct 2014 08:49:15 -0700 (PDT) X-Received: by 10.152.203.134 with SMTP id kq6mr9840222lac.60.1413560955965; Fri, 17 Oct 2014 08:49:15 -0700 (PDT) Received: from mail-la0-f47.google.com (mail-la0-f47.google.com. [209.85.215.47]) by mx.google.com with ESMTPS id jh10si2586101lbc.93.2014.10.17.08.49.15 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 17 Oct 2014 08:49:15 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.47 as permitted sender) client-ip=209.85.215.47; Received: by mail-la0-f47.google.com with SMTP id pv20so927187lab.6 for ; Fri, 17 Oct 2014 08:49:15 -0700 (PDT) X-Received: by 10.152.202.135 with SMTP id ki7mr9799548lac.40.1413560955824; Fri, 17 Oct 2014 08:49:15 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.112.84.229 with SMTP id c5csp253135lbz; Fri, 17 Oct 2014 08:49:15 -0700 (PDT) X-Received: by 10.194.92.12 with SMTP id ci12mr11354902wjb.6.1413560955241; Fri, 17 Oct 2014 08:49:15 -0700 (PDT) Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com. [74.125.82.48]) by mx.google.com with ESMTPS id db7si2340018wib.54.2014.10.17.08.49.15 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 17 Oct 2014 08:49:15 -0700 (PDT) Received-SPF: pass (google.com: domain of daniel.thompson@linaro.org designates 74.125.82.48 as permitted sender) client-ip=74.125.82.48; Received: by mail-wg0-f48.google.com with SMTP id k14so1214576wgh.19 for ; Fri, 17 Oct 2014 08:49:15 -0700 (PDT) X-Received: by 10.194.250.105 with SMTP id zb9mr4739117wjc.123.1413560954952; Fri, 17 Oct 2014 08:49:14 -0700 (PDT) Received: from sundance.lan (cpc4-aztw19-0-0-cust157.18-1.cable.virginm.net. [82.33.25.158]) by mx.google.com with ESMTPSA id ws2sm2106244wjc.32.2014.10.17.08.49.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Oct 2014 08:49:14 -0700 (PDT) From: Daniel Thompson To: David Airlie Cc: Daniel Thompson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, patches@linaro.org, linaro-kernel@lists.linaro.org, Rob Clark Subject: [PATCH 3.17 v2] drm/msm: Fix fbdev for 16- and 24-bit modes. Date: Fri, 17 Oct 2014 16:48:54 +0100 Message-Id: <1413560934-19268-1-git-send-email-daniel.thompson@linaro.org> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1413556088-30194-1-git-send-email-daniel.thompson@linaro.org> References: <1413556088-30194-1-git-send-email-daniel.thompson@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: daniel.thompson@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.47 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Currently forcing the video mode from the kernel command line (for example video=HDMI-A-1:1280x720-16@60) does not correctly set the number of bits per pixel. This is due to a rather aggressive override in msm_fbdev_create(). This is a particular problem for Android bring up because the software EGL fallbacks don't support 32bpp. Since the overrides are actually the default values anyway then this problem can be trivially fixed by removing the overrides completely. Change was tested by dd'ing a test image to /dev/fb0 with no video= (still 32bpp), video=1920x1080-32@60, video=1920x1080-24@60 and video=1920x1080-16@60 . Signed-off-by: Daniel Thompson Cc: David Airlie Cc: Rob Clark --- drivers/gpu/drm/msm/msm_fbdev.c | 3 --- 1 file changed, 3 deletions(-) -- 1.9.3 diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c index ab5bfd2..94d55e5 100644 --- a/drivers/gpu/drm/msm/msm_fbdev.c +++ b/drivers/gpu/drm/msm/msm_fbdev.c @@ -93,9 +93,6 @@ static int msm_fbdev_create(struct drm_fb_helper *helper, uint32_t paddr; int ret, size; - sizes->surface_bpp = 32; - sizes->surface_depth = 24; - DBG("create fbdev: %dx%d@%d (%dx%d)", sizes->surface_width, sizes->surface_height, sizes->surface_bpp, sizes->fb_width, sizes->fb_height);