From patchwork Wed Feb 28 11:26:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 129959 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp909134lja; Wed, 28 Feb 2018 03:28:22 -0800 (PST) X-Google-Smtp-Source: AH8x22477EoeQPCX5qcKbU5rJdwX7moC9YtqStDYiMwoznpWhNrHOLMUAaJKJ9PtpjCS9FqiPKfw X-Received: by 10.167.129.195 with SMTP id c3mr17336525pfn.14.1519817302540; Wed, 28 Feb 2018 03:28:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519817302; cv=none; d=google.com; s=arc-20160816; b=sk26X3LwbJCuGcRlfPCWvW9+UFL2Z/7TpTDZ4B2MwEAppxMptNkvHEfCgDspET11xu seNRzDcVIyV4KL0vGyBI0evC5rTZnsc0qZvIpMz8XXl9o+X0Q3tKDBj0Dl8RB8AXuy06 g5M236WPnY2dz39hVi3udItfA+V5xeOcA+bHEBiJa5CdxmyUunGbOOe8akhAj3klvXr4 DHIitFPUYkTcTP1kURVEiNXZo3/RRZYBYChNZaw7P7MXUNsywLd8BbQWhaqqW7nJGjtt Zc5/EeEg5WjOvLLCVKEhcCJf2pF/h4RLVwY6c+Ip63+5fmfdGEH9I07fcjIxMLFjpDkQ k4DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=KuzzgYeAW0aZFujplBsZaHTTp5MqIPQOFTYTUHCPzGA=; b=wUx4MODuHTfiW6vtkTYQBVAxsMba17HBs4ARnO9QdtkThLP5rJwdxspHfpuINwX0dJ 8vXpX+RpJ7qyB8HSAdWG1BcnlEk5BO3lAirCh7MaAC9D5suxZhPwaPowf8wfzHTV7/XI pVyUWgQKTIxot9OW/SQiU194AKlQcdKwSFy1hx0pDVrElQvI+Ib6ffGR0QDELObOsqVL zePsyAIcpNZJ1FV/Kl1vvaCvfzYgjG/4BFPCnQuoj/gY/EczfLH5yTVVZkmUil1I0F5K 6LYM0xoTeb/32PCZf5cpWZuOLPeCMvbiqnhi3voutZKthsdJMVNalF5S/LQ8sCKugcde n1+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=Fuv7HZZ1; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id 33-v6si1149020plo.650.2018.02.28.03.28.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Feb 2018 03:28:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=Fuv7HZZ1; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0939F6E972; Wed, 28 Feb 2018 11:27:46 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from fllnx209.ext.ti.com (fllnx209.ext.ti.com [198.47.19.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id A6A2E6E972 for ; Wed, 28 Feb 2018 11:27:43 +0000 (UTC) Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id w1SBRfhP004909; Wed, 28 Feb 2018 05:27:41 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1519817261; bh=ssMfbSFvXItiXRkftvG3TJ7tQ3o1sfsSCaCMXT5E/M0=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=Fuv7HZZ14g2eqiO5fRk9yBBvZO0D8E8c0xScX+IIZTslm6XcOm6HAqKnVgYfQIi0e gEri0gT5eBF6eCSM243A2vPaJksfaRrUy1932d6pwBUjD9TEOCKjgMNIfoXivlZHMw 6ygjUqWjkZei8CG6zuZSAm4YLWdl6QSrCtlRaBbU= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w1SBRfi0031617; Wed, 28 Feb 2018 05:27:41 -0600 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.35; Wed, 28 Feb 2018 05:27:40 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1261.35 via Frontend Transport; Wed, 28 Feb 2018 05:27:40 -0600 Received: from deskari.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id w1SBRAfY024563; Wed, 28 Feb 2018 05:27:39 -0600 From: Tomi Valkeinen To: , Laurent Pinchart Subject: [PATCHv2 15/17] drm/omap: fix maximum sizes Date: Wed, 28 Feb 2018 13:26:12 +0200 Message-ID: <1519817174-20714-16-git-send-email-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1519817174-20714-1-git-send-email-tomi.valkeinen@ti.com> References: <1519817174-20714-1-git-send-email-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Ujfalusi , Tomi Valkeinen , Jyri Sarha Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" We define max width and height in mode_config to 2048. These maximums affect many things, which are independent and depend on platform. We need to do more fine grained checks in the code paths for each component, and so the maximum values in mode_config should just be "big enough" to cover all use cases. Change the maximum width & height to 8192. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_drv.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c index 4f48b908bdc6..3632854c2b91 100644 --- a/drivers/gpu/drm/omapdrm/omap_drv.c +++ b/drivers/gpu/drm/omapdrm/omap_drv.c @@ -310,11 +310,14 @@ static int omap_modeset_init(struct drm_device *dev) dev->mode_config.min_width = 8; dev->mode_config.min_height = 2; - /* note: eventually will need some cpu_is_omapXYZ() type stuff here - * to fill in these limits properly on different OMAP generations.. + /* + * Note: these values are used for multiple independent things: + * connector mode filtering, buffer sizes, crtc sizes... + * Use big enough values here to cover all use cases, and do more + * specific checking in the respective code paths. */ - dev->mode_config.max_width = 2048; - dev->mode_config.max_height = 2048; + dev->mode_config.max_width = 8192; + dev->mode_config.max_height = 8192; dev->mode_config.funcs = &omap_mode_config_funcs; dev->mode_config.helper_private = &omap_mode_config_helper_funcs;