From patchwork Fri May 3 12:29:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 163306 Delivered-To: patch@linaro.org Received: by 2002:a92:7e86:0:0:0:0:0 with SMTP id q6csp546452ill; Fri, 3 May 2019 05:31:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqwfJWqXiGIUgyfhqgmZiOWBwNreWspKk2OLGZK/1jcJT3JMiXBM1ayvTW5iWiA9Fi145bjC X-Received: by 2002:a63:7982:: with SMTP id u124mr9705557pgc.352.1556886663089; Fri, 03 May 2019 05:31:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556886663; cv=none; d=google.com; s=arc-20160816; b=qI1xMvCdWccMxKsKDteZZG0nFzArUzybfiqqkiIKC0ZhUQoQxhEJpDAR/5d2zMm2Lg NbiUC7fddv9qiETxTBFrQUFiTtEhqIdtoxzc5CUMu+x/sZBvfO8dnoO3q1pVhTNltUrX YjCoyWTgXF4u8s6PEsp5oL1C6DWjnTx0nig0FGfjWspYdPvbQYhUJt8DUAgp9tbv2KGy UHwQN1yd1wSIHK3P3gwIDk0Sx+kCFx7VKoCqvrx5/QExEagJcEfnMM5xZAH8PVFZPV6C xPibCOyUYLae4ETaGfPeXDF24WYsdQhY0VkRO2u9lrqEjetyiARbOcQsR/tenW6CB11y h/qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=e/azvimRzEUwCF43FijoZHAdFrtaEVSjtfE9i0xNw7E=; b=kcucjMeSrW4P2IBsyw9zaGxppJMaQQiI9afNohyMeNhS0/qaS+G2yxmFFQaL2k4SMT BzXue3bAVEkZhSks3XUzd5n3FWYO+5u7EQxbrGTzXIgyEPlPL81TWJ7E3tYZuqR0N6X2 XUEG9I17Iglx5CSRshHMJ5quF9m0mpz5WE6if+uDTHY/co0/x02L25aZgK6Wx/NVb+lV oAkJ15Arf/TwdOBgxe6mn+lXzyAm8GEjfUgkkg/fqLNgCjua1L6J1zcxgcAJaQdYm89v wIenmoLbVi/4uVs5qjUXJhCjbvZxe8HrXl5aBmFDuLPuX+u9/0EQknccOsqxiolXxFW7 8EEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id g2si2042589pfd.80.2019.05.03.05.31.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 May 2019 05:31:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D1F3789E86; Fri, 3 May 2019 12:31:00 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by gabe.freedesktop.org (Postfix) with ESMTPS id AEC0089E69 for ; Fri, 3 May 2019 12:30:58 +0000 (UTC) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x43CUuNA032315; Fri, 3 May 2019 07:30:56 -0500 Received: from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x43CUuGg128218 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 3 May 2019 07:30:56 -0500 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 3 May 2019 07:30:55 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Fri, 3 May 2019 07:30:55 -0500 Received: from deskari.lan (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x43CUYtp002029; Fri, 3 May 2019 07:30:53 -0500 From: Tomi Valkeinen To: Andrzej Hajda , Laurent Pinchart , Lucas Stach , Andrey Gusakov , Philipp Zabel , Andrey Smirnov , Peter Ujfalusi , Jyri Sarha , Benoit Parrot , Subject: [PATCHv3 07/23] drm/bridge: tc358767: move video stream setup to tc_main_link_stream Date: Fri, 3 May 2019 15:29:33 +0300 Message-ID: <20190503122949.12266-8-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190503122949.12266-1-tomi.valkeinen@ti.com> References: <20190503122949.12266-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1556886656; bh=gBGAJ/FCM226hgnd6HSRYPRF9recUxOfzRHiWuh8qKI=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=CG2tMzuuJEbAU+SFTqJo0Hs9sh43FRe3BiPmHPI6cD6N9dKVOusv8MKfFFMPz1P9V KvFl4C1Tzsw0FZ+dn2McXRQF+XwPb5umOWzM/zZwJ2QLSNTiH+5B5NQ9XShzBs7F/z jAJpFtxC3P2iSGLzD/rZd44yoiekq1Ef3Svskf2Y= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The driver currently sets the video stream registers in tc_main_link_setup. One should be able to establish the DP link without any video stream, so a more logical place is to configure the stream in the tc_main_link_stream. So move them there. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/bridge/tc358767.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index f125727ac98e..8dc63de39e73 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -1004,15 +1004,6 @@ static int tc_main_link_setup(struct tc_data *tc) return -EAGAIN; } - ret = tc_set_video_mode(tc, tc->mode); - if (ret) - goto err; - - /* Set M/N */ - ret = tc_stream_clock_calc(tc); - if (ret) - goto err; - return 0; err_dpcd_read: dev_err(tc->dev, "Failed to read DPCD: %d\n", ret); @@ -1031,6 +1022,15 @@ static int tc_main_link_stream(struct tc_data *tc, int state) dev_dbg(tc->dev, "stream: %d\n", state); if (state) { + ret = tc_set_video_mode(tc, tc->mode); + if (ret) + goto err; + + /* Set M/N */ + ret = tc_stream_clock_calc(tc); + if (ret) + goto err; + value = VID_MN_GEN | DP_EN; if (tc->link.base.capabilities & DP_LINK_CAP_ENHANCED_FRAMING) value |= EF_EN;