From patchwork Fri Aug 23 02:12:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 172079 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1752ily; Thu, 22 Aug 2019 19:12:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqxy2HcNMf8XJWpgvlQFmW9k6s3meYJG+/wblW+hLWJg7MUXbccnYk77rv03eObd5fw0DpWw X-Received: by 2002:a17:902:6a84:: with SMTP id n4mr2019430plk.109.1566526359013; Thu, 22 Aug 2019 19:12:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566526359; cv=none; d=google.com; s=arc-20160816; b=F3XwL6ckRa65tYCGE12eOfMBEWCp+1WKCmIWrpKRi+7MgynNWvI8uJuW4g7OYvGJlD pbPB+dpkR6MYmfZCN1g/v6yTNDl3DEjEIhjiQJVJE3bCBwvmDYhFjVACbVRZ7hITz3ew KfL+KEXnv13lWx1wW2wDSc8mzui/1p9TqLrHOKJx6fKI/+i8nmmdE3KvZo8IVPJaAk2i jgRB/SLP7D47y4ULiaAc8UvoHwWGNauwusibe3WB6+U6YK7szecd4qo6jJWiwxFpbICl ERZsZ2QJCAkcEHGJkMeqaeNKLoTwcYqAj4KocDoVdOXaAUsMGYcWCH/hOSTRbXgrSMHe IWCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=6IWpzXoi4eIdyNJq2jyVsFbpd5UTu/jd58iO/jdVAMU=; b=jllH8r2EvpSCkh03Ss6yreqLLNwTvHHJmmIdJmywiHwDubKm5QHHPuoeaFH3/Q6XJ0 NqruaZj7A03/SDAbuuUGkN/B3eFvhojbF7QCVLS7ufbUBoYAV8T0vjeWsd792UwpmpPt wnsZU3KIozV4OqlG8XgK7tS8uHAkH0eEe4/N6inAvUy2rX+ctaM4owEAXu/COJ1SBjx6 WEbEm4mI/r1Wu8gGFCGcDC8CkWSuQjz0ANJ2GX9eEYmGkShaLmDcKrvxShFTHZsUNzVy bDd0B3TiirGyrgt1kTr/K8RhsuNukjsMRMcaW4T0S6d+Z1EcYXhxn+AseJR4VCZGt+IG k6Hg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id ck4si1131268plb.235.2019.08.22.19.12.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Aug 2019 19:12:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 098186EBA7; Fri, 23 Aug 2019 02:12:38 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by gabe.freedesktop.org (Postfix) with ESMTPS id D17306EBA5 for ; Fri, 23 Aug 2019 02:12:29 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id f17so7407113otq.4 for ; Thu, 22 Aug 2019 19:12:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1n4qe+AkzzJcIOZArT5eHMvskMvaiSyGwRJQ9TgkdLc=; b=lP1DFb8+WWIRd+rbFO6Z/X+Gu+2iDhNZBP7KhZOppZrGJuUWPD3d36dVr+xmR5bcWU scHPakxeRzIA/0FU/MqWdqVtYNdXBjf3NZ3s38DFXBFYGZX9oZm8wnnMKdyOBUuqbkHz tIo19FcP3xlqp/S6Wh9r2NpICoKrGbHoi2cSqRkpJWUfbz7maHEb1tDirxN+VSdGrRlj QFrwN2vbMFWW7+Pp8vSYA7U8HESuOayK+be5IFExImbAhLcaFcWrxiKlKgqsMAyb86RB ucb3UtHXlP40cWayqbhzvV/Z0PcszLoXaRd7NeSw7nbGpCqA1UzdvUVPL3l0ZTj6Jmjq NbTQ== X-Gm-Message-State: APjAAAVma44JFRaeS4t7DdtjapikwWmhkXvBnGI3y4RUSUPzGqQ9hjXK Ah48F2LYyIayVinzmwJsaDK/1Is= X-Received: by 2002:a9d:77c4:: with SMTP id w4mr2319524otl.40.1566526348479; Thu, 22 Aug 2019 19:12:28 -0700 (PDT) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id c1sm457747oic.31.2019.08.22.19.12.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2019 19:12:28 -0700 (PDT) From: Rob Herring To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 8/8] drm/panfrost: Remove unnecessary flushing from tlb_inv_context Date: Thu, 22 Aug 2019 21:12:16 -0500 Message-Id: <20190823021216.5862-9-robh@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190823021216.5862-1-robh@kernel.org> References: <20190823021216.5862-1-robh@kernel.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Tomeu Vizoso , David Airlie , Sean Paul , Steven Price , Boris Brezillon , Alyssa Rosenzweig , Robin Murphy Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" tlb_inv_context() hook is only called when freeing the page tables. There's no point in flushing only to free the page tables immediately following. There is also a problem that we could be accessing the h/w when suspended. Cc: Tomeu Vizoso Cc: Steven Price Cc: Alyssa Rosenzweig Cc: David Airlie Cc: Daniel Vetter Signed-off-by: Rob Herring Reviewed-by: Steven Price --- v2: new patch drivers/gpu/drm/panfrost/panfrost_mmu.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c index ccf671a9c3fb..9f85275a896c 100644 --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c @@ -328,11 +328,7 @@ void panfrost_mmu_unmap(struct panfrost_gem_object *bo) } static void mmu_tlb_inv_context_s1(void *cookie) -{ - struct panfrost_file_priv *priv = cookie; - - mmu_hw_do_operation(priv->pfdev, &priv->mmu, 0, ~0UL, AS_COMMAND_FLUSH_MEM); -} +{} static void mmu_tlb_inv_range_nosync(unsigned long iova, size_t size, size_t granule, bool leaf, void *cookie)