From patchwork Mon Oct 26 19:41:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 318988 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp950175ilc; Mon, 26 Oct 2020 12:42:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+Ns+CG/8bgOqtOjmP8alEvQFq22+XMqqLM5GLl3kV+m4fH3i2F2qvrSd65byZY3EGlAMK X-Received: by 2002:a17:90a:d082:: with SMTP id k2mr18251216pju.195.1603741322367; Mon, 26 Oct 2020 12:42:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603741322; cv=none; d=google.com; s=arc-20160816; b=yU3cxiKV5cU5ieEHtnsRTjUZteGswnvweG0p687W5V0Bpbd50bLcsyFjHhtEMSdmZV HI0iESbxCxahUJEtX2GBVmCVpKZZshW6KyzcF3Mpo4o6g0UxNBd0vE5/QG2Z2ZlBPxxo A5/puliA3ZBuwWDMpN9K81J7pZh/beeW5TzBWYEOsZTLsqT2YytvPp1z87VjlwXVtCVk qpxdAfV9ziiQbWwPQd4jrSvIqGsjUe8M59iYqrVJR2jiJeA2ziF0laaEFLYQ6oap/cMk su3zVDrFmw3W7i0pCxR3x2xgeolaVUHScaAd+QZ8UoUCROJPMSkt2iaLqZSADSAcO1f0 KNzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=YNxRGJ3domnOQKxJVv+pbVeVv7EBWKKJOzygdZcnC0s=; b=1ApY+iCJJrZ99OtjHxDurmCpspPLxZ0JBCiwm7PLRaGAdycay/Yb7+R7c+SqZeoZHu dC5QAeYHriGsZlth523n6kA3Ny8BuT9ynGZfr4yEv2RHlPIHwbVjutA7LHcALf1mnphU wI2wIX47ZQUR8qWNX9KX9iNKwNFveeOI7eaVdQ2+/KeEaYtHrUZEvQZW/qxEiLAs7rEQ NI1wmWJQtwIPugf1iB6ODVuacD/i5Rreu9wL4i7MkAWzuVZvsSiM2B1CnsG6/nFd9YUn gRXcJl6aRM8sVKJSZbLOqpcHG13YGW2QR7Zf4qIH6GkCkrWQlGNNx+2ayYi8CCGf2bUP b9LA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=default header.b=Zv4bVSyc; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id u24si9906009pgf.99.2020.10.26.12.42.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 12:42:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=default header.b=Zv4bVSyc; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B9A86E0E5; Mon, 26 Oct 2020 19:42:01 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 506666E0E5 for ; Mon, 26 Oct 2020 19:42:00 +0000 (UTC) Received: from localhost.localdomain (unknown [192.30.34.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7D49820878; Mon, 26 Oct 2020 19:41:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603741320; bh=mIfaVETSabg91MwqbVtm2b4ynodCXFlMtwDnztI5meU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zv4bVSycCE8I2wHh1gwb5oj3EdCQ0US/CCzuSG9f52ClGLEW8+82mpR63xjohRAnm 45GEtSA/kKAJW8n3bvLoISe7XUN4l2wy7rtqwo36g69yM6UJekGHH8K3VnckFIWxgA ig/wrXSqTSpEEqDbH/qwMlK74EglUUjR8u5+ArEE= From: Arnd Bergmann To: Patrik Jakobsson , David Airlie , Daniel Vetter , Stefan Christ Subject: [PATCH 4/4] drm/gma500: avoid Woverride-init warning Date: Mon, 26 Oct 2020 20:41:04 +0100 Message-Id: <20201026194110.3817470-4-arnd@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201026194110.3817470-1-arnd@kernel.org> References: <20201026194110.3817470-1-arnd@kernel.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Daniel Vetter , linux-kernel@vger.kernel.org, Rikard Falkeborn , Paul Kocialkowski , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Pankaj Bharadiya , Emil Velikov Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Arnd Bergmann gcc -Wextra notices that one of the fields in psbfb_roll_ops has two initializers: drivers/gpu/drm/gma500/framebuffer.c:185:20: warning: initialized field overwritten [-Woverride-init] Open-code this instead, leaving out the extraneous initializers for .fb_pan_display. Fixes: 3da6c2f3b730 ("drm/gma500: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/gma500/framebuffer.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) -- 2.27.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c index 54d9876b5305..a56a6b53fac6 100644 --- a/drivers/gpu/drm/gma500/framebuffer.c +++ b/drivers/gpu/drm/gma500/framebuffer.c @@ -177,7 +177,14 @@ static const struct fb_ops psbfb_ops = { static const struct fb_ops psbfb_roll_ops = { .owner = THIS_MODULE, - DRM_FB_HELPER_DEFAULT_OPS, + .fb_check_var = drm_fb_helper_check_var, + .fb_set_par = drm_fb_helper_set_par, + .fb_setcmap = drm_fb_helper_setcmap, + .fb_blank = drm_fb_helper_blank, + .fb_debug_enter = drm_fb_helper_debug_enter, + .fb_debug_leave = drm_fb_helper_debug_leave, + .fb_ioctl = drm_fb_helper_ioctl, + .fb_setcolreg = psbfb_setcolreg, .fb_fillrect = drm_fb_helper_cfb_fillrect, .fb_copyarea = drm_fb_helper_cfb_copyarea,