From patchwork Thu Nov 5 14:45:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320640 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp510991ilc; Thu, 5 Nov 2020 06:54:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJwXe1mSqxqXk6Z418+X2paA+WIBs/Xh4IqALq008U1mGt806QrVXdKUw8AGz/dExVzH7k7r X-Received: by 2002:a17:90a:550d:: with SMTP id b13mr2666255pji.133.1604587968805; Thu, 05 Nov 2020 06:52:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604587968; cv=none; d=google.com; s=arc-20160816; b=C2m+llRvjVpVpITYJHJ138fg0fwEIQ74n0yQz0Nug7D17Xs+ax1ZYKrRYuGEfkoFl5 Qeuc+z5N6dOcN3p0ofa9Oj27PaZ/79LN6T1OgXzIHe3BU4jnkXZBfp7r0Bxzusa6YbPH cuI126y5ypPQUwSFRQEepgNn1pDwj3ds8B+ciaaTongXmFEKqYTm7d9PBwS7zXaABzch v0O4Wxfza+Wf2PpZhBNusui+gbWDXPkuTAIMDCjG0YbiramOr38gz9K8DO1EEsk9v+wZ HZcIRj09K+vmU3PM+x+2nj/5zFJ+HPTjJW964qUruK70N2MkEgoGcWEugW2WeFAi0B7Q Rtfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=Way6JDoIO9hJHNu0k94khTex/HTkyX3JLpPoIUPdoJA=; b=fkixuDeriZOm6oD+W5kR/XOQOE1CFwVsrPESuNwVtA4roeqQ4hSblmqZqldfT/dWuC yzdMyCBnLpvXz9DZr67fOr+mm51NY5JHULmKGkhKY8PCDnwFZIIKQ+AeLUEiHfAnalUR UhHq1i0HxZldYhxH0cFBpoyvbRdlhtH+i1QFT9zO6UWpoj6PGUQOy7dCj763KcRTSTkn uTuVTgJFTqIhP+vXadFiumKIAq0FL/sV/PSctTt71QnOoJESxCoPnPZ8CnYmJSdnXx15 Q3APeXDACq6gLO5irHsL/WQjziLgxoLf9BnUiamlFYBi6Rlw7ouQQvzBFM+hs3j1Egez 3KOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=KBwJ7sSz; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id n5si1767859pjk.51.2020.11.05.06.52.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=KBwJ7sSz; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DCE716EDA9; Thu, 5 Nov 2020 14:52:41 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id E667E6EDA0 for ; Thu, 5 Nov 2020 14:52:36 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id g12so2081728wrp.10 for ; Thu, 05 Nov 2020 06:52:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IlbFjA1pCKxkPmsP5EtFe6iKvE9D/xy8RlK3r75nIgE=; b=KBwJ7sSzoNNlJeM2LSJvEoNx0u2IjzwVfbxJtvfnkAyQneAXifgDuipGbxyIPmXaZc IUQ0H64STjSyAboATFDUOeOxFj6TCu5DASRAQ4SdaGzYak9HoVRmtzxjvDqzj+MZH0Bk t8RKh93xOdbfXIhI1vpPW60dy5WYFwmtX4VTRqj6MCUtk3A+65lrPPRg+8i/bwjhotQM nyn5BKBKMuXnrL0WNM5fhvAEsRhXCL0GyeTriYJFQgcUcmscWLQAavQIIUOUwxk06tp1 hZw6MU7gG88Rf8Zm3+TWjMjYr42iNeNjeSJxmD0ZHV+jNEaG4k4r5e1Qt6BZEe+fmsHz 0r7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IlbFjA1pCKxkPmsP5EtFe6iKvE9D/xy8RlK3r75nIgE=; b=NwSW03QnAPhG0UQ/upc7iIMeOcpsJCSVPhvphSUh53PDwjSGzttLMdkbDZ2jqpiYI9 t7QZyBFwRWRrRJAG0VtgNw0q/y01XNMh5vDdj3Noebb0nKGnbZBGgbohutOX8Vfv8VGh FrmZd9GX7BLoDuE50dmsqQcj5Jc/4AoHHvOZ5V3tVMrJyyHNkpCl11rPn5Km1hcKXZp0 SVm/UIv+OV3IZKRTj2OwmWICn9aUjS1F9l0pXlcQrJwTYavI721TbLLBFFwNapr+ospz Uh+eReccaRPjpDyHSYyYvU9z7qd2R32WF0Puf0hPIVahNItjddTINZdQQtujIadGUDeU pL+Q== X-Gm-Message-State: AOAM533/hKC1EzNA2mm45jRz9huPBlceS7/9vsqbqhIcbcrDQYXWCmmI lou+MlpA1LvFNJWtLCuPon97xP0WiKgPKcLC X-Received: by 2002:adf:e443:: with SMTP id t3mr3470794wrm.14.1604587955662; Thu, 05 Nov 2020 06:52:35 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:34 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 17/19] gpu: drm: radeon: radeon_device: Fix a bunch of kernel-doc misdemeanours Date: Thu, 5 Nov 2020 14:45:15 +0000 Message-Id: <20201105144517.1826692-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" - Demote non-conformant headers - Fix misnaming issues - Rename labels with identical names - Remove incorrect descriptions Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_device.c:637:6: warning: no previous prototype for ‘radeon_device_is_virtual’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/radeon_device.c:552: warning: duplicate section name 'Note' drivers/gpu/drm/radeon/radeon_device.c:556: warning: duplicate section name 'Note' drivers/gpu/drm/radeon/radeon_device.c:561: warning: duplicate section name 'Note' drivers/gpu/drm/radeon/radeon_device.c:564: warning: duplicate section name 'Note' drivers/gpu/drm/radeon/radeon_device.c:1106: warning: Function parameter or member 'family' not described in 'radeon_gart_size_auto' drivers/gpu/drm/radeon/radeon_device.c:1291: warning: Function parameter or member 'ddev' not described in 'radeon_device_init' drivers/gpu/drm/radeon/radeon_device.c:1565: warning: Function parameter or member 'dev' not described in 'radeon_suspend_kms' drivers/gpu/drm/radeon/radeon_device.c:1565: warning: Function parameter or member 'suspend' not described in 'radeon_suspend_kms' drivers/gpu/drm/radeon/radeon_device.c:1565: warning: Function parameter or member 'fbcon' not described in 'radeon_suspend_kms' drivers/gpu/drm/radeon/radeon_device.c:1565: warning: Function parameter or member 'freeze' not described in 'radeon_suspend_kms' drivers/gpu/drm/radeon/radeon_device.c:1565: warning: Excess function parameter 'pdev' description in 'radeon_suspend_kms' drivers/gpu/drm/radeon/radeon_device.c:1565: warning: Excess function parameter 'state' description in 'radeon_suspend_kms' drivers/gpu/drm/radeon/radeon_device.c:1669: warning: Function parameter or member 'dev' not described in 'radeon_resume_kms' drivers/gpu/drm/radeon/radeon_device.c:1669: warning: Function parameter or member 'resume' not described in 'radeon_resume_kms' drivers/gpu/drm/radeon/radeon_device.c:1669: warning: Function parameter or member 'fbcon' not described in 'radeon_resume_kms' drivers/gpu/drm/radeon/radeon_device.c:1669: warning: Excess function parameter 'pdev' description in 'radeon_resume_kms' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_device.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c index 266e3cbbd09bd..7f384ffe848a7 100644 --- a/drivers/gpu/drm/radeon/radeon_device.c +++ b/drivers/gpu/drm/radeon/radeon_device.c @@ -544,21 +544,21 @@ int radeon_wb_init(struct radeon_device *rdev) * Note: GTT start, end, size should be initialized before calling this * function on AGP platform. * - * Note: We don't explicitly enforce VRAM start to be aligned on VRAM size, + * Note 1: We don't explicitly enforce VRAM start to be aligned on VRAM size, * this shouldn't be a problem as we are using the PCI aperture as a reference. * Otherwise this would be needed for rv280, all r3xx, and all r4xx, but * not IGP. * - * Note: we use mc_vram_size as on some board we need to program the mc to + * Note 2: we use mc_vram_size as on some board we need to program the mc to * cover the whole aperture even if VRAM size is inferior to aperture size * Novell bug 204882 + along with lots of ubuntu ones * - * Note: when limiting vram it's safe to overwritte real_vram_size because + * Note 3: when limiting vram it's safe to overwritte real_vram_size because * we are not in case where real_vram_size is inferior to mc_vram_size (ie * note afected by bogus hw of Novell bug 204882 + along with lots of ubuntu * ones) * - * Note: IGP TOM addr should be the same as the aperture addr, we don't + * Note 4: IGP TOM addr should be the same as the aperture addr, we don't * explicitly check for that thought. * * FIXME: when reducing VRAM size align new size on power of 2. @@ -627,7 +627,7 @@ void radeon_gtt_location(struct radeon_device *rdev, struct radeon_mc *mc) * GPU helpers function. */ -/** +/* * radeon_device_is_virtual - check if we are running is a virtual environment * * Check if the asic has been passed through to a VM (all asics). @@ -1100,7 +1100,7 @@ static bool radeon_check_pot_argument(int arg) /** * Determine a sensible default GART size according to ASIC family. * - * @family ASIC family name + * @family: ASIC family name */ static int radeon_gart_size_auto(enum radeon_family family) { @@ -1276,7 +1276,7 @@ static const struct vga_switcheroo_client_ops radeon_switcheroo_ops = { * radeon_device_init - initialize the driver * * @rdev: radeon_device pointer - * @pdev: drm dev pointer + * @ddev: drm dev pointer * @pdev: pci dev pointer * @flags: driver flags * @@ -1550,12 +1550,9 @@ void radeon_device_fini(struct radeon_device *rdev) /* * Suspend & resume. */ -/** +/* * radeon_suspend_kms - initiate device suspend * - * @pdev: drm dev pointer - * @state: suspend state - * * Puts the hw in the suspend state (all asics). * Returns 0 for success or an error on failure. * Called at driver suspend. @@ -1656,11 +1653,9 @@ int radeon_suspend_kms(struct drm_device *dev, bool suspend, return 0; } -/** +/* * radeon_resume_kms - initiate device resume * - * @pdev: drm dev pointer - * * Bring the hw back to operating state (all asics). * Returns 0 for success or an error on failure. * Called at driver resume.