From patchwork Fri Nov 6 21:49:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320854 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1657212ilc; Fri, 6 Nov 2020 13:50:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJyQ1YHaL6w9nWkyU4dzy4nOWNSa3g8v28JF/7z+WTroBhHUq3PicP5eA+052FGlpAmF5FwR X-Received: by 2002:a65:4cc9:: with SMTP id n9mr3437301pgt.236.1604699425308; Fri, 06 Nov 2020 13:50:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604699425; cv=none; d=google.com; s=arc-20160816; b=w/dBc7dJU66cF5D6ARiXCiY0UbYNrGur5QSMUabx0FRoEooWw4g3sE5RooPndWrbm3 mhSt5viNnMOn8nVMo+2Hir8qFhOgsKQfHdhxcvqPXD+hAMC9OjPnD0dp50GwLqowEClr /SaPfyg9m0f3RWb30ap78HPjJtiglxheaBMWNtSop+WKM0E9oozpQk8rME6jT84zCts1 0D42J6mE6l53IRcmWMFeYVTEVJOia+zUgvDE64wmTgnO1tPsyuy10QwmUn9bOSbzNkKz d0AtZOg3jFSPAdui8aVKHicSoOaiOpTUsMeSDtSOFaNA89mGHExOp5buqdKHZ2dRtqQ4 BsnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=Pu6HcgNXp8+BfH95S97IMYTkvlSWuNN2g4IotxycIlQ=; b=Pa3iHPaPgSYBXgHXUa0n9SxR/RzDTQZt7E+P9qJNk7MSbPLUN0Lgu7AivWv39Kwjn1 gH3zaAClnus68GcQOIgAOOckENmaG8MdT+0jip3k31FpkCFOQW3WiUZhZvQsfCM6JvWw pMFhvl28Bwj5DbjHRCUDweSDKm9lz6c/EirYZA8Qn5tGiEN7r/ZZEvkGIKq3JyHLMVLa 9rk7whr+QrGtjCUnm7B/aRFpVSuVQ2eG8RN16jct96QeOUe02/6yy7i8Ybe1acMOZK1o 7oMyZDJo6CSAlxTIzwb7W1CKQQlw6umpwOmchyAB0qnKYRw83l650prDvbRwA/Vy9mEB yTGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=CTrg6Tx6; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id i21si2008010pfu.115.2020.11.06.13.50.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=CTrg6Tx6; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D47F56EB2D; Fri, 6 Nov 2020 21:50:14 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 576D96EB26 for ; Fri, 6 Nov 2020 21:50:12 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id g12so2772431wrp.10 for ; Fri, 06 Nov 2020 13:50:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/vzXOfe3LQJ1tPjw4mGTlBd2Hha/B9WB2NE4h+LPHsM=; b=CTrg6Tx6WbaAEcip1oP69BTNYGApk3DcwyCdUIuDQ2NDdnRBvWJ1vAX/ZU360Uj2H3 z2RJwZ1+S16zy979ZmaON1OE5ShHP9tn4UZpPgSmyA/uBIfj1vjmH+jWAjbfh3kcAI+N vT9asDh4Mu/wxBCF1XvL2esu1JYbTTLz+JNFFGMzs0UJu4zl3JLxby5TvA9gZghh1n8E xgYZIZKANmxc4y1D04xef/nQe3Mc/WsFTjsItHINOS2+gcjAGg4rCIRkTLtMqCjztxQv AImujyKOROsE+WUyTvErplm6dKHsfOgyEv5JJ1hSVPExxmbbHfSR6B+4fSicdViUancm iJig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/vzXOfe3LQJ1tPjw4mGTlBd2Hha/B9WB2NE4h+LPHsM=; b=NVe2ON7cE4I1wNofpJWilHm4AMmUF/m10vnnxbz9RFP5VsJM5HxCgNmaihB+Pr58HT 6EQ1noYN0fmjEWkY7QKeJfDOo/k1k+/CdnYv/kl0u8T8HpopVE7tQCqdHZrkIUMHTr5/ RT3gLyazzbpTMODB6F3HYk6Wdsv/akJjanspF/j6CDppX32ygofkisKM5fZp2r+j8Z1x kmxxYNBeLrbjo0S7nFxxePHGyewpQKaUnGsaX72VwXesjpZ32+LxLr5qGSOoyJZO34Jg fweTlPkaZhO8rOp8zLtLEWbO2+NVyBadBbD9i4Xo8+fASRt4WHkwYESZFXeMMpxaHpCr AHzg== X-Gm-Message-State: AOAM530sYbA2SytnLd86o0v/e0dkXCpmsk0w55UP2qnPMMHG5CbAiCvm OuXc8tWqN1RPNDRrB4OLwKSkNA== X-Received: by 2002:adf:e551:: with SMTP id z17mr4904423wrm.374.1604699411021; Fri, 06 Nov 2020 13:50:11 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:50:10 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 14/19] drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr' params Date: Fri, 6 Nov 2020 21:49:44 +0000 Message-Id: <20201106214949.2042120-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106214949.2042120-1-lee.jones@linaro.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Alex Deucher , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:594: warning: Function parameter or member 'reg_addr' not described in 'amdgpu_device_indirect_rreg' drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:624: warning: Function parameter or member 'reg_addr' not described in 'amdgpu_device_indirect_rreg64' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 300fcade4a2b1..63374d12e00fe 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -585,6 +585,7 @@ void amdgpu_mm_wdoorbell64(struct amdgpu_device *adev, u32 index, u64 v) * @adev: amdgpu_device pointer * @pcie_index: mmio register offset * @pcie_data: mmio register offset + * @reg_addr: indirect register address to read from * * Returns the value of indirect register @reg_addr */ @@ -615,6 +616,7 @@ u32 amdgpu_device_indirect_rreg(struct amdgpu_device *adev, * @adev: amdgpu_device pointer * @pcie_index: mmio register offset * @pcie_data: mmio register offset + * @reg_addr: indirect register address to read from * * Returns the value of indirect register @reg_addr */