From patchwork Tue Nov 10 19:30:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 322859 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp500272ils; Tue, 10 Nov 2020 11:31:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJwSIqGfTUrm9v1z7QnTRF7hzxzFc51lG0eL9/Qr8rEfrGbNmXwk0cKCiRFbD7wF5EiAqtZ3 X-Received: by 2002:a05:6a00:7d7:b029:18c:5ac1:d6b4 with SMTP id n23-20020a056a0007d7b029018c5ac1d6b4mr2788387pfu.32.1605036698399; Tue, 10 Nov 2020 11:31:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605036698; cv=none; d=google.com; s=arc-20160816; b=qYeN1WNBI8ay2wO7dmsGX0K+CCHgUkIdWBtjosjW4a0Pc6PYa8wOpaN7DxAd+E+rVe WGgJka8jnRLPChO1iArkHQOsPlvKnt2ugDCZFzimzloCP3V3ZM/T7XH48PJkAkvVIOaM 0tqBksIn1x9ZLaWnQ+wV3R9S5cOC0s/RDS6Z/LaM3HHgc45YWcvnEVgrnWRIN6SAIpuA 25f+xYnW+aBDYqR1TmYU70w/rVujkPgIW9PzahP4iUDjmt3GQu00J2joaI+fKRM0Zjp/ 781iH61JcMrC7B5oMhRI5eFKmfz74uq0MGRsmMyVKNRENNJJzk18cogVSs5m3E21sMup Kbeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=IZ6b/QMXPG0fAiQZ74HQvizbv7r2zZP/I5P4lG3UpVQ=; b=sQBjWMoaZYGGgeL9y9irrZ0S08Haj10a02v0BLg5wV/318dIBODWYkRW7xS5iYhpd2 5x6bphZ2foEAaEGIP8GtcZT9reWJH/OnHH50kQpLPdZMMc/pReDlPHDzvfQgEM3MyGEy WeygSE92vUmSVj2SK+hYkttZedllGObVmXfN+Cjd0/s95PrWPWLCdRpi9Q5y1E9Cmxoi Pu/87DCqS6PluIiuRay3iWu9L5Z4GvL6eRUtkLUNA2komoydPkDt3USgqJaHfS1/i0ms 6Yw8M1qfzW8LNXIgmF6ecw5UKSK2mrNyNZhNXOOMrxbMkasJlttKtC5/9xkZafs4J8bp MkWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ZoCAeWqO; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id s188si12421130pgc.165.2020.11.10.11.31.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 11:31:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ZoCAeWqO; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C781489BE8; Tue, 10 Nov 2020 19:31:29 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1973389BE8 for ; Tue, 10 Nov 2020 19:31:29 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id o15so6164846wru.6 for ; Tue, 10 Nov 2020 11:31:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=niuclzZLrXXllUvyLIlNhRMSWO6LD3jFvv7VGpxMEl8=; b=ZoCAeWqOWnwlTA6KsKAUyspJhNqifj65RCAJ2Bbve89rw9W2XKZNT8qx9vnCUrG+70 +CFU7uXuG2uDCdH4IBNlSUQYOHyma6KqozSOVJNzx7fLBiC495M1QHG0kXo7/De7OnpV ignD954xFpyTo1V0XphVRlSM9fXgFrtktfiGjgPGjjmbnm/3S9aSybfx0jc/kSFQhwP1 M8jJ9JEPfjZZ8zvDkowuVkWPF6K0LaTkW3Dw+aOje1kLR+21+ODvaMmJT1B9jfNaVC4f gukHJ0YC7YiPPKt1NOhnmVXVnDaLevKvD6A1tTGEjelGUVGvJaZjHxf7qmgAI4Q66Thf wtQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=niuclzZLrXXllUvyLIlNhRMSWO6LD3jFvv7VGpxMEl8=; b=C7+fBT1Jjhx2fzPGA4NhBS++HPIstatWylR03Lz0Ziwztig8u49NysJpPnQKSmIpTM ye1fHPGJ5xhE67kfJNFbARSRB8Rb0cAXAaT9/0ycak+PnZidLRnwbaWC+yLY+LsLOPxh sFueHml9koEOfExK7+e+5r1tiW+4SaEOPH6fexMNTiOhAYjWm6C56DKWOAgexEZSFbYW RWlNcujHM2mz5ES8KhZnB/FFVcg9jbYWU0bDWMlh9TlT5KIJVPhWNCccNBlnp12jgAX5 AaWMlI6oM0lG/9X4HWis8WdfocgzMXY62BMs421yYa5/0UZffUM4uUSCB/TRUzfITJLj a3ZA== X-Gm-Message-State: AOAM533YLNKCQ3TP5ft5aZcaGkBn9eH4EDNpGDd4DETXm2CDkMjOLAl3 9WSkdRxgGicRSj3Lr/aaCSjbFQ== X-Received: by 2002:a5d:670f:: with SMTP id o15mr8801086wru.204.1605036687702; Tue, 10 Nov 2020 11:31:27 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 30sm17635335wrs.84.2020.11.10.11.31.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 11:31:26 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 09/30] drm/radeon/radeon_vm: Fix some function parameter documentation Date: Tue, 10 Nov 2020 19:30:51 +0000 Message-Id: <20201110193112.988999-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201110193112.988999-1-lee.jones@linaro.org> References: <20201110193112.988999-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_vm.c:131: warning: Function parameter or member 'rdev' not described in 'radeon_vm_get_bos' drivers/gpu/drm/radeon/radeon_vm.c:643: warning: Excess function parameter 'start' description in 'radeon_vm_update_page_directory' drivers/gpu/drm/radeon/radeon_vm.c:643: warning: Excess function parameter 'end' description in 'radeon_vm_update_page_directory' drivers/gpu/drm/radeon/radeon_vm.c:819: warning: Function parameter or member 'ib' not described in 'radeon_vm_update_ptes' drivers/gpu/drm/radeon/radeon_vm.c:915: warning: Function parameter or member 'bo_va' not described in 'radeon_vm_bo_update' drivers/gpu/drm/radeon/radeon_vm.c:915: warning: Excess function parameter 'vm' description in 'radeon_vm_bo_update' drivers/gpu/drm/radeon/radeon_vm.c:915: warning: Excess function parameter 'bo' description in 'radeon_vm_bo_update' drivers/gpu/drm/radeon/radeon_vm.c:1155: warning: Excess function parameter 'vm' description in 'radeon_vm_bo_invalidate' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_vm.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c index 27b14eff532cb..71f2edcac6ea0 100644 --- a/drivers/gpu/drm/radeon/radeon_vm.c +++ b/drivers/gpu/drm/radeon/radeon_vm.c @@ -119,6 +119,7 @@ void radeon_vm_manager_fini(struct radeon_device *rdev) /** * radeon_vm_get_bos - add the vm BOs to a validation list * + * @rdev: radeon_device pointer * @vm: vm providing the BOs * @head: head of validation list * @@ -629,8 +630,6 @@ static uint32_t radeon_vm_page_flags(uint32_t flags) * * @rdev: radeon_device pointer * @vm: requested vm - * @start: start of GPU address range - * @end: end of GPU address range * * Allocates new page tables if necessary * and updates the page directory (cayman+). @@ -802,6 +801,7 @@ static void radeon_vm_frag_ptes(struct radeon_device *rdev, * * @rdev: radeon_device pointer * @vm: requested vm + * @ib: indirect buffer to use for the update * @start: start of GPU address range * @end: end of GPU address range * @dst: destination address to map to @@ -900,8 +900,7 @@ static void radeon_vm_fence_pts(struct radeon_vm *vm, * radeon_vm_bo_update - map a bo into the vm page table * * @rdev: radeon_device pointer - * @vm: requested vm - * @bo: radeon buffer object + * @bo_va: radeon buffer object * @mem: ttm mem * * Fill in the page table entries for @bo (cayman+). @@ -1145,7 +1144,6 @@ void radeon_vm_bo_rmv(struct radeon_device *rdev, * radeon_vm_bo_invalidate - mark the bo as invalid * * @rdev: radeon_device pointer - * @vm: requested vm * @bo: radeon buffer object * * Mark @bo as invalid (cayman+).