From patchwork Thu Nov 12 19:00:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 324242 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp589456ils; Thu, 12 Nov 2020 11:01:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJwRHCgtAyGqhuadhPgifi++AtsGGpAjAGSiOvbyC1Iamehmi0wy14IR3GRi8f2cSgdRfw2Z X-Received: by 2002:a17:902:9b89:b029:d2:42a6:88f with SMTP id y9-20020a1709029b89b02900d242a6088fmr684307plp.71.1605207707270; Thu, 12 Nov 2020 11:01:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605207707; cv=none; d=google.com; s=arc-20160816; b=Oj9UpcmV39AF5TYkrUCzffkzBeOKiNyUF9Sa0AG3WxYJyv8n/nhTIk//ErG63i1mzk qOa5jo5KfqNbNuTRCAcAUjid3VjQBATt0XRdLQsxF6IsCy3KTrgyYZikjxB6eSfPf4GJ irTjf/yZhl0uYYhKA4kmPmije5j3MEsvv0M8orNDPn72HlWp/jL7WFR9T5JwQyUhrazU ensocB+FQGKRHhcVuy177dduB9Vteo1cpwDvPcy27lih8lkL+C0J5FhllUclRahpvIvY lPz5YUNZR0p5ceM4u1DKdQ2ho9u+KiAh0epbZdrKRAqdAmMrTXtDK9nPYN2G/+jCjlTg ICAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=Y3smD7tfd4dI9mhtJ4OBAEj6KueKuMdc2jcCl3ZnuSA=; b=SXD7q7mLhofPlivv6eJW4lmh2nIwXcvgdcOPYnupMwWDB22WZhVvc5mNEgCsNz5s/e ZMpP+8Ptlc7ZwuiwsQikwGcna4WbtOHMOoI0sQ0sZgIf6NrjtHV/Xwo0iJnkWgsxUFfw pjBvFbDygtmtF3fzLn9Wsh48UWWPgRzaiAQtY/yx36BaTjbmZ04EftixzSB9Ik5N8tix jOBtnZ+YFqayiTrO4F1DseWYYINTLN1LyhJ0Hu2ekCd5o02OI7NCUgUDPgb3HV5mYlCl xP60Bk9McjRnsUNpY9ng0X9vihXO6hvQ66Q/BxgKuD73AB+v3czuM4sHLAMLWUdtE3SB Dxsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=FOMvItAJ; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id o18si5124224pgu.541.2020.11.12.11.01.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 11:01:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=FOMvItAJ; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 402AF6E3DA; Thu, 12 Nov 2020 19:01:45 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 94BD36E3D3 for ; Thu, 12 Nov 2020 19:01:44 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id h2so6229392wmm.0 for ; Thu, 12 Nov 2020 11:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=voWmA7JwfKGhDZMYWPZkZRLYOBpcwZ/fXqx90N9cMjo=; b=FOMvItAJ0Md9/XJuA8i3NbOckDk4OyHY1Ktg8z5bTbeyfc0VUbHX3JR6E5RjZjjOLM g8zu3Vbo3kidmyTmmILO+V6dNh/L5YGOcUSc1YNvp0u6MHND/MEYT8en0ADTe0yAmeaC YZHfPlZQ8MWUb2GiOtxikAMibM+p9fBEBBns6wi6v2IyzstBnvQRx7TOhF4T3DOibaMv mxb70HHdB+MFALg6+/9scGOQ2zDf4CkH0FMfqzn2Ihthew/b3VMySshovs1+V2DcsbfZ X5cAZmUaEG175AvGHinOFF6+L+O0UAVoTkh3GpCDODnM47mTc94g2g3YpDVwT0vQlqtf ZRZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=voWmA7JwfKGhDZMYWPZkZRLYOBpcwZ/fXqx90N9cMjo=; b=HiQlTlXm9xDM8FdqH6WF+4B4w/p7HHf5C4gCs/TcpF+Fs/aTU4tJI8lYTZrGIKBYfc yerGJAUZ6tQTSRS4Ug82M0RW5lqvZJST5taXKSW4lu7SADiKvTJLsQK7ZOU1Ym+P7akK pBjpfnpOwDpyPQ5y1a815zSQdVaoSbSse2pZrsnOqR1z1ioz4wktHnpuX9xbvFKAxtV1 TJQAxcUaIJSHc+laFKJFbFTZT6DvOGO+9mGwGr/zowVBL/sUg90Ny5mtVtbDaVADr2hP BPrJFgVsKyuETR4Rp6JJAjrT6tmI3m1JVz97FiocGnQj6osrrTwNRtoufeqUcZbEIN2D QzCw== X-Gm-Message-State: AOAM531mx3kd7g/xTIOWkNpBj9U9cb1iX5Ud0EyIDbdT3tsPZvWLadol 8lUOBk/PbNvlX3MOLfiNQhCvgA== X-Received: by 2002:a05:600c:2285:: with SMTP id 5mr1047874wmf.149.1605207702385; Thu, 12 Nov 2020 11:01:42 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id p4sm8105214wrm.51.2020.11.12.11.01.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 11:01:41 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 24/30] drm/nouveau/nvkm/core/firmware: Fix formatting, provide missing param description Date: Thu, 12 Nov 2020 19:00:33 +0000 Message-Id: <20201112190039.2785914-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112190039.2785914-1-lee.jones@linaro.org> References: <20201112190039.2785914-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ben Skeggs Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" ... and demote non-conformant kernel-doc header. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/core/firmware.c:71: warning: Function parameter or member 'subdev' not described in 'nvkm_firmware_get' drivers/gpu/drm/nouveau/nvkm/core/firmware.c:71: warning: Function parameter or member 'fwname' not described in 'nvkm_firmware_get' drivers/gpu/drm/nouveau/nvkm/core/firmware.c:71: warning: Function parameter or member 'ver' not described in 'nvkm_firmware_get' drivers/gpu/drm/nouveau/nvkm/core/firmware.c:71: warning: Function parameter or member 'fw' not described in 'nvkm_firmware_get' drivers/gpu/drm/nouveau/nvkm/core/firmware.c:106: warning: Function parameter or member 'fw' not described in 'nvkm_firmware_put' Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c index 8b25367917ca0..ca1f8463cff51 100644 --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c @@ -58,9 +58,10 @@ nvkm_firmware_load_blob(const struct nvkm_subdev *subdev, const char *base, /** * nvkm_firmware_get - load firmware from the official nvidia/chip/ directory - * @subdev subdevice that will use that firmware - * @fwname name of firmware file to load - * @fw firmware structure to load to + * @subdev: subdevice that will use that firmware + * @fwname: name of firmware file to load + * @ver: firmware version to load + * @fw: firmware structure to load to * * Use this function to load firmware files in the form nvidia/chip/fwname.bin. * Firmware files released by NVIDIA will always follow this format. @@ -98,7 +99,7 @@ nvkm_firmware_get(const struct nvkm_subdev *subdev, const char *fwname, int ver, return -ENOENT; } -/** +/* * nvkm_firmware_put - release firmware loaded with nvkm_firmware_get */ void