From patchwork Mon Nov 23 11:19:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 330598 Delivered-To: patch@linaro.org Received: by 2002:a92:ae0b:0:0:0:0:0 with SMTP id s11csp1907732ilh; Mon, 23 Nov 2020 03:20:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJwmu5xWyXLctJOIelj7vIU1KoJuTb5kOZj8gaPtC4DkVWpDC/sRllnLGR9kStRE3fHsOAJ7 X-Received: by 2002:a17:90a:62c8:: with SMTP id k8mr24069880pjs.33.1606130424566; Mon, 23 Nov 2020 03:20:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606130424; cv=none; d=google.com; s=arc-20160816; b=XYQ2r67EIKWO5Yaaahx7pyZ/oXBhbq5+MUubdZ6LCmCg3YAGgaKaFlNMI8Q+lgAyaG ryD3qT5NR9SFaKhvImLaTU73w1BcnqS025PnSd8RMXUjyQGR969aLhfoK/kllJWqja6p zUTbGQRxkDxkXCVGsLxICnUiLcQ6Tw2vlAABv3isUzrSj/vB1WUuWrQIizj2wg0lxlOO s/c5TghgCnXGlN/oS4mWDGwbmIfWdwczYHSj3zcQr46eQzz2DEVC0kDd/60B+Mucqnly XoJEdM3WpoI/SLzdTZ8NCiBLR3obNZcrOplcpgD651GG13tXf4Ur/kW0P6BztOnbobHs 9O/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=aJVp+MESPEcLen8/JninKcw62p4g7P5XQT7e/74QEck=; b=yf4xo6wz8eczihMkLKMJKo1vPglG7KYWJc3BMn0HtEUyqfh6gnPfDYuQckFRpfGYX1 NhS92WkjMNhhQyIG03V2DJFXwIRcRivzj8rU5QaEC+eTfM5CjWVt3/PeDDlSqOq7/myi q8yCnRddywGwKgkUXCWDuDZabmGpeW2962DF4kS3FqRPIGdH5UR0qjwGPvJV/oc9+RkH KVu2TFSUyDd9Py/Y3PETdC1rTQZAXS3zaz1UowNqFiQccZHDiddzHXZrNJDMnJq932At oZKWA0F/c8Cl+hPTD0F1jp/r/PWAWd+Rfr9u4J/rYP3zA0XKhp7I/5y30SvSbp6wCbwh bFQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=j2lpQSm4; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id ms17si10472782pjb.155.2020.11.23.03.20.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 03:20:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=j2lpQSm4; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 581DE89F6D; Mon, 23 Nov 2020 11:20:06 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8607889D73 for ; Mon, 23 Nov 2020 11:19:50 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id g14so2998193wrm.13 for ; Mon, 23 Nov 2020 03:19:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wldsqjpaFVDFoYgF4DYJ7wI1w74XU6uKcd1AqstflIg=; b=j2lpQSm4QAruRHwdMh9MeGZIC4kPQ82NerLc4fhX1Bf7ALSDHI5+t4h/QNS+ETUlkP Oc0ibH/V0O5O1c3FC3j5OXzmPUqRr9hDN829yi5pqtPFDwVbfrnW3SnegJl6K/xqflq/ 7cv3kQf3peWq0HBjW8kRrH1PMz7wRm+kNtLf1Q5A8IDR3OuihiLFyjl2GN7VJraUbohg c7Kn0VF2HguehowbndbNIUhMlyJv1A9XAVuBA3ozsUiqXFLfq6qlZr2eFDpFmChxIatw WlIJQhIOb2zFNvbP+nwZOsSV6Km0QodzzixeR1P/WvdhBx1dFeoaIIN6HIgM2+vD+p8k H+xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wldsqjpaFVDFoYgF4DYJ7wI1w74XU6uKcd1AqstflIg=; b=VDFXJtZRY3gv9nOOjt+PLgOY6dKZgT54Ju0lGKjLImErXRg1EE2gSilxWwtLzN9JhX SOmXGoTdci8k2kiTVOydSSA7LAdjqtIWnLiA6hTOVSPdhm0V8a5+pg3JMUU3VGe4aBhq mke+YVW5bU1H1+F07IlimqLPbEwI9+ovZ3Ts57DpVfAQbKFkOjmwEqBmUua8x0ms7FxT pGTpQ5ch7JBdfqPZDqs+wxv0kVHUlulbH6v5sYtCLGQTA3nzfH0Z5HtvVOFzP2BBrGRx g9itTy/8QL93dgWQxHqUSlzg1X3xy5WgfJnAMRjgXOh+w+eWCDixybgLVV+AlLpLjodV EiRw== X-Gm-Message-State: AOAM533phx/3KL3GxkjmxKkbGyHKvixSmojcKVIsg2gGq0pVEhYX5SnB 0UcfXXIlA+3uux1BGYE5HB6CVg== X-Received: by 2002:a5d:4d92:: with SMTP id b18mr9164383wru.260.1606130389281; Mon, 23 Nov 2020 03:19:49 -0800 (PST) Received: from dell.default ([91.110.221.218]) by smtp.gmail.com with ESMTPSA id n9sm16317290wmd.4.2020.11.23.03.19.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 03:19:48 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 21/40] drm/amd/amdgpu/uvd_v3_1: Fix-up some documentation issues Date: Mon, 23 Nov 2020 11:19:00 +0000 Message-Id: <20201123111919.233376-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201123111919.233376-1-lee.jones@linaro.org> References: <20201123111919.233376-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Sonny Jiang , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c:91: warning: Function parameter or member 'job' not described in 'uvd_v3_1_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c:91: warning: Function parameter or member 'flags' not described in 'uvd_v3_1_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c:108: warning: Function parameter or member 'addr' not described in 'uvd_v3_1_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c:108: warning: Function parameter or member 'seq' not described in 'uvd_v3_1_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c:108: warning: Function parameter or member 'flags' not described in 'uvd_v3_1_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c:108: warning: Excess function parameter 'fence' description in 'uvd_v3_1_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c:625: warning: Function parameter or member 'handle' not described in 'uvd_v3_1_hw_init' drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c:625: warning: Excess function parameter 'adev' description in 'uvd_v3_1_hw_init' drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c:692: warning: Function parameter or member 'handle' not described in 'uvd_v3_1_hw_fini' drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c:692: warning: Excess function parameter 'adev' description in 'uvd_v3_1_hw_fini' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sonny Jiang Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c b/drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c index 7cf4b11a65c5c..143ba7a41f41f 100644 --- a/drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c @@ -80,7 +80,9 @@ static void uvd_v3_1_ring_set_wptr(struct amdgpu_ring *ring) * uvd_v3_1_ring_emit_ib - execute indirect buffer * * @ring: amdgpu_ring pointer + * @job: unused * @ib: indirect buffer to execute + * @flags: unused * * Write ring commands to execute the indirect buffer */ @@ -99,7 +101,9 @@ static void uvd_v3_1_ring_emit_ib(struct amdgpu_ring *ring, * uvd_v3_1_ring_emit_fence - emit an fence & trap command * * @ring: amdgpu_ring pointer - * @fence: fence to emit + * @addr: address + * @seq: sequence number + * @flags: fence related flags * * Write a fence and a trap command to the ring. */ @@ -617,7 +621,7 @@ static void uvd_v3_1_enable_mgcg(struct amdgpu_device *adev, /** * uvd_v3_1_hw_init - start and test UVD block * - * @adev: amdgpu_device pointer + * @handle: handle used to pass amdgpu_device pointer * * Initialize the hardware, boot up the VCPU and do some testing */ @@ -684,7 +688,7 @@ static int uvd_v3_1_hw_init(void *handle) /** * uvd_v3_1_hw_fini - stop the hardware block * - * @adev: amdgpu_device pointer + * @handle: handle used to pass amdgpu_device pointer * * Stop the UVD block, mark ring as not ready any more */