From patchwork Mon Nov 23 11:18:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 330584 Delivered-To: patch@linaro.org Received: by 2002:a92:ae0b:0:0:0:0:0 with SMTP id s11csp1907331ilh; Mon, 23 Nov 2020 03:19:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJyRrW3R8wjO35GkPkS4SKNMQP6ng1pF+WiV5/byacRInMoaH3S+eD6n7NIpNpd41pvw7oxL X-Received: by 2002:a63:5b23:: with SMTP id p35mr1197343pgb.143.1606130387007; Mon, 23 Nov 2020 03:19:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606130387; cv=none; d=google.com; s=arc-20160816; b=cM/DexDRiIcHBUWIQ4JAgRB15JyGFLNBbk+DXLPFbbO2giEvU612dzZe2RSKGaNWqR ZXCuOIIv/h/ndw2X3hKRvNdi81OAVatpOUAfoppnqDl5jsj2hzSiX0BJ5Fs8N+cGWyQi G/i/Vj86BmtQxGKvng1lZ51p63fjngT3xZ0EmRmygDbjt+PWZn2uvNDazvM3LhIuAXoo tJBVlugsGPpD5ft87L5+beQFjot30AojbG/scJG2uu8TdqyU9O40n2JVqZs3Hsu2sUCF 4xTIDe/Zdxp7jtnTCo5qSlbFGBzMqDDadGwlnOV7Pu6caWzAgcJsmX/09ag0mgioDt10 sC2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=yy6ZU5On8m7TWABygAKH/unE6jOJW4AHwB8M07hMD0U=; b=tYhb5Zyptwsbgt6FW6lhrYKbZAfTqnnjSrzqoaTbkpKWSNVxbkyBKa5LzcAVAw+0va 0eCCNXCDm7LnnlhTHwuDrPKPpowV6YdKFWR86cmp7qLcYfn52JUwZF50qmZ5nmQA4PJu EAJQpiqcjBqDXYTsAytaI0w1KLsK/AwJb0X/ZKphQcbIMTXdwQzlMQI+DsMbH1UZu4wV Ko4XHDhdHD49GFEEp1wd/jhDOOcNx93I3mI3UYqOXk9qRZOMX+IbolLoZp1pFRiLLQm8 rkZ5znPuAVdYwJWq8y9HiSb9K1K4R6QsKKYO8hpebMHcWZggZdRsNqXVi8NUQDzTfkRt 7G/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="Q8/F5dkv"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id w3si10718697pga.412.2020.11.23.03.19.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 03:19:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="Q8/F5dkv"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F85689AB5; Mon, 23 Nov 2020 11:19:42 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 94A188945B for ; Mon, 23 Nov 2020 11:19:34 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id 64so4789411wra.11 for ; Mon, 23 Nov 2020 03:19:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wuoHjkSuaTmEWAC5wBJbYvKG9ftbec5HzD4t8NHscL0=; b=Q8/F5dkv4HHgJAblxBG31tsXQ9e4Y1SvpMMk9ptk+QHDVSiYCvAPXSmfvSkut0Vb2T FbSE/FcTesIoOgShRcjPdSI0R/TlXnou23f0nDG3aSfIsh5FQm8f2OR97Tx04NZJj07b fT+koqDmkCl9c01yYEYGWS2pPQK3RCPINQp3s5S8DZWyoLSogz5AsVqD5g3koTgEuud1 MrUoEe1R5xhWOLLgwf72/YnglY7op0GSZOCf+mJtL0HtoDXIpscciledSLJsOX3sHzdQ BLrGPIYbbd8S9vjvRdCbOCjbkRCgK9y3F0NTK+OxOYA1B1Zix/JcNfD3ZcJKh5SdOl7q xjZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wuoHjkSuaTmEWAC5wBJbYvKG9ftbec5HzD4t8NHscL0=; b=ES1ecVAns4fZ6duwN7ow3/7C4UqNWp7kGhyrBOOFlfXc8GK+kclf6r2xf5ALZ72N1T DVfYuyAaKmTR7svFNpk48COFEuKrsVVG9e4/PW2PvAmT0QpcfQc8c23GDbtklpXQUnrG B41njSI7SIqVw85QM8sdz9cclsLO/9PKEbF3ZU49ruwur2gpAz5/zpE3jxBK30m4ANMj cxAtCwzfUWNVxRDMSP8XXdcz/mKMICnXA4s+jZFigwrIN6LtPTOEB7BIsm8U3M0Sj61V oDOBSndkhEPNJ426c9XxxNoF0SA0+u+OE976TdV3BKVoOJWAOEDCLo+1YFwhgDk2L2fd s2Jw== X-Gm-Message-State: AOAM531XEC9RF1PC+iXT7ErGYuITNv4wkySxK0BCmDSx01uonlMeOn5k QQANiyEe7ydmW+5k0iHMAa0+PA== X-Received: by 2002:adf:f441:: with SMTP id f1mr30639986wrp.225.1606130373264; Mon, 23 Nov 2020 03:19:33 -0800 (PST) Received: from dell.default ([91.110.221.218]) by smtp.gmail.com with ESMTPSA id n9sm16317290wmd.4.2020.11.23.03.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 03:19:32 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 08/40] drm/amd/amdgpu/cik_sdma: Supply some missing function param descriptions Date: Mon, 23 Nov 2020 11:18:47 +0000 Message-Id: <20201123111919.233376-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201123111919.233376-1-lee.jones@linaro.org> References: <20201123111919.233376-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Alex Deucher , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/cik_sdma.c:226: warning: Function parameter or member 'job' not described in 'cik_sdma_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/cik_sdma.c:226: warning: Function parameter or member 'flags' not described in 'cik_sdma_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/cik_sdma.c:278: warning: Function parameter or member 'addr' not described in 'cik_sdma_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/cik_sdma.c:278: warning: Function parameter or member 'seq' not described in 'cik_sdma_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/cik_sdma.c:278: warning: Function parameter or member 'flags' not described in 'cik_sdma_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/cik_sdma.c:278: warning: Excess function parameter 'fence' description in 'cik_sdma_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/cik_sdma.c:663: warning: Function parameter or member 'timeout' not described in 'cik_sdma_ring_test_ib' drivers/gpu/drm/amd/amdgpu/cik_sdma.c:808: warning: Function parameter or member 'ring' not described in 'cik_sdma_ring_pad_ib' drivers/gpu/drm/amd/amdgpu/cik_sdma.c:859: warning: Function parameter or member 'vmid' not described in 'cik_sdma_ring_emit_vm_flush' drivers/gpu/drm/amd/amdgpu/cik_sdma.c:859: warning: Function parameter or member 'pd_addr' not described in 'cik_sdma_ring_emit_vm_flush' drivers/gpu/drm/amd/amdgpu/cik_sdma.c:859: warning: Excess function parameter 'vm' description in 'cik_sdma_ring_emit_vm_flush' drivers/gpu/drm/amd/amdgpu/cik_sdma.c:1315: warning: Function parameter or member 'ib' not described in 'cik_sdma_emit_copy_buffer' drivers/gpu/drm/amd/amdgpu/cik_sdma.c:1315: warning: Function parameter or member 'tmz' not described in 'cik_sdma_emit_copy_buffer' drivers/gpu/drm/amd/amdgpu/cik_sdma.c:1315: warning: Excess function parameter 'ring' description in 'cik_sdma_emit_copy_buffer' drivers/gpu/drm/amd/amdgpu/cik_sdma.c:1339: warning: Function parameter or member 'ib' not described in 'cik_sdma_emit_fill_buffer' drivers/gpu/drm/amd/amdgpu/cik_sdma.c:1339: warning: Excess function parameter 'ring' description in 'cik_sdma_emit_fill_buffer' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/cik_sdma.c b/drivers/gpu/drm/amd/amdgpu/cik_sdma.c index 1a6494ea50912..f1e9966e7244e 100644 --- a/drivers/gpu/drm/amd/amdgpu/cik_sdma.c +++ b/drivers/gpu/drm/amd/amdgpu/cik_sdma.c @@ -215,7 +215,9 @@ static void cik_sdma_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count) * cik_sdma_ring_emit_ib - Schedule an IB on the DMA engine * * @ring: amdgpu ring pointer + * @job: job to retrive vmid from * @ib: IB object to schedule + * @flags: unused * * Schedule an IB in the DMA ring (CIK). */ @@ -267,6 +269,8 @@ static void cik_sdma_ring_emit_hdp_flush(struct amdgpu_ring *ring) * cik_sdma_ring_emit_fence - emit a fence on the DMA ring * * @ring: amdgpu ring pointer + * @addr: address + * @seq: sequence number * @fence: amdgpu fence object * * Add a DMA fence packet to the ring to write @@ -655,6 +659,7 @@ static int cik_sdma_ring_test_ring(struct amdgpu_ring *ring) * cik_sdma_ring_test_ib - test an IB on the DMA engine * * @ring: amdgpu_ring structure holding ring information + * @timeout: timeout value in jiffies, or MAX_SCHEDULE_TIMEOUT * * Test a simple IB in the DMA ring (CIK). * Returns 0 on success, error on failure. @@ -801,6 +806,7 @@ static void cik_sdma_vm_set_pte_pde(struct amdgpu_ib *ib, uint64_t pe, /** * cik_sdma_vm_pad_ib - pad the IB to the required number of dw * + * @ring: amdgpu_ring structure holding ring information * @ib: indirect buffer to fill with padding * */ @@ -849,7 +855,8 @@ static void cik_sdma_ring_emit_pipeline_sync(struct amdgpu_ring *ring) * cik_sdma_ring_emit_vm_flush - cik vm flush using sDMA * * @ring: amdgpu_ring pointer - * @vm: amdgpu_vm pointer + * @vmid: vmid number to use + * @pd_addr: address * * Update the page table base and flush the VM TLB * using sDMA (CIK). @@ -1298,10 +1305,11 @@ static void cik_sdma_set_irq_funcs(struct amdgpu_device *adev) /** * cik_sdma_emit_copy_buffer - copy buffer using the sDMA engine * - * @ring: amdgpu_ring structure holding ring information + * @ib: indirect buffer to copy to * @src_offset: src GPU address * @dst_offset: dst GPU address * @byte_count: number of bytes to xfer + * @tmz: unused * * Copy GPU buffers using the DMA engine (CIK). * Used by the amdgpu ttm implementation to move pages if @@ -1325,7 +1333,7 @@ static void cik_sdma_emit_copy_buffer(struct amdgpu_ib *ib, /** * cik_sdma_emit_fill_buffer - fill buffer using the sDMA engine * - * @ring: amdgpu_ring structure holding ring information + * @ib: indirect buffer to fill * @src_data: value to write to buffer * @dst_offset: dst GPU address * @byte_count: number of bytes to xfer