From patchwork Tue Nov 24 19:37:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 331412 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp795478ilb; Tue, 24 Nov 2020 11:44:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJzrIu07z5TDo4SccQm1+myZBXBd59s8x2LCzcEzOCrtR0Tb4WBT8XO6kjU4jQkcvFD5z++h X-Received: by 2002:a17:90a:4dc3:: with SMTP id r3mr156442pjl.155.1606247062922; Tue, 24 Nov 2020 11:44:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606247062; cv=none; d=google.com; s=arc-20160816; b=fbZY8ezQfoHwQPQ9npzDXGOhQnZaAhndFZkz5iQP23c35aNIB0AgHb8j+kXBnHCxR8 8DD0+P9f5aHtVcpEMX+hBOpHdEgGasP+io+FNAVgxY4HGzp2oJnFggaOiWckXEgBvUSF uNDLp4JUj0s9ivm29FJ3ZpwP0UcmWnGSrbyZnZy2YJp6B/vV2SKtQ3I2hsXwwjuMhVqv 2qTeqWcp/D7nkPSN5QGCGEdSqnkI1Q5m/CfzELWKqgX23+Tm8zobRvxttDJR6NvswCH4 ZNfVJO7hwy2R1wR2OObnI7u+Pe5IbWET0Bj1yCO7a81RAFszvUMfVfXeOokpRlic6Dao 66JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=83yhUECEJrt7rcL8ZvfPPwfCGjWrMAdZ7TGeXKze3ec=; b=P0+ZHpQyMtwfFIXTsbN8WDH7X/Hq7vnhHOpTH1eop8cgAYuZmWY8kudlQdlCFj6gAf qoJMLlGye2tgeyrWzKuTW2R4HTRe3UE6Br8K+BWptgQL34FWr6ZsOnDpPr4/08Dy7vgI opePn0ef7YAGadi1Sk5BHuLzczJkGqUZGHy7hhW8CcuMcthBppFy6ENzx5CHJ+sL+N+0 iXJS6ybtluWE7M7vB+DAhs15WIYDZoNkaJcCm7nLWjOtP4GNGJ5lPWgfbvkLNXsP81iB G+7wP7jZOOPDEz0IX+WKnrC2UST01ETHCJ+F6FITUH76OW+8lcnnYgd0JKGhnYH6RxLl /FjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=MEXHM1XE; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id l21si15513388pgt.131.2020.11.24.11.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:44:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=MEXHM1XE; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CE3236E53C; Tue, 24 Nov 2020 19:44:21 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id C44396E542 for ; Tue, 24 Nov 2020 19:44:12 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id p22so80208wmg.3 for ; Tue, 24 Nov 2020 11:44:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=S/LGt8e6L64JAUL4CT/1IK4l3Dhv3BlKAOxBbtF4q2Y=; b=MEXHM1XESDogQHFfN3R4bynB0veB0Mi8lFjJtgfaZVWY5T8zvvbNN+2TlP9zYS1vHI 6ESdKOievxShN8Cu7g04MDj+zHLSuErcwz3GRGoqe8nc0On0bv8drWOofDWVMObj44zn N86Zx52vI4kQ0f/LB0c6zQ2AhmPavlAJ8TwbKti0GwoW1hTjD8RgAHVaqRnwkkbF52rd +BvbH351Wdbh1h886XoNMPWoWrIKEw13vmaG9CZzvqOmA8LwSl8yJcs5hvKcV+AVmc1m 0KGpQ0lfL6evjhd0DdKTcGJfqI77zymc/Wj6gNniRR699QG7F9yQdEuNfEuFt1HhoQkY GCwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=S/LGt8e6L64JAUL4CT/1IK4l3Dhv3BlKAOxBbtF4q2Y=; b=m93grOb+76l0QB41XhUIEOAyCEOFu5NTIqD+XdLBv0p0QvYGaoUzqhDEFew1+AIRxP Vz+0y1n8n+LvD9Hzgu2CrZfEGr5NlKHG0rSqRjmwEsmuD28uGQjhIEkRihS6IJQpo8WH JBsUgu2oTkwc4ltVHoZEF0+MZ1O218ZPnLtrhFKW75OmD50mflbBIjOhFAHWujSG84en 5kUoQiiFtI1yOPISu4eDs/IzvzxfneavhdcH30ZkeajaN5tWQ2XqniD1uc15VMrawAkE bkrZPvdjk6zWIg1neufzAu/g1r6NCvAQ3y/RQMejCk/dWsZYWcfjF58+FfzaerO9XTaL CZBg== X-Gm-Message-State: AOAM532Qd6TfSZfWs2ydmrC3XrPnQnDVJledm8TEO/Ue5O/kaGVnhmHm xc65TUvsXtPyykejCjSS9BUn9A== X-Received: by 2002:a1c:7e4f:: with SMTP id z76mr49811wmc.149.1606247051472; Tue, 24 Nov 2020 11:44:11 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id d134sm200511wmd.8.2020.11.24.11.44.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:44:10 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 10/40] drm/amd/amdgpu/navi10_ih: Add descriptions for 'ih' and 'entry' Date: Tue, 24 Nov 2020 19:37:54 +0000 Message-Id: <20201124193824.1118741-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201124193824.1118741-1-lee.jones@linaro.org> References: <20201124193824.1118741-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Sierra , David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/navi10_ih.c:453: warning: Function parameter or member 'ih' not described in 'navi10_ih_get_wptr' drivers/gpu/drm/amd/amdgpu/navi10_ih.c:512: warning: Function parameter or member 'ih' not described in 'navi10_ih_decode_iv' drivers/gpu/drm/amd/amdgpu/navi10_ih.c:512: warning: Function parameter or member 'entry' not described in 'navi10_ih_decode_iv' drivers/gpu/drm/amd/amdgpu/navi10_ih.c:552: warning: Function parameter or member 'ih' not described in 'navi10_ih_irq_rearm' drivers/gpu/drm/amd/amdgpu/navi10_ih.c:585: warning: Function parameter or member 'ih' not described in 'navi10_ih_set_rptr' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Alex Sierra Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c b/drivers/gpu/drm/amd/amdgpu/navi10_ih.c index 837769fcb35b7..3338052b080b6 100644 --- a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c +++ b/drivers/gpu/drm/amd/amdgpu/navi10_ih.c @@ -442,6 +442,7 @@ static void navi10_ih_irq_disable(struct amdgpu_device *adev) * navi10_ih_get_wptr - get the IH ring buffer wptr * * @adev: amdgpu_device pointer + * @ih: IH ring buffer to fetch wptr * * Get the IH ring buffer wptr from either the register * or the writeback memory buffer (NAVI10). Also check for @@ -502,6 +503,8 @@ static u32 navi10_ih_get_wptr(struct amdgpu_device *adev, * navi10_ih_decode_iv - decode an interrupt vector * * @adev: amdgpu_device pointer + * @ih: IH ring buffer to decode + * @entry: IV entry to place decoded information into * * Decodes the interrupt vector at the current rptr * position and also advance the position. @@ -545,6 +548,7 @@ static void navi10_ih_decode_iv(struct amdgpu_device *adev, * navi10_ih_irq_rearm - rearm IRQ if lost * * @adev: amdgpu_device pointer + * @ih: IH ring to match * */ static void navi10_ih_irq_rearm(struct amdgpu_device *adev, @@ -578,6 +582,7 @@ static void navi10_ih_irq_rearm(struct amdgpu_device *adev, * * @adev: amdgpu_device pointer * + * @ih: IH ring buffer to set rptr * Set the IH ring buffer rptr. */ static void navi10_ih_set_rptr(struct amdgpu_device *adev,