From patchwork Tue Nov 24 19:38:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 331423 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp795804ilb; Tue, 24 Nov 2020 11:44:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJyiVIpKBqCt0Li7n+hWo/o32JE3hTAubSeO7W/jAOb+3z9dCcAV5iRS23pC29c12/JOc8uT X-Received: by 2002:a17:90a:6b4b:: with SMTP id x11mr187888pjl.3.1606247094994; Tue, 24 Nov 2020 11:44:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606247094; cv=none; d=google.com; s=arc-20160816; b=oDJrLPgeCtJMLr6K2qqHywY8nGWFsBsl8J5WoD789jdUz/KKQTY7OQPluB1cHUbIJa DX9uDUi/7fQiaVTVqEWZJ4TvysTLBlnS3iH7slZOEd39f6USVRB31jqSchRGD4Kf8T/G T0MP/+CKtyCSZ92RF1RcR1XwHblKLWLEx0W4pQUbntrxypQQUD/HKX0a03s1Ud2j88I1 x0LMiXqcm+1ygs3r4YPoun+eweGfXq85pZ903Rl0VQzlzPGLrP5bfM79ohsMhPXX7ZYw 1B0ZeAG5mpxqbGqjk1hxmwjDIg8GEGH4ZNSlvyWS+nYghDqw3fzbToeh9og3ehuLVpgf NOvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=njIIoKNNtTOorSRZL5UY6JxGsiZ039cPR1usiFoTLiM=; b=Cv/C1Z9fvkki1+0zTFwucVkPlkq6EAxwAYneNt+941mzWQdp3QkRcEGM4qUospjVuy R9/4RHeQL3kUKqPI1OYicEfDoRcPXjW6oMbU8eL3WHz9dOGkGUjqlW6nceusfVAnQCu2 pOKB3pFTh5GNEtLcvLxnj79PcXL7QKgeunY7YbYTo9dTri8GUvau7fFo4sMM0mXaQ8Kv qmLODLf5vmxd5s3EifIBIjKTcg7lgVv+lbs/4p6JwumX3Mt7Sm4c3ytSOwQZS8HI/Cao zJUeUOAjTbASpMwy5LeykSQRehEe1U/nRarhIlfud5T8oHGgQ4i1NKgcMsnr6psNuZrr ol4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=C31HmePJ; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id i5si86676pjv.101.2020.11.24.11.44.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:44:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=C31HmePJ; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 07D1D6E52A; Tue, 24 Nov 2020 19:44:47 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6BA696E554 for ; Tue, 24 Nov 2020 19:44:25 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id i2so4502129wrs.4 for ; Tue, 24 Nov 2020 11:44:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vgOzBuuv3Jikb13WPcU5VqKxn6O8S32Q4jFud76gOBY=; b=C31HmePJH9fwXRu4PMXkQBi28Jm+EKtUPkBVoGtuKmPZrUEHdvfFA0SNuyZoJEhWJf ukx/7EzIYQOSqR7rx2lI5u8Toe2HjUOEgdoBxZUyR9JFURHqPSnoZC/xx9Td0wALFPzL tmm9UDtZ4D05b09ML14NjkYX+RID1E5nYnkvDT0BUAsdgRc0pM0BtxQyC03dXygKVNuX 5ZmC9uYoEgbvEZgsbKPDI5RaW4JPrK41NUULVKZkmP8/KHLZORfZMJABVk4AwN0Y6RJU vDUXFWM1NpwnXd9g4ObU5wJEEO5ZsOSF+GOSbSkCCuD3w7fjyPftIR7Sh7dDkvSsBrCA 7DQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vgOzBuuv3Jikb13WPcU5VqKxn6O8S32Q4jFud76gOBY=; b=Ekx/JdBVVT9k1e9/lOCGjsayASf/NIDRp9g1JT2KKcZs7h9jveEhfaQjapUdRCDTpE Zck4EDWbVUp4nNnmBPvwAfq5ooJLN1EkqYMxWFC1c3q+Vl3mtv56lmNEzJsbFc+qc4e0 7OICz7SkstCXydOTI65w8lNJwxUV9PvqAb0TIcKr8LgUJi/JVs2wZk+kTQ45zyhvu9Ji YZI+uziUE3+5HPVzkk00j0rvNnm1MqqZ6LSNsL3fzoqr1+AGZc6joRqrPv0q9JupFvcX L78zOTdHq9vUNO5o3qztayC9WlwIhGgUAXgCg6fzH0uMQe3M7vM/WDAeRbX/ryof6LaU /FIg== X-Gm-Message-State: AOAM533ZIbiOGYE4vlGREW86sm70htsaJVZgW9/m2hYdBZfOTk1Y3W70 oTdOEWcoicsRT2k+ptIUy+DMKQ== X-Received: by 2002:a5d:698c:: with SMTP id g12mr117320wru.36.1606247064149; Tue, 24 Nov 2020 11:44:24 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id d134sm200511wmd.8.2020.11.24.11.44.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:44:23 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 20/40] drm/amd/amdgpu/uvd_v5_0: Fix a bunch of kernel-doc function documentation issues Date: Tue, 24 Nov 2020 19:38:04 +0000 Message-Id: <20201124193824.1118741-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201124193824.1118741-1-lee.jones@linaro.org> References: <20201124193824.1118741-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Nirmoy Das , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c:153: warning: Function parameter or member 'handle' not described in 'uvd_v5_0_hw_init' drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c:153: warning: Excess function parameter 'adev' description in 'uvd_v5_0_hw_init' drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c:210: warning: Function parameter or member 'handle' not described in 'uvd_v5_0_hw_fini' drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c:210: warning: Excess function parameter 'adev' description in 'uvd_v5_0_hw_fini' drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c:463: warning: Function parameter or member 'addr' not described in 'uvd_v5_0_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c:463: warning: Function parameter or member 'seq' not described in 'uvd_v5_0_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c:463: warning: Function parameter or member 'flags' not described in 'uvd_v5_0_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c:463: warning: Excess function parameter 'fence' description in 'uvd_v5_0_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c:529: warning: Function parameter or member 'job' not described in 'uvd_v5_0_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c:529: warning: Function parameter or member 'flags' not described in 'uvd_v5_0_ring_emit_ib' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Nirmoy Das Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c index 6e57001f6d0ac..3a748ec58bec5 100644 --- a/drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c @@ -145,7 +145,7 @@ static int uvd_v5_0_sw_fini(void *handle) /** * uvd_v5_0_hw_init - start and test UVD block * - * @adev: amdgpu_device pointer + * @handle: handle used to pass amdgpu_device pointer * * Initialize the hardware, boot up the VCPU and do some testing */ @@ -202,7 +202,7 @@ static int uvd_v5_0_hw_init(void *handle) /** * uvd_v5_0_hw_fini - stop the hardware block * - * @adev: amdgpu_device pointer + * @handle: handle used to pass amdgpu_device pointer * * Stop the UVD block, mark ring as not ready any more */ @@ -454,7 +454,9 @@ static void uvd_v5_0_stop(struct amdgpu_device *adev) * uvd_v5_0_ring_emit_fence - emit an fence & trap command * * @ring: amdgpu_ring pointer - * @fence: fence to emit + * @addr: address + * @seq: sequence number + * @flags: fence related flags * * Write a fence and a trap command to the ring. */ @@ -518,7 +520,9 @@ static int uvd_v5_0_ring_test_ring(struct amdgpu_ring *ring) * uvd_v5_0_ring_emit_ib - execute indirect buffer * * @ring: amdgpu_ring pointer + * @job: job to retrive vmid from * @ib: indirect buffer to execute + * @flags: unused * * Write ring commands to execute the indirect buffer */