From patchwork Tue Nov 24 19:38:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 331422 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp795794ilb; Tue, 24 Nov 2020 11:44:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJzBTom5gxEqY9Ds/E5xnK/+TDiDm17gsaPudWES6+GKhH45sTQikGwb7fvsFz1pngK2NnBR X-Received: by 2002:a63:344a:: with SMTP id b71mr15839pga.146.1606247094401; Tue, 24 Nov 2020 11:44:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606247094; cv=none; d=google.com; s=arc-20160816; b=NxTcjgK+P/2cZi2iLN3gQIRLwTB8cbbeGHve47CSaeMtP0I1gKm3e0DMbqA8xXeYjx T5NbyXP/ym2NjfmMpMuX5CZGgtEa0Rs/zmqUqV+o37Td4CHoyifoIsGTFQXFPNazBEu/ PcgO1tpq0vzYLWndL0H0BhQsS8zoVUUHs+zaDVPYA1YFz9c3BFi7IHR394oE4NSHCL9U 7fm7RG4GNwmQV3rTxZ60teKLuh8eLCvtsiTzvod1k2MdJ0mncBWh5FFYGqLHAEdB1geN ygdVV8x2EzK9aqw+7ucXEx0bmRlbLlEWDeFIUlYdU6uFQfTlUx9pNBp4H5CmU71/WHuE V7Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=6qmtyPbPcUB6rOHf1dgAiCGmFgGs3hp/rCZ7VLOpaYc=; b=Ow9mOGVn26wOgUcU9AP761WDHU/ZruiLwS2rfLUnA8/6hd+qfoRHt0fV+SNlPIZJjE cEnzDP/hFXPmofeIgN0T42B+Duw92QOQyVhBiETErGgQuD7bfid1kZNC59GmcUT23c+W iZqVyuhMyQQ69plKWVQ8+KCyLp+Ad2aDgE6559tBBJ2I5iH+D5RqWo/Gb8za+AmzZVDH /ILiDjYzNSo7xqwFIE4uR1AcTJkOxrYFDUrA5TpXPWcWaugVBNVCY+jHgxtmWlqqN/SU IDelvhPEafZ3Urc5zHY42epj10EqJA3thLzKHsh1jB4C+QQbfbiImjOSvwWLjisJnFpc 1WLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="gYSO/nVm"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id t20si51831plr.172.2020.11.24.11.44.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:44:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="gYSO/nVm"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1FD216E54C; Tue, 24 Nov 2020 19:44:47 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id D2FD76E54C for ; Tue, 24 Nov 2020 19:44:27 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id m6so23530500wrg.7 for ; Tue, 24 Nov 2020 11:44:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GB6kY4upxQFv24rJ06X4HvdfBkp1xJnyjNfSH8+ifmU=; b=gYSO/nVmFciixTFJ8ZqVydxt3ETrnljhtml21uB6O8PC1QhgpWZ06dgSyH4KjrinuJ iDlUGLl+ysxrcvtrKWR8gHxcgxhwk792cp/ZUjMKxj88lWvnMA9mpfqh7e21oCtZnhsI xziWQg/ze7wmJg8oj2FustOlfqEuy3LxlDUk75pZx2jz7IgRDlQwfa/pUUtvkVOkK5Ei hUnmDpvxI8xt4AD4521/sTVwp3Ar2j9aOGeR/LQRrVO6PCcHejb5SGXlzyY4PuKDsJXQ YY/2k1rlA6BCsIialIdRJf1Ocac398uulw8nhlphGmB5WId/BPHtX0XafqS8z2W92uVY kCEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GB6kY4upxQFv24rJ06X4HvdfBkp1xJnyjNfSH8+ifmU=; b=TShugV1r6BXpyv20NAN4MWhNaETd3dWmeezHxcN4HgHhXcwDuSXBX36buARBfVDH81 kayplgaL1snbeKwb3JhAYTyiTnBV2Qc01+yZJLXI2co8Ez3yh8+lCp5hRZn5AriT5/dd aqunVjKemTeN2UAgyzmdS5QypNB7UU0+4eBAryUQUnbS+fhsggq3dj2he1pJU2zorgQp kVIwZqYMD382HyxZ+F6U3OxG9TblZtFHMljK4/X+PPB4P0myMaRawgJRpwaFtg56MAGw gcq11hb+DeiDoYHHn4nUFA3TTIiEjnBz9S2xaEs1znQNBhXyU46S2u1drQDEOCiHAfea X7+Q== X-Gm-Message-State: AOAM533edD0tnclptzU2UnuscBU3eG0KFWNpoV1cqxevNoSPk6YdkA2L EbquY4FIBlOo474mdmhDW4v+bQ== X-Received: by 2002:adf:f143:: with SMTP id y3mr112155wro.138.1606247066571; Tue, 24 Nov 2020 11:44:26 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id d134sm200511wmd.8.2020.11.24.11.44.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:44:25 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 22/40] drm/amd/amdgpu/amdgpu_uvd: Fix some function documentation headers Date: Tue, 24 Nov 2020 19:38:06 +0000 Message-Id: <20201124193824.1118741-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201124193824.1118741-1-lee.jones@linaro.org> References: <20201124193824.1118741-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Alex Deucher , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:95: warning: cannot understand function prototype: 'struct amdgpu_uvd_cs_ctx ' drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:555: warning: Function parameter or member 'adev' not described in 'amdgpu_uvd_cs_msg_decode' drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:1012: warning: Function parameter or member 'ib_idx' not described in 'amdgpu_uvd_ring_parse_cs' drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:1286: warning: Function parameter or member 'timeout' not described in 'amdgpu_uvd_ring_test_ib' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c index f8bebf18ee362..f8f0384a8d9ad 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c @@ -87,7 +87,7 @@ #define UVD_NO_OP 0x03ff #define UVD_BASE_SI 0x3800 -/** +/* * amdgpu_uvd_cs_ctx - Command submission parser context * * Used for emulating virtual memory support on UVD 4.2. @@ -545,8 +545,8 @@ static int amdgpu_uvd_cs_pass1(struct amdgpu_uvd_cs_ctx *ctx) /** * amdgpu_uvd_cs_msg_decode - handle UVD decode message * + * @adev: amdgpu_device pointer * @msg: pointer to message structure - * @buf_sizes: returned buffer sizes * * Peek into the decode message and calculate the necessary buffer sizes. */ @@ -1005,6 +1005,7 @@ static int amdgpu_uvd_cs_packets(struct amdgpu_uvd_cs_ctx *ctx, * amdgpu_uvd_ring_parse_cs - UVD command submission parser * * @parser: Command submission parser context + * @ib_idx: Which indirect buffer to use * * Parse the command stream, patch in addresses as necessary. */ @@ -1279,6 +1280,7 @@ void amdgpu_uvd_ring_end_use(struct amdgpu_ring *ring) * amdgpu_uvd_ring_test_ib - test ib execution * * @ring: amdgpu_ring pointer + * @timeout: timeout value in jiffies, or MAX_SCHEDULE_TIMEOUT * * Test if we can successfully execute an IB */