From patchwork Tue Nov 24 19:38:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 331439 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp796108ilb; Tue, 24 Nov 2020 11:45:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJxxAyWzlsyY9gxWUETfGpMQ0iscN5c+/17/1M2snX0njKsESs9UCTBLvB0FIJ4mjzbEp1E6 X-Received: by 2002:a17:90a:d489:: with SMTP id s9mr225183pju.54.1606247123443; Tue, 24 Nov 2020 11:45:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606247123; cv=none; d=google.com; s=arc-20160816; b=1Gf1/gMHnzBFvv2sXJSnp3wP9LsbD8ns5CRs2ALbyAlew4UZMK5vhOPcKnIMVAXfXI nIXzPiO6WxzIvtGRrnRF3aAVLkTq9skEVC/qOpZj8VAP0ISOSWaCqu2mrqnYezfvMMDf oYr7m/tOR2dlPybwUuHyOwCQ50OTlTQ3XT8xalanxNphNtk8y40T/7dR3+5BCm3S02L6 4aNU8trKfLk0Ohh+J3qpfzZHe8LPtD42Y76tFAMTqGYdEtuPy1T8JQ5JCtt8h+qJoYZp /ADG9xMjMk7wN3mQ8O0NWb9ptDEKm7t6GbUAbs70D39qgo+yxARDkZjokpCkzq9SUq7R xTjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=/is43AsQ4Ql/jzJ1aK+w9Sel6jMX7weQZ+xo/+Np5LY=; b=UglZISYbXptmS1/qiVKg5deAUphsTE+RXzI+NAtSQtvfYvm0QTYpcLsqEYjhc5grtd iWgZhChrdaViIQaMO6zg2gwLT1tRdCFgmkzr3yU/NJJ9spwqzfZpUXtvyUBrtG2ro4mu OGop2CltJq7oUQ3AyoAjAhjSA1lzJLS4B+Mp0or4/drOX+HMVrFn3YCQ5XKkmh+2an0I 5YGdkI0fRhuBzXwn1B/9MZ+el/+FDx30YG2jKBk+mwL+xZbzz+yl4wHorZ2lb6HlsKMM +Ammw9bMacOtAc5WEjIuxl9pqeTd+k2JJfOBOKaqk9Bmi2f6HGzln5doggGKpG0mRw71 BSTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=BAzGYM8m; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id j11si12935601pfe.193.2020.11.24.11.45.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:45:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=BAzGYM8m; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C0B896E5B9; Tue, 24 Nov 2020 19:44:51 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 180A16E529 for ; Tue, 24 Nov 2020 19:44:44 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id r3so5250088wrt.2 for ; Tue, 24 Nov 2020 11:44:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GsDkEPnukv2Vdk6eKkCyxgdzq1nylzzKySTODP9qfuE=; b=BAzGYM8m8GiMon4ZVqoLqEtdGvasSHBbWulfMGj2/kmgVvLHY2Rhl2KZKgRIERzWE1 BdXkFVPeLYvZIifdk7PlzvY5sIWsjqU3Lm5Dt70+S0azALV57w7AEZP9vK/R9OQ2Av+0 6Z3mXbbY2COkJyj1Ps15qLjrSbwM+mX0ffmHMS6/TP4dztACdQQ6w9Vf3HY2UTkokz8E +3xH5bu9VkDBLkv3j5W+t0GnC1F+Hb6aYldFKAIklSW/ThL9zmDhagmo5sme/1HEG5km E7hqzRbM+uqPILwHWsmZokfHxkKygB+MxUNebCXFX6V9q3d7vFdPNppSGnG+UPjZSwDh Hsbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GsDkEPnukv2Vdk6eKkCyxgdzq1nylzzKySTODP9qfuE=; b=XfKL7eefVhAv3jv0yCmNRgaUchiDcIrsBRfDXzMOFeH8vNst7Y3OqYJtFqSTuaqkdC MusI9Vzh7g1iXPi9ZOrVpvA1sQlOXxdO+JrW1wbdDxZQ1jRIQJABpRoQxmY63zOBAXKl 3yWCZWARPnXekdMzjIsq0mSL17q6ZttvvgyOsCSKOvcAcGRG8CraW/IEyD5BQEjWoTwp fJgmIS49xQamjntEMQankqFQrda98VXma08ZmV4YGahENVaca2wJ8NYorZ6HpYikwonm JL4eua+2MwizEJNmN0yvp8Z2P0aD0QTDJjEA1A6kYs4NAWuPUAONEPaz4TdHhvdKpAwg 1TDw== X-Gm-Message-State: AOAM531xCMPX1A+f/knr0kfsYQNwTZ6xAdbAHA7yuKyJQmR1trFpBsw5 efeLchVtPustbJHtEa6wvnLzvA== X-Received: by 2002:adf:e5c4:: with SMTP id a4mr127799wrn.56.1606247082781; Tue, 24 Nov 2020 11:44:42 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id d134sm200511wmd.8.2020.11.24.11.44.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:44:42 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 35/40] drm/amd/pm/swsmu/smu11/vangogh_ppt: Make local function 'vangogh_set_default_dpm_tables()' static Date: Tue, 24 Nov 2020 19:38:19 +0000 Message-Id: <20201124193824.1118741-36-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201124193824.1118741-1-lee.jones@linaro.org> References: <20201124193824.1118741-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Xiaojian Du , David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c: At top level: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:764:5: warning: no previous prototype for ‘vangogh_set_default_dpm_tables’ [-Wmissing-prototypes] 764 | int vangogh_set_default_dpm_tables(struct smu_context *smu) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Xiaojian Du Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c index 9a2f72f21ed86..05c32be3a7496 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c @@ -400,16 +400,13 @@ static int vangogh_get_current_activity_percent(struct smu_context *smu, enum amd_pp_sensors sensor, uint32_t *value) { - int ret = 0; - if (!value) return -EINVAL; switch (sensor) { case AMDGPU_PP_SENSOR_GPU_LOAD: - ret = vangogh_get_smu_metrics_data(smu, - METRICS_AVERAGE_GFXACTIVITY, - value); + vangogh_get_smu_metrics_data(smu, METRICS_AVERAGE_GFXACTIVITY, + value); break; default: dev_err(smu->adev->dev, "Invalid sensor for retrieving clock activity\n"); @@ -761,7 +758,7 @@ static int vangogh_od_edit_dpm_table(struct smu_context *smu, enum PP_OD_DPM_TAB return ret; } -int vangogh_set_default_dpm_tables(struct smu_context *smu) +static int vangogh_set_default_dpm_tables(struct smu_context *smu) { struct smu_table_context *smu_table = &smu->smu_table;