From patchwork Thu Nov 26 13:42:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 332987 Delivered-To: patch@linaro.org Received: by 2002:a17:906:4755:0:0:0:0 with SMTP id j21csp155825ejs; Thu, 26 Nov 2020 05:43:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJyVpXKNW+ySh6BdRm4GHxY2c918Rxwu1ipeMfLSxtrjyInZOkzGX/BJ8S3WcdVxVDoOzdeu X-Received: by 2002:a62:27c1:0:b029:196:59dc:8e6 with SMTP id n184-20020a6227c10000b029019659dc08e6mr2754965pfn.72.1606398202582; Thu, 26 Nov 2020 05:43:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606398202; cv=none; d=google.com; s=arc-20160816; b=MGvOBXxp+o9PU3dC1pZFpxiRuJCKFKZHK2tjZB59/9NvwW2OtAspKw/VEtk9UEB8/3 fQIbKn9dfv4/aR73je073TARLVUY+/FSHcLB2aF6KZVECeBzIfo8I2ChdStnQQYbh4vt /6NYkbHfzaIdflZvGRtLB+N+X5fgtoGyUxJH+13hzhoOHYeAnL8q/FmQqm+NUZBVhegm DIsR2IxPj8P9MTe+dobZ8gxxemuLfoRmmgQWgyceLKi5NjOZmfycE6fm9v3Kpv7pPdcd 1UKljkdHwCcN36ehS/AIvn6auQUFfIw3rZJ1igr0a9arZOecXx/vZjrlYN8s9XHl6UUV I8bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=0hOO/mAogAw+WYJvxfRocP2AuzScJ11gQWyCoqIUMdg=; b=HNxI9tE0gVnL1iw3gkr/6CQKoYFihq5VkDyFMDNh2SBj3GOoLlCQa/erRrsp0A3y6H F1lsLIf8mp8cQO6cL6Qv7mmypKu1tBMHcD3WzDmvov8/dkMfNFyKa/4wCtnEboT6nPLG HQIoUAC+Tmk4qR66cBghhyYj2d60M0Dwm3BJzIuNqv31XTvlgGvRBlHqvMpx6+wpaLr0 uz2ihya4gwzzaBuYQVQC+b4Dk77Q0dNone9h5KB1zdgTcifslvcmhe+o331gyTBQp7jp N3jluqTUGAsP8Cj9y3l9waxLUyRvmG1Vyo1sk7VeEfLawKFZBiZbz7Qon7mz5yNmEWOz nVvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=BdELhwgg; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id p6si5327536plk.401.2020.11.26.05.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:43:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=BdELhwgg; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F279D6E948; Thu, 26 Nov 2020 13:43:17 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF5466E95D for ; Thu, 26 Nov 2020 13:43:07 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id g14so2161468wrm.13 for ; Thu, 26 Nov 2020 05:43:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b5HKCJC8iv4gibbIS6cltBxMH+DAVlqg/H12nTJ1XPY=; b=BdELhwgg2aXDCVPZiMApozkS+dDFnAj41prA+beMmkmtq5w/7jzoUYaN79lGhPg+b5 Ao1NeiAYusWBvAPnbIbFxw256w0sjzeS37NG3I/ArloBXx9UsQGzPCHaZ7eq5GMUa9Hq xblCmIPAb04gorBKak04DKwX5Ouw95gD99jYEeYF5/t8k6AlIurKssHp9FLsnG/gfuKR 3bHvkYd8LpUPEBgWAJLoljaerBRARKDD7Z6hdxEPL1xUgeKW/drJy7CKcIkZgzlF8b5V 1clDkzXxjZPiHr0yHQ1cy4uKZyP94uOV98wuUeATSfrG5vyfKtu3Xud6idIgT8PSTifK F7fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b5HKCJC8iv4gibbIS6cltBxMH+DAVlqg/H12nTJ1XPY=; b=UaNjhSDbu4ff88mjHuroNoY30BGOaswy54JyfieTPRmFM3vrSSvy0sIf0urp8wat++ 4HgKexyZEUE4h1pG4wAtSzylq2jl1zJDs8LSkQs+Qk3zWfgWKw3m2PCBjkvCzErhFzaA q5e9JecMEtYARRvwfzXMlQN6PdHuLjtSmt3jQYFmuQzOgTYHAkdNuwHUFuYTyRsQSduy cHt66vSmS6eVXyxzWbmpEi3iiPIBuM2HW6gQ38S9WwZvBSe94YTo+w8v75qti9T8eJlF t1abtG7D7Jdmuf+L4OgpdtxtsBRXi6WS/y9UEZyiIX71FLvMzR1EqrSP6S8CQdS3mUAY 9Yqg== X-Gm-Message-State: AOAM530AH71Gk2ePo/V08aLyfIb5m2zt4mtDITqBR5p5FvKRwdm/pRVJ 8xbRf5kPyxAI+RLCwr75yTLGZw== X-Received: by 2002:adf:e54f:: with SMTP id z15mr4046751wrm.159.1606398186510; Thu, 26 Nov 2020 05:43:06 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id k205sm9275738wmk.4.2020.11.26.05.43.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:43:05 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 14/40] drm/amd/pm/powerplay/hwmgr/ppatomfwctrl: Demote kernel-doc formatting abuses Date: Thu, 26 Nov 2020 13:42:14 +0000 Message-Id: <20201126134240.3214176-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126134240.3214176-1-lee.jones@linaro.org> References: <20201126134240.3214176-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Evan Quan , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomfwctrl.c:78: warning: Function parameter or member 'hwmgr' not described in 'pp_atomfwctrl_is_voltage_controlled_by_gpio_v4' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomfwctrl.c:78: warning: Function parameter or member 'voltage_type' not described in 'pp_atomfwctrl_is_voltage_controlled_by_gpio_v4' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomfwctrl.c:78: warning: Function parameter or member 'voltage_mode' not described in 'pp_atomfwctrl_is_voltage_controlled_by_gpio_v4' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomfwctrl.c:211: warning: Function parameter or member 'hwmgr' not described in 'pp_atomfwctrl_get_pp_assign_pin' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomfwctrl.c:211: warning: Function parameter or member 'pin_id' not described in 'pp_atomfwctrl_get_pp_assign_pin' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomfwctrl.c:211: warning: Function parameter or member 'gpio_pin_assignment' not described in 'pp_atomfwctrl_get_pp_assign_pin' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomfwctrl.c:232: warning: Function parameter or member 'hwmgr' not described in 'pp_atomfwctrl_enter_self_refresh' Cc: Evan Quan Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- .../drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.c | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.c index 615cf2c09e54e..a47a47238e2b9 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.c @@ -68,11 +68,11 @@ static struct atom_voltage_objects_info_v4_1 *pp_atomfwctrl_get_voltage_info_tab return (struct atom_voltage_objects_info_v4_1 *)table_address; } -/** -* Returns TRUE if the given voltage type is controlled by GPIO pins. -* voltage_type is one of SET_VOLTAGE_TYPE_ASIC_VDDC, SET_VOLTAGE_TYPE_ASIC_MVDDC, SET_VOLTAGE_TYPE_ASIC_MVDDQ. -* voltage_mode is one of ATOM_SET_VOLTAGE, ATOM_SET_VOLTAGE_PHASE -*/ +/* + * Returns TRUE if the given voltage type is controlled by GPIO pins. + * voltage_type is one of SET_VOLTAGE_TYPE_ASIC_VDDC, SET_VOLTAGE_TYPE_ASIC_MVDDC, SET_VOLTAGE_TYPE_ASIC_MVDDQ. + * voltage_mode is one of ATOM_SET_VOLTAGE, ATOM_SET_VOLTAGE_PHASE + */ bool pp_atomfwctrl_is_voltage_controlled_by_gpio_v4(struct pp_hwmgr *hwmgr, uint8_t voltage_type, uint8_t voltage_mode) { @@ -202,9 +202,9 @@ static bool pp_atomfwctrl_lookup_gpio_pin( return false; } -/** -* Returns TRUE if the given pin id find in lookup table. -*/ +/* + * Returns TRUE if the given pin id find in lookup table. + */ bool pp_atomfwctrl_get_pp_assign_pin(struct pp_hwmgr *hwmgr, const uint32_t pin_id, struct pp_atomfwctrl_gpio_pin_assignment *gpio_pin_assignment) @@ -224,10 +224,10 @@ bool pp_atomfwctrl_get_pp_assign_pin(struct pp_hwmgr *hwmgr, return ret; } -/** -* Enter to SelfRefresh mode. -* @param hwmgr -*/ +/* + * Enter to SelfRefresh mode. + * @param hwmgr + */ int pp_atomfwctrl_enter_self_refresh(struct pp_hwmgr *hwmgr) { /* 0 - no action