From patchwork Thu Nov 26 13:42:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 332995 Delivered-To: patch@linaro.org Received: by 2002:a17:906:4755:0:0:0:0 with SMTP id j21csp156000ejs; Thu, 26 Nov 2020 05:43:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJz6u5w09eTnPcfnfL0dl6nuWBCQEyGmScSatCIBL2dv6nO6tQ60J+GczIiJv0MMBmwEbpNN X-Received: by 2002:a62:5e81:0:b029:197:baa5:1792 with SMTP id s123-20020a625e810000b0290197baa51792mr2802707pfb.80.1606398216892; Thu, 26 Nov 2020 05:43:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606398216; cv=none; d=google.com; s=arc-20160816; b=eOlsw7jFWH20gkSSHDDfv+8IQFICmi6+s6ivh6232eSANZByyXsXSpizkcKQgGN6O+ fyXnE/z8nBe08W6hFICIfxIczuSIxBxPeHt6GFom3BOqOzoCjIi8R7EkcDfYn/2Ctb5L AMWegkdvmO8p8sOSrSJe3StVrdcVuMyF83e9/J015Z9upWv2xZx2Ymsfgxa+CUjIsZu6 tr4Gt3qkNbbOmvZZfwu3cQTae+Gw83YMZvEx8LlAEfhZ2WlXJzm6L1VdbBzk1EdPIm9h 6QiGkHJDQDYYeGCu78ecU31swGuElyqvrSBDYuRLEcVsUUkIDx8a42wQ22XoOj5vrF1H B1Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=PL+yIQUkMeVSFr0k269/ZEn57IzWYh2CZGIa2B/Yg+0=; b=mHR+Zo1ZTQA3POdRL+m/OaQ8yFn3ewj5RyFtDGtyq/ctniLLDKBhf13FIW+fzIJCYS +5HDK0CJgY/cgNb6h88MyzKtSdW15A8jCSYdDd3DknSo/vXL1B1hQqwAFfQ97ZCkund8 2sWexdYhkSTvboKea9xKL7g1x8HtG91wnZim0vY2DLbrNXQ2va92FaXHWM6V4CH0VA85 sEBbLcKMWEHNGfSPOZEZfq3tqWiTlSV+yGNfzkzVax/XeFsa2lEYPclC4NOFkVp31ZUo ygdTSYOgNSwju6kiIMmTlB6SIJz3tSUsCxEn1rTTz0cjcmJryRF6XgEL8ERasjVhSdCT vBxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=GcPofYX9; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id e29si5558810pgn.524.2020.11.26.05.43.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:43:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=GcPofYX9; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 91D996E978; Thu, 26 Nov 2020 13:43:19 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id A305D6E948 for ; Thu, 26 Nov 2020 13:43:13 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id 1so2456474wme.3 for ; Thu, 26 Nov 2020 05:43:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ldaBPFUn0rO8pzl0GTJMRaUTSpPfHm0TP7NYAeN6NJM=; b=GcPofYX9Qv1V/2JRRf6eBMcmKMvq/1Y31zzXUpFv5WiZOV9yJh+i6XHPOojgh//o24 KG7wZ049wcgMys0vZlZPxdX+UUR+E7ss+DRmBqf4q8VM0UmyhYYehvLzU79YMDMvLfh4 beMPEE0h/cHkQRbNEH+m4dUgZ+FiqFn8GubSAKi1eSTWQtQTfJxpSQXt14tg5Sx92KxE oewKv4hUveIzavl5EUkEqL2xkXlqMmFvlo8xkY9ps7OQrqk2IhlcI+6mYMWNRcAYqo2w 1lvd3wlv9+U1TYKUBGDlKd+SVhhuTxlUdeWrZxDiI5sno5LOEGLXlYrmRi1Lo/VZcd48 zD/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ldaBPFUn0rO8pzl0GTJMRaUTSpPfHm0TP7NYAeN6NJM=; b=Nw0um5i02tqQrztSVkAzpqKYBYf7n+WRU2L+NJ6QsXw3WUTLkThDSt+IDAmAmFVq9v lLpPxdChYKbz+Zd5y6WIdvxpYhZr2dW9zTgG8PVYI/Zyo/joMkbwEAld8Mx6BI7YEL85 zzC9onenkvjiXzas3QJvRjseh9c4X7klSNuzzOw4lJP710p0uQmzV+zytafFLEdNUVCb XEoZtm5KarMmz++WqKMkhC7kXNTwzoLEOeSh3UNhufWPvocBCmlH37c77lNpxU49kYy9 V+kjonKuLh+DHA3T5QByoBEVaoGwQDyBXqk0RA1AhInV8psvc6Ty+aTbxE+MKoR2FXwr JMHw== X-Gm-Message-State: AOAM533Cw8Af0AtakQ4nibToENMC6qOOc9mH3MvvOoyt789T1cSVrW7T CJnD5aZqZjfblQVoxtRcgr8bUg== X-Received: by 2002:a1c:1b06:: with SMTP id b6mr3459206wmb.101.1606398190290; Thu, 26 Nov 2020 05:43:10 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id k205sm9275738wmk.4.2020.11.26.05.43.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:43:09 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 17/40] drm/amd/pm/powerplay/hwmgr/hardwaremanager: Fix function header related formatting issues Date: Thu, 26 Nov 2020 13:42:17 +0000 Message-Id: <20201126134240.3214176-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126134240.3214176-1-lee.jones@linaro.org> References: <20201126134240.3214176-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Evan Quan , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/hardwaremanager.c:232: warning: Function parameter or member 'hwmgr' not described in 'phm_start_thermal_controller' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/hardwaremanager.c:383: warning: Function parameter or member 'hwmgr' not described in 'phm_get_clock_info' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/hardwaremanager.c:383: warning: Function parameter or member 'state' not described in 'phm_get_clock_info' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/hardwaremanager.c:383: warning: Function parameter or member 'pclock_info' not described in 'phm_get_clock_info' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/hardwaremanager.c:383: warning: Function parameter or member 'designation' not described in 'phm_get_clock_info' Cc: Evan Quan Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- .../amd/pm/powerplay/hwmgr/hardwaremanager.c | 25 ++++++++++--------- 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hardwaremanager.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hardwaremanager.c index 45dde3e74b578..25b5831a15cd2 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hardwaremanager.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hardwaremanager.c @@ -223,11 +223,11 @@ int phm_register_irq_handlers(struct pp_hwmgr *hwmgr) } /** -* Initializes the thermal controller subsystem. -* -* @param pHwMgr the address of the powerplay hardware manager. -* @exception PP_Result_Failed if any of the paramters is NULL, otherwise the return value from the dispatcher. -*/ + * phm_start_thermal_controller - Initializes the thermal controller subsystem. + * + * @hwmgr: the address of the powerplay hardware manager. + * Exception PP_Result_Failed if any of the paramters is NULL, otherwise the return value from the dispatcher. + */ int phm_start_thermal_controller(struct pp_hwmgr *hwmgr) { int ret = 0; @@ -371,13 +371,14 @@ int phm_get_performance_level(struct pp_hwmgr *hwmgr, const struct pp_hw_power_s /** -* Gets Clock Info. -* -* @param pHwMgr the address of the powerplay hardware manager. -* @param pPowerState the address of the Power State structure. -* @param pClockInfo the address of PP_ClockInfo structure where the result will be returned. -* @exception PP_Result_Failed if any of the paramters is NULL, otherwise the return value from the back-end. -*/ + * phm_get_clock_info + * + * @hwmgr: the address of the powerplay hardware manager. + * @state: the address of the Power State structure. + * @pclock_info: the address of PP_ClockInfo structure where the result will be returned. + * @designation: PHM performance level designation + * Exception PP_Result_Failed if any of the paramters is NULL, otherwise the return value from the back-end. + */ int phm_get_clock_info(struct pp_hwmgr *hwmgr, const struct pp_hw_power_state *state, struct pp_clock_info *pclock_info, PHM_PerformanceLevelDesignation designation) {