From patchwork Fri Dec 4 08:13:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 337735 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp49381ilb; Fri, 4 Dec 2020 00:14:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJy0xpkkhx1oZA4CArvgRq76AMjv50GG6zp4UtRhG1K4f6nj3xRadXnx3ryJ0wzMvhB8Iylh X-Received: by 2002:a63:1d5d:: with SMTP id d29mr6663783pgm.328.1607069641491; Fri, 04 Dec 2020 00:14:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607069641; cv=none; d=google.com; s=arc-20160816; b=izsqYJhRHdJCJ+RsvB6WqAVASnb7vargPx1Zw6jMFvbHlX4tT3vOLFI6DZUmgzfhML 81EyjIFom7LdJzIS+M3iB7j8YQEpi7SAldB52pW7GwFi0iWXwvLwsKtp4JHzqDKkp2tV QN0RPDBkIKvWmIBsx+QIgCDnd5tSMkxUuYVDvLXgG5XLYv/nwg4azLhOZlsDerX+XI1g nrSVDPqL3hU5UKcwpQMAfpionjbIlVNz79483gh6D6gTIIV7A9tpMKmwjHDCMax9cpOf y2N7B66TruvVo6WUZC+hge+eBRqADM4o7En16KZt+9ZWDOX9pcE9dwyywKcSMvjhcRpw kQlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :delivered-to; bh=i1fLHOXot7MZeovjxsh3w8vfXwpWQ6fZRPKUbnhMi+0=; b=HEERxqPRmNH7zCaETPegtYR0ttzlSaonxKkxxwKXLbO8meTcusHfdbzhgVDNxFcEbU LiejD0rGnBVoISTXbzmjb/rhWj31jAg6bx1z4OcKzKTxKYYsxIHyQXSCQEB8ULvJ2OxG 4kBd5trwj1AfNGGJbAmAaDinSJq78WZ7fnFveAc246/fOImtA5bjvvmEbpp9wT6m6Geb A65r/bPYhjhm2A0G1C25D1S7Kb4jSHupKsPxPZeiD9PSVy3Ls8sCxSLJ5kWL44dWn68W YsV8+3N/ZXj5rl8sR9hQt58CrSeWk/GN7DlH7/tbTd5AYxaQtM9pIQvBwrDCg0d1pH26 noqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id h3si1528168pll.186.2020.12.04.00.14.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 00:14:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 698476E138; Fri, 4 Dec 2020 08:13:57 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id A05BE6E135; Fri, 4 Dec 2020 08:13:56 +0000 (UTC) From: Arnd Bergmann Authentication-Results: mail.kernel.org; dkim=permerror (bad message/signature format) To: Harry Wentland , Leo Li , Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= , David Airlie , Daniel Vetter , Nathan Chancellor , Nick Desaulniers , Luben Tuikov Subject: [PATCH] drm/amdgpu: make DRM_AMD_DC x86-only again Date: Fri, 4 Dec 2020 09:13:43 +0100 Message-Id: <20201204081349.1182302-1-arnd@kernel.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Mauro Rossi , Randy Dunlap , Roman Li , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, dri-devel@lists.freedesktop.org, Bhawanpreet Lakha Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Arnd Bergmann As the DRM_AMD_DC_DCN3_0 code was x86-only and fails to build on arm64, merging it into DRM_AMD_DC means that the top-level symbol is now x86-only as well. Compilation fails on arm64 with clang-12 with drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn30/display_mode_vba_30.c:3641:6: error: stack frame size of 2416 bytes in function 'dml30_ModeSupportAndSystemConfigurationFull' [-Werror,-Wframe-larger-than=] void dml30_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_lib) I tried to see if the stack usage can be reduced, but this is code that is described as "This file is gcc-parsable HW gospel, coming straight from HW engineers." and is written in a way that is inherently nonportable and not meant to be understood by humans. There are probably no non-x86 users of this code, so simplify the dependency list accordingly. Fixes: 20f2ffe50472 ("drm/amdgpu: fold CONFIG_DRM_AMD_DC_DCN3* into CONFIG_DRM_AMD_DC_DCN (v3)") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/amd/display/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.27.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/amd/display/Kconfig b/drivers/gpu/drm/amd/display/Kconfig index 797b5d4b43e5..54aa50d4deba 100644 --- a/drivers/gpu/drm/amd/display/Kconfig +++ b/drivers/gpu/drm/amd/display/Kconfig @@ -6,7 +6,7 @@ config DRM_AMD_DC bool "AMD DC - Enable new display engine" default y select SND_HDA_COMPONENT if SND_HDA_CORE - select DRM_AMD_DC_DCN if (X86 || PPC64 || (ARM64 && KERNEL_MODE_NEON)) && !(KCOV_INSTRUMENT_ALL && KCOV_ENABLE_COMPARISONS) + select DRM_AMD_DC_DCN if X86 && !(KCOV_INSTRUMENT_ALL && KCOV_ENABLE_COMPARISONS) help Choose this option if you want to use the new display engine support for AMDGPU. This adds required support for Vega and