From patchwork Wed Jan 13 08:07:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362055 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp297022jap; Wed, 13 Jan 2021 00:08:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJxaQEQbYTfA8NXefsOoDxQZcQPJWKVBGEnTMzVVKHipBHlyIkvof7zg7cDOt/SgX6RWawMo X-Received: by 2002:a17:902:7d88:b029:db:7aa4:864c with SMTP id a8-20020a1709027d88b02900db7aa4864cmr1114594plm.34.1610525319991; Wed, 13 Jan 2021 00:08:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610525319; cv=none; d=google.com; s=arc-20160816; b=K2rEPH9ncdRoL01QYLo7/TZFbirtZQ+SpXrflbShUBR2zxjGy+nrbA5CduArBcB0BM vWJ/p8zYP+JnfECRAipnOh3QCEiYQhtWDh5udCd4YYCFniJEd/KJMjptqc5/sXgSYNI2 wAdImqOuS64uJosXsNILsfqwN7r01eex2lYjwctGeh72ir9GW9dZ4DwMEQs1Gv9p4/Po BqejST8I1pACD1vC2BWyHGLOHMYOxKX79MllAoMXY/Od8wx/VZH/fUMU3kWWXru/fafa JbzZPV4FBhvkyyW3rhXTk8ykVX7j5+NT4pvdOa4OnV856x5P/WIif75KQ/1+aMWyBg7x 72kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=N7lRMbKq6J5OhEMs2obKFuUk8hma1twulqVG5sxnVeQ=; b=t2ie307s+lPwB95oVWUGrPO+Lr2x9S+yy+nZWt4X896aBuebu42LlrDUDmgpbA4QMD yFWX7UJ0zsal7iUvP+Q/c/jvzJpOq2wbinGkGiGGu27QE7Q59nMN2VvjQXQ+TnTaewgv P9vYosxTqaTcnK8Oi5xfgKpDxdVJITcrjQ8EDNDou6a2WCPucmzEwFdYXyG1mCfUIEFg iVEQ1kZQWSH4ThjzRB66WFUNtMNczCZxlgBG69k7Whvt9mHwxmtmUofvl6BrN6ct93KO q6cCyUeh+1m5hxBdsMBdin9aEhDIeE8txWW9SO/FLH98Zu97TNNQTQpe+abxN18tssqM q78w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Bdvrn9Sa; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id 13si1360621pgn.517.2021.01.13.00.08.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 00:08:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Bdvrn9Sa; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C605E6E0A8; Wed, 13 Jan 2021 08:08:30 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E54A6E09A for ; Wed, 13 Jan 2021 08:08:24 +0000 (UTC) Received: by mail-wm1-x32c.google.com with SMTP id r4so708626wmh.5 for ; Wed, 13 Jan 2021 00:08:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FpwY4GtbDJpEMrD8DXq2EUXYJZUv4cPwkIqKzqODNJA=; b=Bdvrn9SakRrtH0IarS95O03IgYmKiSBzTWBhd72Xl2oiD/WRlfu8A5bqe5l3YriNXF XPdsV1cYlQIaO3Wx2GAb3a9TuycM7uNa/YcQa+ftyADQMOesp+QtFSWrQi7A3FnUo+yk 2BbUt3WNtBG4rKew2hsF3bC+CS1z+ySpMsLAEi/g9cjsqVvKUGZmfsA5nzaC2ujZZvD9 hqs3+IdBQTTVH103vC8BgMirOrYD+IM0pQWapb+JF9X03WLYIEmyCphzJjJ5lBt6nn2X iQFmQee0qcQxQg/lLCZGHZjKQBBqb42J3W/TdT3LDF24z69aIWpFX2rBdwTZMAdYLAbn wyig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FpwY4GtbDJpEMrD8DXq2EUXYJZUv4cPwkIqKzqODNJA=; b=a2dljNUPUlvTnNYlhQWBccYTWY+3vlsErszSvqVaH3SZIrB956L+zicPlf+hifJI7m VqfJYHlkXvQC8rBtjq/35OYyqg7G3Zycwn23rbYcb9OrZ01bA6q47NLw9WfTNv2UkZ3i RbxIMAroeRuHSrhCQ5QPYsRnZ0B1552HfkPB5zTzhAw22XWEeJSUX7XVIpYX5/4nJL72 PSRq2xijuZ8U+UB1n0QpzI5CPOA4dHl1UXMshOnbD3Q3j5qmCJ9H7U3VzpyShIooVGMp 2UUhE+FJjc1MvV9fU2t2gxCkj7zXdv9EzDlZ3KeQfwkO4OgKloCtTNS5wCGfGWLxNEU5 YHgg== X-Gm-Message-State: AOAM531WqGf7cKmoss7kzvjwu2BsShrt+6DI3oWjCib+vQ4O7yMHWGQr YvSumylP5L1l67T2k4XS/YjXXw== X-Received: by 2002:a1c:234d:: with SMTP id j74mr954180wmj.18.1610525303222; Wed, 13 Jan 2021 00:08:23 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id r20sm1642486wmh.15.2021.01.13.00.08.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 00:08:22 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 22/30] drm/amd/display/dc/core/dc_link: Fix a couple of function documentation issues Date: Wed, 13 Jan 2021 08:07:44 +0000 Message-Id: <20210113080752.1003793-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113080752.1003793-1-lee.jones@linaro.org> References: <20210113080752.1003793-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:214: warning: Function parameter or member 'link' not described in 'dc_link_detect_sink' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:350: warning: Function parameter or member 'link' not described in 'dc_link_is_dp_sink_present' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:841: warning: Function parameter or member 'link' not described in 'dc_link_detect_helper' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:841: warning: Function parameter or member 'reason' not described in 'dc_link_detect_helper' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:3403: warning: Cannot understand ***************************************************************************** Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c index 3366a49f11dc7..271c4f66edb56 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c @@ -206,6 +206,7 @@ static bool program_hpd_filter(const struct dc_link *link) /** * dc_link_detect_sink() - Determine if there is a sink connected * + * @link: pointer to the dc link * @type: Returned connection type * Does not detect downstream devices, such as MST sinks * or display connected through active dongles @@ -342,7 +343,7 @@ static enum signal_type get_basic_signal_type(struct graphics_object_id encoder, return SIGNAL_TYPE_NONE; } -/** +/* * dc_link_is_dp_sink_present() - Check if there is a native DP * or passive DP-HDMI dongle connected */ @@ -828,7 +829,7 @@ static bool wait_for_entering_dp_alt_mode(struct dc_link *link) return false; } -/** +/* * dc_link_detect() - Detect if a sink is attached to a given link * * link->local_sink is created or destroyed as needed. @@ -3400,10 +3401,7 @@ void core_link_set_avmute(struct pipe_ctx *pipe_ctx, bool enable) } /** - ***************************************************************************** - * Function: dc_link_enable_hpd_filter - * - * @brief + * dc_link_enable_hpd_filter: * If enable is true, programs HPD filter on associated HPD line using * delay_on_disconnect/delay_on_connect values dependent on * link->connector_signal @@ -3411,9 +3409,8 @@ void core_link_set_avmute(struct pipe_ctx *pipe_ctx, bool enable) * If enable is false, programs HPD filter on associated HPD line with no * delays on connect or disconnect * - * @param [in] link: pointer to the dc link - * @param [in] enable: boolean specifying whether to enable hbd - ***************************************************************************** + * @link: pointer to the dc link + * @enable: boolean specifying whether to enable hbd */ void dc_link_enable_hpd_filter(struct dc_link *link, bool enable) {