From patchwork Wed Jan 13 14:50:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362132 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp598429jap; Wed, 13 Jan 2021 06:51:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJzjox62r5D8EO9a9xLPh33UJfSIb8fgqZeQla/d51hGKE0JnUNB3kYPGnn6XA6QscUXx1kw X-Received: by 2002:a17:90a:bb8c:: with SMTP id v12mr2834976pjr.227.1610549466390; Wed, 13 Jan 2021 06:51:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549466; cv=none; d=google.com; s=arc-20160816; b=HPE9Abua6VlZte6k2NhT454OtPIHY59/YedXkjqe6j79kBdFm3khfUyc0H79UoP3MY giD4T4WmMPA8x/NAegC+n4Ecz4VEWA0QfrSgfaUuVtoEXRuNLuPpzk9tdEFUdAJ3Y+V0 uF5uTOSDDyhfd482QN1/ydqewpKY6CGq013eO5bLrJdjXR/HZ3jivh3Zgs2I28VV4oV8 TGfn4Gk2gbOPvFvQneFcOZPyOVIIuSm4l5Mf80/XOt2b67XoCVcJwjUGYuXqoCCtGo0u xUOAdt3aNy0T5eeh0j9gA5QXMVWFGzeDHvaiyTFRwwPRcrsRIm+D2DV+Let2Izc0X/Nd KAOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=qjhstJDxZzRg1PCTSUN4/Q9/Fdu+r2H3vA1tLc/QbcY=; b=qIEQ2f9lk5LFopuvqsK7EcmNxL41tNqgo2cR07gLKIs3pP2aIwxus3GAOwcR1PqiJ8 1GWRmiRGRhgK6rNBu/auJ17vxpEVBQ3/OOoJk0lKnUsXVXUrquAZgKWh1FS75iN5Y2xX 3QBV3hvvGxEl0CU4hJv47wZhcxt9kK7W43PnTkwUlb1reMpc9OWFcMmgfT4+WvLzZ4O4 2NYTIIKnPLAAh1rhZ88ggXkV4FOsLHiwuxr38KvrWfhlSeCF00nbVj+SNjBZjyXww6nl mxK5gdApwfffAcczAKMc+oT/cI1B+lKnnEpsWFzlhB2zL157k2ZM86vj4BMjWPMIDD4e 35tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=DVx9RGOh; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id 12si2529103pll.58.2021.01.13.06.51.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:51:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=DVx9RGOh; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C15F6EA65; Wed, 13 Jan 2021 14:50:58 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 539A46EA62 for ; Wed, 13 Jan 2021 14:50:47 +0000 (UTC) Received: by mail-wr1-x42d.google.com with SMTP id t16so2417462wra.3 for ; Wed, 13 Jan 2021 06:50:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GoUfRt23bqbKPl1TGglCjWozG44qym29OpcwnZGK6kU=; b=DVx9RGOhwl5u8ldZy5VrfBB5nqUBSa6oCbOAtc/naAE4if9nM+qG1VzCKee+LVG+3B pYMHjLmmVhejEEkmBIU3VqOIbS0QbervpRSbvt8RbrJ65WI6sdAQJIFHQBuqYquGY9sm C0BoNNBF1vlcU19yuj0aroZuKk5XVtUWIzVX0dv3Fl5+wU5eXqndsETD1SuasAlFPapO Ndex26m6UwPr44hJ1bIN/A68qcXyyjbFTxYEWrG/wLv+f8ePNT5PGN0tbNcfIJ6tyYVQ 66n2l1NmCju3l+XV3FxP/N8a/cWJvm9uSD3UZcReTj1OIqHd9zRtoKkjQOixv9hbaPDF TjNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GoUfRt23bqbKPl1TGglCjWozG44qym29OpcwnZGK6kU=; b=TKyK2xm2iEPjCQohGLGiVxC6nnOxP0hIn8sa18WhOQ4dFvjwjb5FGHsbJ7vsjGqaZ0 RD/QQriswi4pLPBWgty0RYrsc6hsDwFjWvEBq3Et8dybJ/9NR0IqWLHJ8W+cj5lEectR IdqltW2bN3oMwuRce0ag4wfmv8q2iBNtSP/0XMEdBeFXQzAh6FgqoJCthuYQzMYiJjls Rfe59O5w2KeLJPRgWKGwzNSkn4nDwFEgLwZAAyCDrLSfFoWzLN9/yXxXJf4HJ+cvpNK5 yMYrlK4rZeLzLfEZK/HaO1fmgDJJMwfSkNphKvtca0FHB5LJeNOzjoZccYlEHec952+z 7SoQ== X-Gm-Message-State: AOAM533mZ5TgZ249eRY1+tyITlbNiuW0EFRaU21YXt0ZkEHynHeqkZIN h1WeGX7meDY7HHchTDb9hvMDVQ== X-Received: by 2002:a5d:6852:: with SMTP id o18mr2897319wrw.371.1610549445789; Wed, 13 Jan 2021 06:50:45 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:45 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 22/31] video: fbdev: cirrusfb: Remove unused variable 'dummy' from 'WHDR()' Date: Wed, 13 Jan 2021 14:50:00 +0000 Message-Id: <20210113145009.1272040-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Jeff Garzik , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/cirrusfb.c: In function ‘WHDR’: drivers/video/fbdev/cirrusfb.c:2466:16: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable] Cc: Jeff Garzik Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/cirrusfb.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/video/fbdev/cirrusfb.c b/drivers/video/fbdev/cirrusfb.c index e9027172c0f55..f05160fa34da9 100644 --- a/drivers/video/fbdev/cirrusfb.c +++ b/drivers/video/fbdev/cirrusfb.c @@ -2463,8 +2463,6 @@ static void AttrOn(const struct cirrusfb_info *cinfo) */ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val) { - unsigned char dummy; - if (is_laguna(cinfo)) return; if (cinfo->btype == BT_PICASSO) { @@ -2473,18 +2471,18 @@ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val) WGen(cinfo, VGA_PEL_MSK, 0x00); udelay(200); /* next read dummy from pixel address (3c8) */ - dummy = RGen(cinfo, VGA_PEL_IW); + RGen(cinfo, VGA_PEL_IW); udelay(200); } /* now do the usual stuff to access the HDR */ - dummy = RGen(cinfo, VGA_PEL_MSK); + RGen(cinfo, VGA_PEL_MSK); udelay(200); - dummy = RGen(cinfo, VGA_PEL_MSK); + RGen(cinfo, VGA_PEL_MSK); udelay(200); - dummy = RGen(cinfo, VGA_PEL_MSK); + RGen(cinfo, VGA_PEL_MSK); udelay(200); - dummy = RGen(cinfo, VGA_PEL_MSK); + RGen(cinfo, VGA_PEL_MSK); udelay(200); WGen(cinfo, VGA_PEL_MSK, val); @@ -2492,7 +2490,7 @@ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val) if (cinfo->btype == BT_PICASSO) { /* now first reset HDR access counter */ - dummy = RGen(cinfo, VGA_PEL_IW); + RGen(cinfo, VGA_PEL_IW); udelay(200); /* and at the end, restore the mask value */