From patchwork Fri Jan 15 18:13:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 363690 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp89409jap; Fri, 15 Jan 2021 10:14:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJxpGUtPyvD1eT5HpFAnp8nGyVTPZGrVrRt6X4CCPUkidCnb2qRnYzZOTrJ3DxjctTMRkWQw X-Received: by 2002:a05:6a00:7c5:b029:19e:2965:7a6 with SMTP id n5-20020a056a0007c5b029019e296507a6mr13780150pfu.60.1610734465991; Fri, 15 Jan 2021 10:14:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610734465; cv=none; d=google.com; s=arc-20160816; b=gl0RNNfunCK/GXhodDrAzqDllnA1Suk/WQSjW7ZRcfpdt1vmTmyuVI3kI/wpRYridf xswmfwJtvBvWML46KAFQM6MRQypHsbQQ/WrBJqe6p3V355wGdqswOxE65PV4I8J+3/4X fGwAad9a9yC/8BGNTm1nAi/9Z5F9SZ9gV2sLgCpCOSzEpLtfpA1Gk6eH30mJi9bHaeg3 d9cOY4MPPJe7HhAkxLCg+GEVy3qHkvflKe6qXgZboaxtWM+cEZUdkgJPrZ9qnCW2ETFz 0uQ8d/h7dbOPiGToMgJ5VnbRQyLpQxQy9H1z9Ji+v/7I+eH6xfshppMGfmL3DyCro4Ib UwPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=QthdKh778v8+b+TZK6pitcVyY7yJlL++E/wEQ6jld7s=; b=q6yG4HvtFWxAJXTG47M8VRkZ8zl1ztKPsMTu+C2tYiGtZ3ZPHy6O2xrC4QbZuzm9i1 BQT++FbFQkgC7O7wqITYergCoXXIzQsvga6LDi2bD83BhmD0zrc6M2Ps3ZYRxy//wY5v cZyVkhyuvmoUrng63y1S6h9U4IfR5Kz/BXQGQA0A2+kqPQJw62rQsM0kfuxzgeBKX6+A CKBr5keojxEh5D4XFP1Aaqxpi7yjjXjqgzxy/E6kMqlZRPEY256mX1vNKtt5gqwFch0V 01nSOS2To5Xwh4wz38uzmHSo2pEWV2gv5e4RTHSBsvFifCJWoGp4hh/4YntoEyHmSkWp saZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="dseFE4l/"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id y4si10462999plp.301.2021.01.15.10.14.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:14:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="dseFE4l/"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2759A6E49C; Fri, 15 Jan 2021 18:14:14 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2ACCA6E4A6 for ; Fri, 15 Jan 2021 18:14:11 +0000 (UTC) Received: by mail-wr1-x42e.google.com with SMTP id 91so10213786wrj.7 for ; Fri, 15 Jan 2021 10:14:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Zk69YegOGJqysgGJbDn5xfrwzKa0lDxp7+yp3s1Kj6U=; b=dseFE4l/a7Wm6ykCQlC4gaq/QvUbmlCUt5gKH0q+IywCOX3NvEoX4BwK6m03B9VDXs 1SuhGTsHQqMW0lwqBNgvjdN6LqP7wXL1vty08oacmKr1HNMacqDFja6hyg1EryPPh1Wz qxo4jjbHw3Knhoig20reJn2pzkM4e+gTMiKwBwz+tD53xJEA7BIKhGYysAKbmkH7jH+O WDtWvkXFDI9vzX74EWQET78aNV2d7JIUsoqMic7S/ma0eYZ/UQJ/vieSlU8W+dk4aI2q LPwi5vp8uhWFUS0YL6n0QoHiQBFn1GzjkjfIzCTrXXa8w2WQCfN3EI3TW/ycUM2X8gYj NPEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Zk69YegOGJqysgGJbDn5xfrwzKa0lDxp7+yp3s1Kj6U=; b=RP7nBxNmZk4Q6/3zoCF6+G6Qc4/nRXw9QiltXKUt6r5gpaicCUgFo4rCpEwntXFpkI 7HRw/WRH2Big1ZjCYDXE5FWwr48BDJtE++1Y5qlugWaqC+L31PlwPmCrhfUParCsl/1N xTuuSlmHdCyq30IehE/Rte+0BU+AKOWNwb4qmcULb9Pr0xZgOPKnEeQ4c1WzYY4/D8u3 EeoTJVBdvrx61trqUrVZKLhUXF3mLEZkvnr2edMu6wGfWTKC2fuzvc4tYDiS5UnJbvjZ /+3UadjXE6bNAmgyR4J2z0O+JPUE/+JltTTzvrHGVrutu9eURCHIsZsF0xDALXcrcQeI IHpQ== X-Gm-Message-State: AOAM533qkr7IKLs0SlCsFUjnJiS8zBcWJPCzD/7kGn4VNMBq6LXxmwd2 oONLF/KYOOkssII6i7Yi60zFQ8kNjpikURMH X-Received: by 2002:a5d:4c45:: with SMTP id n5mr14779840wrt.396.1610734449759; Fri, 15 Jan 2021 10:14:09 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.14.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:14:09 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 36/40] drm/vmwgfx/vmwgfx_shader: Demote kernel-doc abuses and fix-up worthy headers Date: Fri, 15 Jan 2021 18:13:09 +0000 Message-Id: <20210115181313.3431493-37-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Roland Scheidegger , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, VMware Graphics Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_shader.c:134: warning: Function parameter or member 'res' not described in 'vmw_res_to_shader' drivers/gpu/drm/vmwgfx/vmwgfx_shader.c:663: warning: Function parameter or member 'base' not described in 'vmw_user_shader_base_to_res' drivers/gpu/drm/vmwgfx/vmwgfx_shader.c:695: warning: Function parameter or member 'p_base' not described in 'vmw_user_shader_base_release' drivers/gpu/drm/vmwgfx/vmwgfx_shader.c:965: warning: Function parameter or member 'dev_priv' not described in 'vmw_compat_shader_add' drivers/gpu/drm/vmwgfx/vmwgfx_shader.c:965: warning: Function parameter or member 'size' not described in 'vmw_compat_shader_add' drivers/gpu/drm/vmwgfx/vmwgfx_shader.c:965: warning: Excess function parameter 'tfile' description in 'vmw_compat_shader_add' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_shader.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c b/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c index 905ae50aaa2ae..a0db065640131 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c @@ -125,7 +125,7 @@ static const struct vmw_res_func vmw_dx_shader_func = { .commit_notify = vmw_dx_shader_commit_notify, }; -/** +/* * Shader management: */ @@ -654,7 +654,7 @@ int vmw_dx_shader_add(struct vmw_cmdbuf_res_manager *man, -/** +/* * User-space shader management: */ @@ -686,7 +686,7 @@ static void vmw_shader_free(struct vmw_resource *res) vmw_shader_size); } -/** +/* * This function is called when user space has no more references on the * base object. It releases the base-object's reference on the resource object. */ @@ -945,13 +945,13 @@ int vmw_shader_remove(struct vmw_cmdbuf_res_manager *man, * vmw_compat_shader_add - Create a compat shader and stage it for addition * as a command buffer managed resource. * + * @dev_priv: Pointer to device private structure. * @man: Pointer to the compat shader manager identifying the shader namespace. * @user_key: The key that is used to identify the shader. The key is * unique to the shader type. * @bytecode: Pointer to the bytecode of the shader. * @shader_type: Shader type. - * @tfile: Pointer to a struct ttm_object_file that the guest-backed shader is - * to be created with. + * @size: Command size. * @list: Caller's list of staged command buffer resource actions. * */