From patchwork Fri Jan 15 18:15:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 363709 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp91130jap; Fri, 15 Jan 2021 10:16:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJwmKxFm53KpXZhJpFk0f74lkcyDJDvfnJsvqjjVMLpFfdjHl9DUwqmqwutBvv5nVm/OF/Zl X-Received: by 2002:a17:902:e901:b029:db:c0d6:62cc with SMTP id k1-20020a170902e901b02900dbc0d662ccmr13907943pld.7.1610734586109; Fri, 15 Jan 2021 10:16:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610734586; cv=none; d=google.com; s=arc-20160816; b=yqhlAWho4dDFrwOGMkxwURNUK50jxQ/CwFbIcknjU6Y7FgwmuwHKtU3ZT6JzyOhCxW 0fcgADRAbLsyKAp3OLCEr5zlL7etiTLi+q4erFzvedqr6s34pCooYz97ZDz/1KH3ZYqy j+S0hSZO1KHm9adaP+A47LkB/4n9tYCRtCNahtFW0oQOFz2tEq9PYQwOtmXlw6T/HH9L 2yLVeA7j8jRbebbmtNHhF2rhKy1hkuUzkYBGVKy3wSulHoXjO5asqgJyz/QwT7eZS0w4 t7/8rZXiLzyRPwoCBGBAKotEtFZjJcK0m0Odx8LxRTs8TWuyxHPCmCUnl6A9kt1EiDYw 0C2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=CkNK5ppW03Wu2aLO4j1ezLN4dvPmjLn8Vg1MMcS8QhM=; b=ZS087vI/VVDlO5fxGBronnAk9UxU9a4GWL/WvDCT0GtK/PqhDGihFzvNAl8sipXMSQ wjUtNYe2wxlY2QXuEJq/wNs6xjtqtHq6Ird4ebmaZBzl0WsmAjRE2Wuv7dlaniMhnhma fsctSQk1j+qUD4ufr4sUm7EBs8Mmf6qMMl59p8AvdO6EUf/7XHVI+t79eTSZtwle5lig dUH8AOsO3vxVQiK+hpL2fezdF8weVbJ1E0xWmuXHcGAE0hiCyEdbpM/jbRTafvuH7Ikx pYD+kqptNq/wmsK3bNZKTDpIQLVjD0xRySA2ukOpJI6d9t5vs/razimqwYfbIhQDbZFg /n+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Jeva4W7b; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id g7si2365942pjs.3.2021.01.15.10.16.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Jeva4W7b; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D6BDC6E4C9; Fri, 15 Jan 2021 18:16:22 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by gabe.freedesktop.org (Postfix) with ESMTPS id 11E446E4C5 for ; Fri, 15 Jan 2021 18:16:21 +0000 (UTC) Received: by mail-wr1-x432.google.com with SMTP id d13so10175678wrc.13 for ; Fri, 15 Jan 2021 10:16:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=klcbd1e9WNIfeT7Kw/V+fGmeHX8/YIMOVJeu6cqS6p8=; b=Jeva4W7b5GmkLma0e0Xq2LyelIdviMQ5Xtdc74BWOdiUZov1iTUGSs4RdBxLNmQI6C xZ9R5zA0dodI3/TxwKcWEepE4zEOvD40upf9vjbHymNQhp+QdNYGPJzgJIKkQbocLbc8 cE32+iJI5yVLlTDqLJI9VzVuWhPNvOuhdmUMumzV9EXyb2S83X1nTD0CtHsod8AmpZYQ L6y8sevlrSKQa0OomUujlM4Vl0UDvZ7LIStc5x9v9qb62+xiBlnUDNgiirVMuLMGkv1d OTqR4QgreqpMCp2pOorq5hOFyE5Pklwlns+yu4dxl3V7HNxbLo/QgIRVxAW56aXa1zOs G0qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=klcbd1e9WNIfeT7Kw/V+fGmeHX8/YIMOVJeu6cqS6p8=; b=EWBSVIdtDNh5bT8OYEI10jq1PHBZ4h4FWlDMHi2rZlWhYj9w2xR4DETLJ/4QzwWp/0 cG5o+53dcsZhHCh0XQRDvuyR/WidAcxglxKmFQs4C3cuM8OUi1a3Z0zcTltUAReB8Vil aNO1+Bprrcqry6KEaVfm6jtosghuG3r8g+LQc7YW02YHsQ1kwVn7rHF1be1NXQWp2vP2 cOHWetqdvdVa63U2gcD3T3um2Pxrbqd4BAlu8WMwWdPZKUhMOtQHI8mlwdkMY+kz3wjB YJjr8e0V0C72UMh4BSV3E458vnQVUo4JS6FZpfpQH1jNl1k80sXiiIi0jUPocV3y/LRB K/zw== X-Gm-Message-State: AOAM533VRpryakTtJkaYXJWtFjgh3IYhBCzKeZ17IkRZIkBOjopJV5KY DRaCFlMXNaBSi0Rc5suLZWkeiA== X-Received: by 2002:a05:6000:2cf:: with SMTP id o15mr14224637wry.184.1610734579303; Fri, 15 Jan 2021 10:16:19 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:18 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 09/29] drm/vmwgfx/ttm_object: Demote half-assed headers and fix-up another Date: Fri, 15 Jan 2021 18:15:41 +0000 Message-Id: <20210115181601.3432599-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Roland Scheidegger , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, VMware Graphics , Dave Airlie , Rob Clark , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/ttm_object.c:60: error: Cannot parse struct or union! drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'mem_glob' not described in 'ttm_object_device' drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'ops' not described in 'ttm_object_device' drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'dmabuf_release' not described in 'ttm_object_device' drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'dma_buf_size' not described in 'ttm_object_device' drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'idr' not described in 'ttm_object_device' drivers/gpu/drm/vmwgfx/ttm_object.c:128: warning: Function parameter or member 'rcu_head' not described in 'ttm_ref_object' drivers/gpu/drm/vmwgfx/ttm_object.c:128: warning: Function parameter or member 'tfile' not described in 'ttm_ref_object' drivers/gpu/drm/vmwgfx/ttm_object.c:582: warning: Function parameter or member 'dmabuf' not described in 'get_dma_buf_unless_doomed' drivers/gpu/drm/vmwgfx/ttm_object.c:582: warning: Excess function parameter 'dma_buf' description in 'get_dma_buf_unless_doomed' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: Dave Airlie Cc: Rob Clark Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/ttm_object.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/ttm_object.c b/drivers/gpu/drm/vmwgfx/ttm_object.c index 0fe869d0fad12..b3fdc630497cb 100644 --- a/drivers/gpu/drm/vmwgfx/ttm_object.c +++ b/drivers/gpu/drm/vmwgfx/ttm_object.c @@ -73,7 +73,7 @@ struct ttm_object_file { struct kref refcount; }; -/** +/* * struct ttm_object_device * * @object_lock: lock that protects the object_hash hash table. @@ -96,7 +96,7 @@ struct ttm_object_device { struct idr idr; }; -/** +/* * struct ttm_ref_object * * @hash: Hash entry for the per-file object reference hash. @@ -568,7 +568,7 @@ void ttm_object_device_release(struct ttm_object_device **p_tdev) /** * get_dma_buf_unless_doomed - get a dma_buf reference if possible. * - * @dma_buf: Non-refcounted pointer to a struct dma-buf. + * @dmabuf: Non-refcounted pointer to a struct dma-buf. * * Obtain a file reference from a lookup structure that doesn't refcount * the file, but synchronizes with its release method to make sure it has