From patchwork Tue Feb 9 12:37:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 379343 Delivered-To: patch@linaro.org Received: by 2002:a02:b18a:0:0:0:0:0 with SMTP id t10csp179450jah; Tue, 9 Feb 2021 04:37:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJz5gEgUTvOOVbLD25KBUfIr3x5kefOF/10XzxFcb7yb827mp+2q5Hy9ljD9A/Bm7e7HYE+w X-Received: by 2002:a17:903:4083:b029:e2:9654:de1c with SMTP id z3-20020a1709034083b02900e29654de1cmr21535762plc.43.1612874271634; Tue, 09 Feb 2021 04:37:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612874271; cv=none; d=google.com; s=arc-20160816; b=FxwQA3qcHEXA1M0gRH6deWYnfKEn4cCeH3aM0Eom34UHs8ktlaHAw1D1l9D9EFbQQZ v6EisXAbHpnGsuVsvNZDTPdJ5Y3gERO1xUvn47LCHJ/DVsZqtNLGIBUqAAcNASfr5Blb o/WM2qHoetDqXvZZSuim7BssTWVCkXBMerf9SOnwVhlqKd3vAHM2n/KC8xuAw5uapJ++ pT3UqkVUKfB3aFvR+ilDmV+XDBewZyIGABRNgQaeV9BdpxLVnZxpJdWq6PxQlG1hke6Z Ad1v/cEYr0lf2FZ/QbjPuq+CsLwOoS/AL8J7hcHWEBBBQfK17dZCP01/Vqj5+nA1i9Fv SbQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=6NGDXevYRfKHYvmsrZIwX7aDvxzI/xtUbOvXKwJmd1s=; b=m31B/y3Ajhx2wdTyCRsrhwvMbAuP730A4SaTUp/7rqS6SrFfduGWrYYwZxC4w7i1LL sPLCxVZg2T8H9WHstDZwesxLYw1C+PZ4QrDyXA1FLiE/yFmXxZ8AiMTRNfiaJwFFvP9v 9xXHB9cBRY866kejGAFzTpFTjO9GG35MoChlL3kyeSqvGA9A+CNaiBxPrNK9OG/CvOKM iXwHYqRgQfntvUM1p5MPccYv0xkMjMhSqkTs0MvDj8hVr0z4xFj636lelGmaFg1GNAWF /4BOZjozRO+8cr+S5IZKW7Myo8JJUhMCOKWd5R3N6Tqin7Aa+p1vImbP2JfgUFYQmb0v R8GQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=UA7qw6pC; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id nl12si2557887pjb.44.2021.02.09.04.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 04:37:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=UA7qw6pC; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E04E6E051; Tue, 9 Feb 2021 12:37:50 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A7C36E051 for ; Tue, 9 Feb 2021 12:37:49 +0000 (UTC) Received: by mail-pf1-x431.google.com with SMTP id q20so11813270pfu.8 for ; Tue, 09 Feb 2021 04:37:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HEWcLvUvYkWYLO51rzp4RR+x1aKBWP/abPyEZI4rYFM=; b=UA7qw6pCaOdf/yqq69etxef0untkhUFXSI+O9aCuyR/lOYzzPCRtWaHB6KbMDFaObh maH0YiX2IcjeEONLLi2m+Sk+3PTzs33BzrB2mJ0HcLcjRk2r9l8yFR3/KfrkL6EkdZzb i8Cave62QyllrlcUMYo1mEwijF+bfDhpgxDWkcnziTD6OcT6DxjwzJyWMEFdZWboC3uY cbIO+ZB5NSD6J70UHw1gRakG/afPMQiZ5Hd6tPMcqAv+xikSyDJDq/u4w5z8EMpDP8T2 Lg8Z3VO2gx3ssY95EEyC5FYR7D6991/PEqnpomJXo/ZUGeBHxea1UuMcYEtJj3Cc0wko 9Lgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=HEWcLvUvYkWYLO51rzp4RR+x1aKBWP/abPyEZI4rYFM=; b=rncD5jG05DWQGnIC0Uq0g1WaB54BlyAdSHXol11jbuggFjR/bPVZb9t5ZkGPYnl2qN Uu21HvtLOJd3+kNlGLaK6VsIhs6UmJm+GvFc71KhXyXnnAiSjgeeK5ipNSNWAp7ctG7c PKlF43HU0gUMrcTRiNyE5f/Xbyc10/zNpw4o0a5PggHFdDAyeOawPJojdmVi0M5ZlvJG R7HX76iEqYPaYYcC/kxg7sDX/iJFFXturXh4R+fj7NBgxJajelb5Sb+fzOW+8Ve76e0j OUqo1XQVV+2lRkoQW+FXGjOZwx+FqLvPIQMZAWCdEz6lJ8yibxiPv+LBWtXYu33WO5+W wjbA== X-Gm-Message-State: AOAM53078jfk0cftALHtqUQYmgv8otro9tQ89peh87XKp+t9grOQ76wz HVEekvTx5pr0thPbFGrtD0THHJbaKOqzvA== X-Received: by 2002:a63:c70c:: with SMTP id n12mr22157570pgg.347.1612874269194; Tue, 09 Feb 2021 04:37:49 -0800 (PST) Received: from voyager.lan ([45.124.203.14]) by smtp.gmail.com with ESMTPSA id i7sm22584395pfc.50.2021.02.09.04.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 04:37:48 -0800 (PST) From: Joel Stanley To: David Airlie , Daniel Vetter , Andrew Jeffery , Jeremy Kerr Subject: [PATCH v3 1/2] drm/aspeed: Look up syscon by phandle Date: Tue, 9 Feb 2021 23:07:33 +1030 Message-Id: <20210209123734.130483-2-joel@jms.id.au> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210209123734.130483-1-joel@jms.id.au> References: <20210209123734.130483-1-joel@jms.id.au> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This scales better to multiple families of SoC. The lookup by compatible can be removed in a future change. The fallback path is for the ast2500 platform only. Other platforms will be added with the new style, so they won't need fallback paths. Signed-off-by: Joel Stanley --- v2: Fix fallback path to still find ast2500-scu. Thanks jk for the review --- drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- 2.30.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel Reviewed-by: Andrew Jeffery diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c index 457ec04950f7..54a6bda03c0e 100644 --- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c @@ -103,6 +103,7 @@ static int aspeed_gfx_load(struct drm_device *drm) { struct platform_device *pdev = to_platform_device(drm->dev); struct aspeed_gfx *priv = to_aspeed_gfx(drm); + struct device_node *np = pdev->dev.of_node; struct resource *res; int ret; @@ -111,10 +112,13 @@ static int aspeed_gfx_load(struct drm_device *drm) if (IS_ERR(priv->base)) return PTR_ERR(priv->base); - priv->scu = syscon_regmap_lookup_by_compatible("aspeed,ast2500-scu"); + priv->scu = syscon_regmap_lookup_by_phandle(np, "syscon"); if (IS_ERR(priv->scu)) { - dev_err(&pdev->dev, "failed to find SCU regmap\n"); - return PTR_ERR(priv->scu); + priv->scu = syscon_regmap_lookup_by_compatible("aspeed,ast2500-scu"); + if (IS_ERR(priv->scu)) { + dev_err(&pdev->dev, "failed to find SCU regmap\n"); + return PTR_ERR(priv->scu); + } } ret = of_reserved_mem_device_init(drm->dev);