From patchwork Wed Mar 3 13:43:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 392097 Delivered-To: patch@linaro.org Received: by 2002:a02:290e:0:0:0:0:0 with SMTP id p14csp5133510jap; Wed, 3 Mar 2021 05:44:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJyI0+MrD4T1n1uNzd6/ViJwQOGEDlUufb82aFOVqNwbS38Zpb/7VWAK8+N2kE78nW6Daipf X-Received: by 2002:a17:902:ea09:b029:e3:a720:b83 with SMTP id s9-20020a170902ea09b02900e3a7200b83mr25405300plg.51.1614779084292; Wed, 03 Mar 2021 05:44:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614779084; cv=none; d=google.com; s=arc-20160816; b=JyaqpHOmvc8ay2RHH6CHAjyzhyjRQ3fmUL3av3m6khwIf9oJeNN2hYqKKf+Cm4DQ+Z faK56CdMHDFIdx5d8Q8hTzqjzQ5dzrEZFAHcaLmGWPT+Qc5UyTMwwsB5PWL+zXPB9w53 YfhUyvPzssvpMmfSO8o9TgfoKu9ei9pKq00OIM7aUJVFaaYiqowMtiyiLSrJhVy39ub6 AdxD6qlfo97mn4gRUvY5wKxkhGeIyFP22vgKjGpfI2NoNxPGHhzt0jIH0vUE5ndenqIp TZJk5dz+VSN8nxi2uo3axF2pQAF4vKzPyyFq60iW0/TiKtR6CoPL3Ujv2WkHy0gta66G /+WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=T9jxxn09rSTh4f2dtcSiHJX3evrLxfSeomQpvUUmIiQ=; b=aJH0Bh9thkkh9AK6xUZGWIFpJAjzLZbjbkpqeHCQH9J68IN73dINU7AQeLpkNy5zgK R+e+L5wPqfjcGGbynL/1Shrzy/WAk3VfRLHM2ygeWYs/1OYHL1QBtRCJIazFmSfAoIj4 vRtghAOJC6yaUHwqna90H/WTLKd3U1qJwk8HwALarDq611+enrBBgU/75hkfzLMyWmcg VzhuMkC9uw1cAVv1n/W6ri/pjbXgZ3qGcAV7mpN5DHOhtbKRnMr2pxpuLnBKepB0p9jR Gcjrvp1HyR42asm7CErfaaL56AbQgGfZQT5vrIQxTOjcu3VO1Tzs0c6gHLTFsIMR3NCm cPYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=aCSLzlZk; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id o11si23358890pgu.347.2021.03.03.05.44.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 05:44:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=aCSLzlZk; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DF0576E932; Wed, 3 Mar 2021 13:44:15 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by gabe.freedesktop.org (Postfix) with ESMTPS id B53A66E932 for ; Wed, 3 Mar 2021 13:44:13 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id h98so23718305wrh.11 for ; Wed, 03 Mar 2021 05:44:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7KdaK2Zgurdc2XBJ7TzojsBHhNgJ68uvnriIvTNra9Q=; b=aCSLzlZkfC4ASi5bh4N+pN0ysuREn9w+yJ09GOBz+DLieRSdo74iSzbbgy3fv5x468 6NKu6gBGbVxUe2gIDUv3NQWEMtBgr/SZiT5Y/Ml9z5G1K3JsSUs79ZwknNMJW8yIdgOB oOPEnjC/cbq3uY+dX5yhVuYwV7GNDWBbukZkRuZmTsi1Zg/k8E/H346MduYYs3flk2n6 L47IaocbQGIF3MgSMr+ElG7ccqQ5gPi2Z/cxEYqr3tUkWjAKRz1dBKK2JPbkt8XHhLZ5 Y5dLj0/i0yyCcGJ7X6yJ0nk9N//SRSE1YeE3B41NXhNz3XzQDMAQLACMBbNG5kLY0uAd P0Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7KdaK2Zgurdc2XBJ7TzojsBHhNgJ68uvnriIvTNra9Q=; b=LxFm0x5e17Rmv4od6Vki90uTadqp//06o5DnTLMEp6j+V9CqxLhIYDe0+fe29Cm0OL /iC5yO2S7qfALYK8Yl4clfFnuXwfwLYUU4+wTIL/yRsZHdjc3+C4EE33BAXodu3T+RgU AbeodYnd5Rfm+mrloGxDdRZk2uA3i5k24dLcrS5rNOHX91ebMOphgtnh3OpRloHwASNJ YLYvsVZAFKFn/XiYeK2TCTfoi7H7VGp1eKvZZeXeUY2tp5C2veWeu9sGjmadQCDsjp8J 9FKUow/fHl+tt6sxcLbajwYHs4wWVg551hLwIyV3Y6Ryyj+gorsqG9NbEapEtEG3+5z7 Te6Q== X-Gm-Message-State: AOAM5328zDMgVK76xfVig7vRR7NLjL+4TMnAQYnKicbO82QF1CXCa9jL C3WBwPn9Aa7ICU3sf/poX8AwbQ== X-Received: by 2002:a5d:4a0e:: with SMTP id m14mr27416466wrq.73.1614779052427; Wed, 03 Mar 2021 05:44:12 -0800 (PST) Received: from dell.default ([91.110.221.155]) by smtp.gmail.com with ESMTPSA id w18sm6109524wrr.7.2021.03.03.05.44.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 05:44:11 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 37/53] drm/vmwgfx/vmwgfx_scrn: Demote unworthy kernel-doc headers and update others Date: Wed, 3 Mar 2021 13:43:03 +0000 Message-Id: <20210303134319.3160762-38-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210303134319.3160762-1-lee.jones@linaro.org> References: <20210303134319.3160762-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Roland Scheidegger , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, VMware Graphics Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:90: warning: cannot understand function prototype: 'struct vmw_screen_object_unit ' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:122: warning: Function parameter or member 'dev_priv' not described in 'vmw_sou_fifo_create' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:122: warning: Function parameter or member 'sou' not described in 'vmw_sou_fifo_create' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:122: warning: Function parameter or member 'x' not described in 'vmw_sou_fifo_create' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:122: warning: Function parameter or member 'y' not described in 'vmw_sou_fifo_create' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:122: warning: Function parameter or member 'mode' not described in 'vmw_sou_fifo_create' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:168: warning: Function parameter or member 'dev_priv' not described in 'vmw_sou_fifo_destroy' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:168: warning: Function parameter or member 'sou' not described in 'vmw_sou_fifo_destroy' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:283: warning: Function parameter or member 'state' not described in 'vmw_sou_crtc_atomic_enable' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:293: warning: Function parameter or member 'state' not described in 'vmw_sou_crtc_atomic_disable' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones Signed-off-by: Zack Rusin Link: https://patchwork.freedesktop.org/patch/msgid/20210115181313.3431493-30-lee.jones@linaro.org --- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) -- 2.27.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c index b0db059b8cfbe..6feb61a1a3041 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c @@ -84,7 +84,7 @@ struct vmw_kms_sou_define_gmrfb { SVGAFifoCmdDefineGMRFB body; }; -/** +/* * Display unit using screen objects. */ struct vmw_screen_object_unit { @@ -112,7 +112,7 @@ static void vmw_sou_crtc_destroy(struct drm_crtc *crtc) vmw_sou_destroy(vmw_crtc_to_sou(crtc)); } -/** +/* * Send the fifo command to create a screen. */ static int vmw_sou_fifo_create(struct vmw_private *dev_priv, @@ -160,7 +160,7 @@ static int vmw_sou_fifo_create(struct vmw_private *dev_priv, return 0; } -/** +/* * Send the fifo command to destroy a screen. */ static int vmw_sou_fifo_destroy(struct vmw_private *dev_priv, @@ -263,7 +263,7 @@ static void vmw_sou_crtc_mode_set_nofb(struct drm_crtc *crtc) /** * vmw_sou_crtc_helper_prepare - Noop * - * @crtc: CRTC associated with the new screen + * @crtc: CRTC associated with the new screen * * Prepares the CRTC for a mode set, but we don't need to do anything here. */ @@ -275,6 +275,7 @@ static void vmw_sou_crtc_helper_prepare(struct drm_crtc *crtc) * vmw_sou_crtc_atomic_enable - Noop * * @crtc: CRTC associated with the new screen + * @state: Unused * * This is called after a mode set has been completed. */ @@ -287,6 +288,7 @@ static void vmw_sou_crtc_atomic_enable(struct drm_crtc *crtc, * vmw_sou_crtc_atomic_disable - Turns off CRTC * * @crtc: CRTC to be turned off + * @state: Unused */ static void vmw_sou_crtc_atomic_disable(struct drm_crtc *crtc, struct drm_atomic_state *state)