From patchwork Mon Mar 22 16:41:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 406168 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp3720382jai; Mon, 22 Mar 2021 09:41:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDS+YzhKpc5rZCchB5BQujt43aDNqOmvQ2makZW32TSsHOewPBQWEc2V9u5mp9bexKNvsN X-Received: by 2002:a17:90a:7c4b:: with SMTP id e11mr219586pjl.151.1616431303682; Mon, 22 Mar 2021 09:41:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616431303; cv=none; d=google.com; s=arc-20160816; b=ufhcmH/HX/3Lsue+TsdZ3ccm4412RKITPA+iCZWJMBaxt8/fDtd+1EJUufQQ+utmRn 7bHbvRDWvwziZnElOb/0n4m8rbBTGJ1EL8kE/61U34lZ+xubapu3tFEk8NSs4649327/ 1giExjgT2bg0MGBNRojzO3TE3LKD0shUgGUfNikWi1D+LF+kwQNjeX3sRWfAICnKkED4 UTOaEAaBFVcomQVRlg3uk+6n9o/1XBJ6M4TXKgj8I/DCtZW4ECawD9s7BHfVYpOt+tJ8 93VIsjPwqdtMfSj7n8H/k70tkIm0x5W56K6BCuzQ+kRtz6Xmvk6Z31ZJbTnrY3INO93U qaZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :dkim-signature:delivered-to; bh=E2k5aN3jD5GbW0W70IYLqzfqejLOns/IrNlpiGF+9Ro=; b=WjSJY716nUmUhdqRD4ahwWAKOHvqFpGBSiIaZE01nGdQ8f+t/GHNVW8tQ5j4uHSo77 tDiWAHsWf7iUfXqJNrEuzMiedmq/J2rguYYOouXsnNwnI7tgZ3wSHQvQI+WlLjaaGxuZ hoPBZgxFR7bEE+oUdQjPjs7HnZFk6k6Gw7lGgK8hY3yHlTC769Pt9IG55VIvkQVMNUr3 Y75AiMSzst6j4gfa9TG6jNJrnOiQHbuj8atd8JV5aO+wl+Vnt6p50pP4v96U4WLOQA8O rvbAzcZOGYq57XCLF4FStkAsZDd37YPuNVYTEkEraQcyqhvYRQtNB+dxeSTQSSjB4qLp 1AqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=FPrmYxwL; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id n17si16316608pfd.284.2021.03.22.09.41.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 09:41:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=FPrmYxwL; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E8D1F6E11C; Mon, 22 Mar 2021 16:41:40 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 090756E11C for ; Mon, 22 Mar 2021 16:41:40 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D3D6461983; Mon, 22 Mar 2021 16:41:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616431299; bh=wTCQr9EWReJqtv/s8uqRSPBYWLbukkFUAZ7BJJhYHhI=; h=From:To:Cc:Subject:Date:From; b=FPrmYxwLnsZstci9axXyytZZzCy9y3Cevl1KqesKwOuenXzXvlVzxhadzwKXI54mr aSjFBZSVdDt22a6tXaI7+rJMgbES/VMyJGT6D0V0jpWtdKNJjJBI7i+FF1Cxm2JvSz Df/icB4sJaXsfPKndnUEX+SJzndY/e/Moin0GZrEgqjqDA1WPy4+f/S3jS/eSYmgQR cX1/5h5kq98Nru1lJO0vBoWrejwnli8I7gsqb9nlCSypsvDhhCyy5J4kLgSCWnWpTO 6APc7UdRuJKkdl0BJr4RE5gCy+vyln4Nw7PNsov+iQZrMrG1+gfPGHmvVsIRo0WQH4 09iB9yXFo/YoA== From: Arnd Bergmann To: Lee Jones , Daniel Thompson , Jingoo Han , Kristoffer Ericson , Richard Purdie Subject: [PATCH] backlight: journada720: fix Wmisleading-indentation warning Date: Mon, 22 Mar 2021 17:41:28 +0100 Message-Id: <20210322164134.827091-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Sam Ravnborg , dri-devel@lists.freedesktop.org, Arnd Bergmann , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Arnd Bergmann With gcc-11, we get a warning about code that looks correct but badly indented: drivers/video/backlight/jornada720_bl.c: In function ‘jornada_bl_update_status’: drivers/video/backlight/jornada720_bl.c:66:11: error: this ‘else’ clause does not guard... [-Werror=misleading-indentation] 66 | } else /* turn on backlight */ | ^~~~ Change the formatting according to our normal conventions. Fixes: 13a7b5dc0d17 ("backlight: Adds HP Jornada 700 series backlight driver") Signed-off-by: Arnd Bergmann Reviewed-by: Daniel Thompson --- drivers/video/backlight/jornada720_bl.c | 44 ++++++++++++------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/video/backlight/jornada720_bl.c b/drivers/video/backlight/jornada720_bl.c index 996f7ba3b373..066d0dc98f60 100644 --- a/drivers/video/backlight/jornada720_bl.c +++ b/drivers/video/backlight/jornada720_bl.c @@ -66,30 +66,30 @@ static int jornada_bl_update_status(struct backlight_device *bd) } else /* turn on backlight */ PPSR |= PPC_LDD1; - /* send command to our mcu */ - if (jornada_ssp_byte(SETBRIGHTNESS) != TXDUMMY) { - dev_info(&bd->dev, "failed to set brightness\n"); - ret = -ETIMEDOUT; - goto out; - } + /* send command to our mcu */ + if (jornada_ssp_byte(SETBRIGHTNESS) != TXDUMMY) { + dev_info(&bd->dev, "failed to set brightness\n"); + ret = -ETIMEDOUT; + goto out; + } - /* - * at this point we expect that the mcu has accepted - * our command and is waiting for our new value - * please note that maximum brightness is 255, - * but due to physical layout it is equal to 0, so we simply - * invert the value (MAX VALUE - NEW VALUE). - */ - if (jornada_ssp_byte(BL_MAX_BRIGHT - bd->props.brightness) - != TXDUMMY) { - dev_err(&bd->dev, "set brightness failed\n"); - ret = -ETIMEDOUT; - } + /* + * at this point we expect that the mcu has accepted + * our command and is waiting for our new value + * please note that maximum brightness is 255, + * but due to physical layout it is equal to 0, so we simply + * invert the value (MAX VALUE - NEW VALUE). + */ + if (jornada_ssp_byte(BL_MAX_BRIGHT - bd->props.brightness) + != TXDUMMY) { + dev_err(&bd->dev, "set brightness failed\n"); + ret = -ETIMEDOUT; + } - /* - * If infact we get an TXDUMMY as output we are happy and dont - * make any further comments about it - */ + /* + * If infact we get an TXDUMMY as output we are happy and dont + * make any further comments about it + */ out: jornada_ssp_end();