From patchwork Wed Mar 24 15:00:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 407848 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp484890jai; Wed, 24 Mar 2021 08:00:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxhXvsWHpsuzLaAFOQ9Syfdi7A1YPjffsTifOjqc9pRyAIhT5HYl9BChBsoxsxuVDjdPmx X-Received: by 2002:a63:d309:: with SMTP id b9mr3335481pgg.96.1616598053591; Wed, 24 Mar 2021 08:00:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616598053; cv=none; d=google.com; s=arc-20160816; b=JVSmrRtDsuynkeKQMj3HB2ZclROMlH+t0Dc7aUDZTfdOPz1zBVLuBDR37wtqsn6VN4 6dV7YGDUsMxUa2HDBApgCknktoQSis34KENP2QQypFBoWILbOTyxZBpu8+BXY9Y1JvhN uD6xVqizOJCpbzgq1UvrNAZLY7EHbn5CsrpyBgSvUGtNLIOvAKDyUC2C9Y4+U9KhXIQj dHVPbeohEmuBBZvTRnufJ0wnH6mV6eBR894EFEbMIYdYL+/1zm9llcQeqV5VxQj82cer 2nhrR4/KWHpb0GMEUHyZleG2SZl3b/uqKprvtbXQJtMg4B4KtHIR2/Uz/Xc9GjHh6iQJ zSSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=46XYgMbHOWzXqiDv46Z4sWkEtFrobL5jDDgnVYzlHas=; b=rz6tYnPKjfqNbM5EG3f+DhpJqzLc6JKBCSoOhZT7IDzeeqeFqLTo6gewGo6PgDin1H 5itXec4Xx7aN3s/Uuz36j69QUZmtx98p5hZq1x38qMJZbgdAEsrAtvkbIoBtB1jhHfe9 JFxscjBvoozaivvEKk/7EqTMcQarJDrXtM9IzcSRW/D2inv+WpDonUXAPTSbSpb38iGh JlZkYECn4pc7M1gztHKob5CeroK9P5yI7B0O8Go9aglpBs9PKd0IaK8ULije4JluGJK3 GP1gix+n+A9gX+o369MN+lraRhA2HafbXluHihiLW/s0of+MdC8NLjCTaLokoRNtpsTo SPSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ag41z3TT; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id a17si2443009plm.304.2021.03.24.08.00.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 08:00:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ag41z3TT; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 404F56EA20; Wed, 24 Mar 2021 15:00:51 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 47A816EC5D for ; Wed, 24 Mar 2021 15:00:48 +0000 (UTC) Received: by mail-lj1-x22f.google.com with SMTP id z8so30547154ljm.12 for ; Wed, 24 Mar 2021 08:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d5O4S87sSonR8b8YReuDQ+tyO7OoPApI6qR6ZtyWtNo=; b=ag41z3TTI+1hBOp+V0y4TJVbNjU4P32YDILwsy7eFogpNU14hviu29k6mpVJXDa0/O ZAKTkSO145kL4WjVZSc3XzIoAaxYiPPZ9SMz/64GtrFp3ovjG38Rg4O8EBNaWk1O+0Kq XnnFzHB3jqgTkfQ2c2HL3O13OmbKf7NUiJ5OD4GXA62V6Dc4NA/ysda9maA2cIXl/Cm2 cXXPSs+nzdrt7uH5OcNULCqokEROmZKlR1ekDxYlKzVsPEMJOphetpg0MvnjLar5EJBH 3Q6jZjWbGGzkoihRkVXkCAHYbmYer8U2Wb1xszsMI0DsTJ+wCBHQKGudylwMsWa0fvsi 9bag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d5O4S87sSonR8b8YReuDQ+tyO7OoPApI6qR6ZtyWtNo=; b=mDQAaaE+7FdGyFGITi6BAl+cvelFMmiMRxmmSMKmKTdXIxWjRnfLwUaYNNkgsHJXbp IZ2qTz2zvylG+5OI5jrflf/Wl+5YfIxcXt2/auXpAr1wAg7ts1G9g57yk6NJXxmZ6tKh zvvHlYgEKIGGTpH/ToCbDwOTwX0nfayVOLKijuFntfiFHEVUDyLeogsH81f1wAldJUOO rdGSf5XCXhjQfhuAmoZxfNdOPoP4yVYAbpFYb8cjElD9AZeCFey5aFPjG4elBb4g5ro8 9WBNLwImyAQBgD3js/EKAdCr/AnTWUrq1A16hp5bgkFYjGlkg9708mr9AKrKToPtZ6VZ SUaw== X-Gm-Message-State: AOAM530KpJRII+3sGsINHoJKICPKp8dxsste6aFWJKtLIlllLjv0BIzS vMqEZdOTYlbfmYS5o5oeugMZgg== X-Received: by 2002:a2e:6c10:: with SMTP id h16mr2397033ljc.388.1616598045961; Wed, 24 Mar 2021 08:00:45 -0700 (PDT) Received: from eriador.lan ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id p5sm252463lfe.154.2021.03.24.08.00.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 08:00:45 -0700 (PDT) From: Dmitry Baryshkov To: Rob Clark , Sean Paul , Jonathan Marek Subject: [PATCH 13/21] drm/msm/dpu: hw_pp: make setup_dither mandatory Date: Wed, 24 Mar 2021 18:00:16 +0300 Message-Id: <20210324150024.2768215-14-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210324150024.2768215-1-dmitry.baryshkov@linaro.org> References: <20210324150024.2768215-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Boyd , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" All supported hardware instances feature DPU_PINGPONG_DITHER option, so just mark setup_dither as mandatory rather than optional callback. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 3 +-- 2 files changed, 1 insertion(+), 5 deletions(-) -- 2.30.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index f80694456fd6..ac03f329491d 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -217,9 +217,6 @@ static void _dpu_encoder_setup_dither(struct dpu_hw_pingpong *hw_pp, unsigned bp { struct dpu_hw_dither_cfg dither_cfg = { 0 }; - if (!hw_pp->ops.setup_dither) - return; - switch (bpc) { case 6: dither_cfg.c0_bitdepth = 6; diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c index 89c1123d957f..5c1ce835cf49 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c @@ -258,8 +258,7 @@ static void _setup_pingpong_ops(struct dpu_hw_pingpong *c, c->ops.poll_timeout_wr_ptr = dpu_hw_pp_poll_timeout_wr_ptr; c->ops.get_line_count = dpu_hw_pp_get_line_count; - if (test_bit(DPU_PINGPONG_DITHER, &features)) - c->ops.setup_dither = dpu_hw_pp_setup_dither; + c->ops.setup_dither = dpu_hw_pp_setup_dither; }; struct dpu_hw_pingpong *dpu_hw_pingpong_init(enum dpu_pingpong idx,