From patchwork Tue May 11 09:43:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 434187 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp3656754jao; Tue, 11 May 2021 02:43:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLmUW0NZLoFeB/bZIKKsDlYjOYu/Iwt6tGgDevUGaOih0X0efHbU57vvYoz8xQVl/qXGqe X-Received: by 2002:a65:4887:: with SMTP id n7mr7915853pgs.284.1620726207991; Tue, 11 May 2021 02:43:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620726207; cv=none; d=google.com; s=arc-20160816; b=ygUWnlB6dmH+p7n5aC1kBEnHkLVbdvQ6eGgPa7YumW3XL/dKyH4dMJFp+zK2vAifno 4WcfUGjKt/pfiHvy5pGIqE92GBGCZXtAwMUcYPwPSzr4YaBkUnqoLXxqPX+Lc9NJi1FR 1+2AQ1cUtkp6ttY1wwhrzJkhX6pkFvUjACfz+HC58mPqK0FoxjemTd0OiOH8QCuecQCw Bh64iHyQQWMsqwEkEdmm3wHWC2gi/xxkyQi8HqMiR9HQvhnEoVGx4vdBM8OTtiwa3Kku 3isdkqoNEHvnax3IAHqUJWRT1J9VfKTCsewQVz27o/G5576wapdUMw5fjheKZ2zVwxPW xeRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:delivered-to; bh=/tOJtAiZz6lGt1uGi0imk0CUisy6VegIqQUV5QdWKJ4=; b=1BcC/dNFSiRs/aSM4VZoUqw+r7hwcBifLe6Y+jmbcKSiQPo5bpThsAEiLVbW5atCs+ NswuTUD3Um6loazPuQ1HY3Z2RBVQmc2XpOIw7T1a+NfhZh2d+5gN14JfYuBYi1rxSvDX VCpAwpCmn5s3mppsSA0AGTfqCHucp/79QVp9KhKPk8C089wCfgTqSkURCGhV6jiUuN5d pLneXC7qUZGgDZEicdZ9xLtLIXzflZDDIYUOTLqRp0CqAPVRR0IzYv2e3icY8nguORWR J6vdJAbY646J+Wu30EeecI+/lmy2Wc0j3RAsYviHvjlkD8EtrE5WqxPBt/wwmFdc3iqj bBpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id f9si20922475pge.329.2021.05.11.02.43.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 02:43:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 231F56EA12; Tue, 11 May 2021 09:43:26 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A80A6EA12 for ; Tue, 11 May 2021 09:43:24 +0000 (UTC) Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FfXvh6Zkyzmg5n; Tue, 11 May 2021 17:40:00 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.72) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.498.0; Tue, 11 May 2021 17:43:15 +0800 From: Zhen Lei To: Anitha Chrisanthus , Edmund Dea , David Airlie , Daniel Vetter , dri-devel Subject: [PATCH 1/1] drm/kmb: Remove redundant error printing in kmb_dsi_map_mmio() Date: Tue, 11 May 2021 17:43:08 +0800 Message-ID: <20210511094308.4779-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhen Lei Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/gpu/drm/kmb/kmb_dsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/gpu/drm/kmb/kmb_dsi.c b/drivers/gpu/drm/kmb/kmb_dsi.c index 4b5d82af84b3014..6f278bc018cee67 100644 --- a/drivers/gpu/drm/kmb/kmb_dsi.c +++ b/drivers/gpu/drm/kmb/kmb_dsi.c @@ -1468,10 +1468,8 @@ int kmb_dsi_map_mmio(struct kmb_dsi *kmb_dsi) return -ENOMEM; } kmb_dsi->mipi_mmio = devm_ioremap_resource(dev, res); - if (IS_ERR(kmb_dsi->mipi_mmio)) { - dev_err(dev, "failed to ioremap mipi registers"); + if (IS_ERR(kmb_dsi->mipi_mmio)) return PTR_ERR(kmb_dsi->mipi_mmio); - } return 0; }