From patchwork Mon Nov 22 22:21:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 519301 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp7680948imj; Mon, 22 Nov 2021 14:23:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJw83YybyU1gnYuGlmd454dlGiMjbJc/0ZQ37c8I817hdqhxbnmEYK0lLOL2Yh0I6QAu+hi9 X-Received: by 2002:a63:454:: with SMTP id 81mr299901pge.24.1637619794831; Mon, 22 Nov 2021 14:23:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637619794; cv=none; d=google.com; s=arc-20160816; b=grWom+EoeJgb86ZH18IxCx98pz7yT9UyVhwYW3MiySnlNXYBrKEGC+yqP4V7LLIIJn 0rr0N48XtDjlq7okCIowXIpukheFig/6N4sLHf66NcH/2zlF188kN/rmhwW5xcq4s4M5 U2eVuEe9eTVnRt+QekyP9bGfH+DhppvTFpTrkXIwWjc3nEJtJrdK710YPmrnOISDODYz vY09EPWGX4ZQZ934Al2M06cgfdUFwnWEFirrFKM1ehJveg2r5AxZGxoks4S5TiRaMYUh 7zSaun+cYtVcVNqyLKpbjmYYuIwFczGFiTPXP+RMNssDqVFzp9fGn5vm5uEiI1yfBwAd YOyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature:delivered-to; bh=18/pTkEbfPBUs0PrW3IpDqzJNVnw1fZXTxM0hJtol+g=; b=jtEUj47UGhi1O7H2oyczZEu074X0Vv+i6+AQlsHOdSl887C+lxvLpkW+kB8Wl7xosO +H4/+DwaHlS8ELo0O2+4zwg1UUBc5oIQ6/ueQesn1wKQBHycoagiCcdj546q9RRJO4nk vyYXWwecHI+hJgDoTr+W6CtN+hk9jwEKvvcz1v71vN/3+7lkS2lG5RTiUGncnXZUVaOy Y3DryOVFPFwRHwBZNWV59k8eBC6/13lFz9m9QBQeURhRqcb8q6RBVQjd0hBcR75P03/i G71jv636D1CLu2g1k9rlwpImLDEfvYrvjhrQi8QL2VHDjHvQpOKy5DZSLtRw053xx+xz Ce7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=Mds7UvBa; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id x9si11850567plv.355.2021.11.22.14.23.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Nov 2021 14:23:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=Mds7UvBa; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7313B89E47; Mon, 22 Nov 2021 22:23:13 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id D104389E47 for ; Mon, 22 Nov 2021 22:23:11 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9540861051; Mon, 22 Nov 2021 22:23:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637619791; bh=mEZeKwAu9cmy86njGDu0eXHIrGjfEnYmGSI37A9u8C4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Mds7UvBahSLSVHiBQ9v2Ytg5G1Sxspx3HwfkVRigOS+lcbEmjTSyArF7E1ugjwBBD 2YqSubbC7b6D0R0dyKzHjgFlTme434/IjPEnvZwi2CG9RIUhvUPIqM1M6Qfe8xBdtS n7Cbk51NQppDYReLPMyQPjV7wY1ln/ndhpewTxxkL/meQAovg2HWZHUjvGmZNShKh4 +lzzUkQ+p/BnGqZl17YTexH1jnjJNGGbt90k/iXE3j4vagAjUI+gZPiuTSca+PmE0+ vis7Va7kgZlXo6RAiCjJUtA+avyjvYe+q5Y2LJSAAPAoO/7sW8Al8MVdglg/v4rbAT AcAek++ntYExw== From: Arnd Bergmann To: Vinod Koul Subject: [PATCH v2 06/11] dmaengine: pxa/mmp: stop referencing config->slave_id Date: Mon, 22 Nov 2021 23:21:58 +0100 Message-Id: <20211122222203.4103644-7-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20211122222203.4103644-1-arnd@kernel.org> References: <20211122222203.4103644-1-arnd@kernel.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Bjorn Andersson , linux-tegra@vger.kernel.org, Thierry Reding , linux-mtd@lists.infradead.org, Laurent Pinchart , linux-spi@vger.kernel.org, Robert Jarzmik , Chunyan Zhang , linux-staging@lists.linux.dev, Michal Simek , Jon Hunter , Andy Gross , bcm-kernel-feedback-list@broadcom.com, linux-serial@vger.kernel.org, Orson Zhai , Nicolas Saenz Julienne , Arnd Bergmann , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, Mark Brown , linux-rpi-kernel@lists.infradead.org, Jaroslav Kysela , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, Scott Branden , Hyun Kwon , Greg Kroah-Hartman , linux-mmc@vger.kernel.org, Takashi Iwai , linux-kernel@vger.kernel.org, Laxman Dewangan , Baolin Wang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Arnd Bergmann The last driver referencing the slave_id on Marvell PXA and MMP platforms was the SPI driver, but this stopped doing so a long time ago, so the TODO from the earlier patch can no be removed. Fixes: b729bf34535e ("spi/pxa2xx: Don't use slave_id of dma_slave_config") Fixes: 13b3006b8ebd ("dma: mmp_pdma: add filter function") Signed-off-by: Arnd Bergmann --- drivers/dma/mmp_pdma.c | 6 ------ drivers/dma/pxa_dma.c | 7 ------- 2 files changed, 13 deletions(-) diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c index a23563cd118b..5a53d7fcef01 100644 --- a/drivers/dma/mmp_pdma.c +++ b/drivers/dma/mmp_pdma.c @@ -727,12 +727,6 @@ static int mmp_pdma_config_write(struct dma_chan *dchan, chan->dir = direction; chan->dev_addr = addr; - /* FIXME: drivers should be ported over to use the filter - * function. Once that's done, the following two lines can - * be removed. - */ - if (cfg->slave_id) - chan->drcmr = cfg->slave_id; return 0; } diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c index 52d04641e361..6078cc81892e 100644 --- a/drivers/dma/pxa_dma.c +++ b/drivers/dma/pxa_dma.c @@ -909,13 +909,6 @@ static void pxad_get_config(struct pxad_chan *chan, *dcmd |= PXA_DCMD_BURST16; else if (maxburst == 32) *dcmd |= PXA_DCMD_BURST32; - - /* FIXME: drivers should be ported over to use the filter - * function. Once that's done, the following two lines can - * be removed. - */ - if (chan->cfg.slave_id) - chan->drcmr = chan->cfg.slave_id; } static struct dma_async_tx_descriptor *