From patchwork Wed Feb 9 17:25:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 541148 Delivered-To: patch@linaro.org Received: by 2002:ad5:420f:0:0:0:0:0 with SMTP id e15csp1530768imo; Wed, 9 Feb 2022 09:26:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJzgrVRXfBm/heObIfUEg3blC9I/u15ZPS/sNiUKpf4qzcNkyxziZAhRqFw+O04PdW53fzB0 X-Received: by 2002:a63:8942:: with SMTP id v63mr2668356pgd.466.1644427587026; Wed, 09 Feb 2022 09:26:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644427587; cv=none; d=google.com; s=arc-20160816; b=ZnGFE+flafYbY1cYnqQZ0nsXv8zPiu0mn6mY/9uNhlH524zEGcLKtgjV0VfAH1miAh 29mE/t6CA1QSwuOOof2FwRI30u7wEOR6WE8Y4JxsDoOcaWuFSVods1nXghBgrIx+nN96 01Im+LN7MVMyiSc81Z7ssXjfYgvbuL9Qr3V1Sl4L0VGEmSxIDmXGTrTC+s9+RnG3KFBx LZvIf3E9SGSPA1gVc0cmi7FEIJo5jg8SvnbLaSQVu7e2qkZAKUYLuUmssWz5ym6jha7Q HfmD9LXFcHolArF+X1A1BQ8XASFounEczhPnvdfUm9f+lCROWJpthJVFCXHN/7wedwmz 8kkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature:delivered-to; bh=1BxIwaA+ghqxoRAg9KQeU7mQU/4hfs4ZFm3Ll8NcMIs=; b=eJYSYLqVYV6Eeo34G24YBg8K8mWxthCXZiIYkaPd4xtTfiMv+Cu3IbERJil2hAGO8K MXQ7vfWwE3vlq0nwJzJidIs4b37fYEza40fhhlzFYTc350RnhUZdQNRrE1y5KfdUFC2Q hMNFRa/BmNPJX52sc3yvV8YXczhDL+LTU8geiP2rPnQXyjmn2FKKRPwEHAjUVDVwqmhw sW6nKd0+w4efNPu6H0MkbJ8hqo9+vNia6reD6/SfID+lg37ygjyCLLSJ9Eq3SSp08mY+ ne51s+Sfbgss1903XOotkaU9LGWBMXLSxFy+yp4x/94/BNJwtti1uO407FFvitQSQgyZ c/4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="xxXTMVE/"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id u70si866505pgd.878.2022.02.09.09.26.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 09:26:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="xxXTMVE/"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 12EA910E535; Wed, 9 Feb 2022 17:25:55 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9B1FC10E4EE for ; Wed, 9 Feb 2022 17:25:38 +0000 (UTC) Received: by mail-lj1-x235.google.com with SMTP id k10so1440435ljq.2 for ; Wed, 09 Feb 2022 09:25:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1BxIwaA+ghqxoRAg9KQeU7mQU/4hfs4ZFm3Ll8NcMIs=; b=xxXTMVE/i0e3F7YJkR5Dl+zIiNXbJ9Za55VjNBE8FqAbPkFYENeO3YLYEeH18BXOcy ImudhX4v3mOntUNkoeKhV23R8TUG45DWA4IB8zkpod6aoTM9AGeZQGkJk37huZGTrEU1 XQI6/wu+dCXz2INNMuwJuISsfYf/KRiPRZQtRkQQOdtOvnkweaTBiW/bfGHUeB1c1dj9 kRodCcdQ4t6HeNb/MIBc4EUk4BHlOEWcIJt0Q6PclBmGEHDMM4Zn8XCnxJOQREsK3Ysw H7ouQi5TKJUMpOL5BLUt0ZSnoa9YeySXgqVf5i4/6GiIgbR15Md9/aLrLa1ips7OGH5X SPrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1BxIwaA+ghqxoRAg9KQeU7mQU/4hfs4ZFm3Ll8NcMIs=; b=j560iDozlYifpNVtmpRVfQgvdFwzun/XRcZPPWB3BNRpX506/y9mcQMh/j/dXPVdPq 4ecaUT92y0UgEjidourfE3Ii9/iUXDcTAUhAgwGLXoCEuRuZrAredWWrf8iz+3ccICoq 4qcbyYB9D0IMtZTAPtCL+n5dISfpYoZR8tm/aIweKDBl6YmF/+JxOaYsF+Vg7l+1u9X2 LmlKMk1Ab3Xgp8b61Y0brOnATlA8KeV1VtYl8wgeaptlaDXyxHJcom8aduMVILmKSCTr 3Mj5xnXEuP9VeCfkGWKa12FBAqNRFCniDJkepPYdqTDSGBkZjJXCvxEHEvagHzeRmZWK Z3fg== X-Gm-Message-State: AOAM530/NC8e+7ZnYPm6lcOcn8SKlefhs5oxYCrrtStL/icwNW5Ac7/W YTB1I8URWNxlA1ZsHvzkpQaWOA== X-Received: by 2002:a05:651c:214:: with SMTP id y20mr2122568ljn.223.1644427537016; Wed, 09 Feb 2022 09:25:37 -0800 (PST) Received: from eriador.lan ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id u14sm2560055lji.40.2022.02.09.09.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 09:25:36 -0800 (PST) From: Dmitry Baryshkov To: Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar Subject: [PATCH 16/25] drm/msm/dpu: drop EAGAIN check from dpu_format_populate_layout Date: Wed, 9 Feb 2022 20:25:11 +0300 Message-Id: <20220209172520.3719906-17-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220209172520.3719906-1-dmitry.baryshkov@linaro.org> References: <20220209172520.3719906-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Since layout is not cached anymore, drop comparison against previous layout and corresponding EAGAIN handling. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 4 ---- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 5 +---- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c index 440ae93d7bd1..5c7d739143f0 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c @@ -927,10 +927,6 @@ int dpu_format_populate_layout( else ret = _dpu_format_populate_addrs_linear(aspace, fb, layout); - /* check if anything changed */ - if (!ret && !memcmp(plane_addr, layout->plane_addr, sizeof(plane_addr))) - ret = -EAGAIN; - return ret; } diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c index a521c0681af6..b2395f02f6d3 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c @@ -1061,10 +1061,7 @@ static void dpu_plane_sspp_atomic_update(struct drm_plane *plane) memset(&pipe_cfg, 0, sizeof(struct dpu_hw_pipe_cfg)); ret = dpu_format_populate_layout(aspace, fb, &layout); - if (ret == -EAGAIN) { - DPU_DEBUG_PLANE(pdpu, "not updating same src addrs\n"); - update_src_addr = false; - } else if (ret) { + if (ret) { DPU_ERROR_PLANE(pdpu, "failed to get format layout, %d\n", ret); update_src_addr = false; }