From patchwork Thu Feb 10 11:41:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 541432 Delivered-To: patch@linaro.org Received: by 2002:ad5:420f:0:0:0:0:0 with SMTP id e15csp2153038imo; Thu, 10 Feb 2022 03:41:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJydI/zL/K7bt5Avf3yASWwlvlCkcfAgc/CisAf6HJpdOve3ZFcjD3Qs/sDwi0ewYCi01oIR X-Received: by 2002:a65:6751:: with SMTP id c17mr2008908pgu.197.1644493282006; Thu, 10 Feb 2022 03:41:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644493282; cv=none; d=google.com; s=arc-20160816; b=RW95pekI+xuW1cF+nKThttstukfFbr8n6SYI1zp81HUYVCY/R67xEif+rUW8UqaIC0 wuHmnCq+KG+iTe7Snw1YB0E4Dg3tQBVimPun8vpMWlhPYyLFdOGDQnYWFm7D01OViUdY MKJuDJOV3nqO57Kd8EEpZ/X0MTgipKQ8zlDi525guDYq/4KNCxrWhkBlsmuvoWVUd/RS gAak3C5kyWpi+vs4tbMWJO9sRqw5HEe4TLGQUAzoUp1ifIJJpJ3JFTKcBh+IkenbkKtU 1M5b8G8Eg5j9FER0tdCqLrPvjP9ioLYgFCwt36fiTruu1F844zWxBKqO0KtSPjOWkeJr IotQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature :delivered-to; bh=kNnS53Ttn+QLo0R2p6aXhuJnXS2tHYVDdT4lyB7cKxA=; b=NXdBaXEs6ChAX65btsdKi7UQryAiMb7vMbsQYEp1v9SAVBKmNQzIxjYBYNXkvbp7yI r1+48MVRuN12ZBJ57XbeiFIe4hTRgufR8l+Gg/IyY5e4s02InnCZ5/1EdGx8wT1UMihU qfD2Sz758tcWzApdCfED9HFTP9R3VOgNJd6vRl0xf2moMVEGJS08lPu7GI/tQBDYeAQf Qqc42jgJYITDEcwYvWLcoG6HVRIVW8w0fHgoOOQkPCIXOOPVfYD8mLeUm/YbE7GJfNF7 v4VkH4Ujs2BOL9ATF+bU0gm41vMn1RhCea+XeFOwRnjf+7SSnrltc0a9LDF9FY9J4huN dwmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=WdhEQGRt; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id h70si18235749pgc.670.2022.02.10.03.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 03:41:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=WdhEQGRt; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 893C710E816; Thu, 10 Feb 2022 11:41:18 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB70810E815; Thu, 10 Feb 2022 11:41:16 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1DBEE61D12; Thu, 10 Feb 2022 11:41:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C632EC004E1; Thu, 10 Feb 2022 11:41:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644493275; bh=YX1gi59/HZbFW3O0Wnmg+lqGfVhLTyza+iIoN+OkqZ4=; h=From:To:Cc:Subject:Date:From; b=WdhEQGRtOpRhyZ6JWVwUVoJSQt9Imap+QU8DPJgQYnD4UI6NkPC67iN6XW2w4X4zx sRcVtwhOm9l3tiEY6pMPQlccFPEDowvg7IVRhr1hTosIlbhx0RZR6Jc21emXLIX7KY XCjFH6rdRXbkuSQVEii+16t3UZk3uWOPbmBz2dcPsjtIwfsa66vLxkxdwvOi8nMCbS aN4h77DFeEsc+PMnpyxGgfGQZzAn0a8zKoiJZtrEBK6v8mXBJvShV++3j1pbL2zItX 6FhW2VjPqdwm2xjlFNP8oPu04Cfn5eT88xdnXL2UynMZ9jwKj69rKFpOQ9cJwKrw9p JmVgwIN2YxCBw== From: Vinod Koul To: Rob Clark Subject: [PATCH 1/3] drm/msm/dpu: Remove set but unused variables Date: Thu, 10 Feb 2022 17:11:04 +0530 Message-Id: <20220210114106.290669-1-vkoul@kernel.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kalyan Thota , freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, David Airlie , linux-arm-msm@vger.kernel.org, Kuogee Hsieh , Abhinav Kumar , dri-devel@lists.freedesktop.org, Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Stephen Boyd , Sean Paul , Guenter Roeck , Mark Yacoub Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" We get warning: In function ‘dpu_encoder_virt_enable’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1145:33: warning: variable ‘priv’ set but not used [-Wunused-but-set-variable] 1145 | struct msm_drm_private *priv; In function ‘dpu_encoder_virt_disable’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1182:33: warning: variable ‘priv’ set but not used [-Wunused-but-set-variable] 1182 | struct msm_drm_private *priv; Remove these unused but set variables Signed-off-by: Vinod Koul Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 1e648db439f9..132844801e92 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -1142,14 +1142,12 @@ static void dpu_encoder_virt_enable(struct drm_encoder *drm_enc) { struct dpu_encoder_virt *dpu_enc = NULL; int ret = 0; - struct msm_drm_private *priv; struct drm_display_mode *cur_mode = NULL; dpu_enc = to_dpu_encoder_virt(drm_enc); mutex_lock(&dpu_enc->enc_lock); cur_mode = &dpu_enc->base.crtc->state->adjusted_mode; - priv = drm_enc->dev->dev_private; trace_dpu_enc_enable(DRMID(drm_enc), cur_mode->hdisplay, cur_mode->vdisplay); @@ -1179,7 +1177,6 @@ static void dpu_encoder_virt_enable(struct drm_encoder *drm_enc) static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc) { struct dpu_encoder_virt *dpu_enc = NULL; - struct msm_drm_private *priv; int i = 0; dpu_enc = to_dpu_encoder_virt(drm_enc); @@ -1188,8 +1185,6 @@ static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc) mutex_lock(&dpu_enc->enc_lock); dpu_enc->enabled = false; - priv = drm_enc->dev->dev_private; - trace_dpu_enc_disable(DRMID(drm_enc)); /* wait for idle */