From patchwork Wed Feb 7 14:11:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jyri Sarha X-Patchwork-Id: 127188 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp509289ljc; Wed, 7 Feb 2018 06:12:14 -0800 (PST) X-Google-Smtp-Source: AH8x224qND4JgOBkgt6WrEVdZfWtsm1uW/O7XsqTHv/2DP8oMc2m3yDOKLuIUAHfkCl1jBCc5gJn X-Received: by 10.101.67.65 with SMTP id k1mr5093543pgq.159.1518012734746; Wed, 07 Feb 2018 06:12:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518012734; cv=none; d=google.com; s=arc-20160816; b=uK2hHUWAbifwXWA02Qs+WqmqkPVWLz9BC0/F96t4TSejmt2Jy39raThG/EbeH9BO46 EfhVuaKFGRgQl38xj1pkxeMZNNRlitowwBS1em97V+gtdWqJJYpVMBdV+G1mDN1/1RgF qM3bgkDoDpkg6GQ8sjlg+T/kCAOo19+T7aWQ8xzS5RQkdwhpFJ6bhCK9Sge02FMe5LI5 1iP/S9Vs2jZk+jurmnn42p3G/nrQVxUb4gnZW83MJprhMGuOE+GiPaGpKKYmfWCxD4GH ZuWkK5Yl89PmQUNX8zbaq8MLR6nVyGrlOIF4EFMeh6MHVwUwhsK5B+QOeNdfreNOSNVW IESQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=Q/empJEX3p8s+ONoblXYgZxW8Jph096H+9PAma8MAhc=; b=ntv/j8z/j/gMIqWvEnC8qdt2P1J0RTmB+RhjYHcRiZNQjoLyWGEDa9ePb+nICp3IhW P/NY9j8IZNhW/1GZ1DKOKYy6X3r+/OHP+FGzB2Vha3qMxwhqQJTNMzgACkxydCR5xp/Q NTRO5OBJCkUbi8sDjVzYZlRSXPdil4LWBAqFXbmg2h1ViX+0qSh7rG7357S5m+wcZx0B ZBaeFBVKAxzRuatBT0Jg/lSluE0AI1p2T4rDhJ6McovKRXwmQQmBjssY3xf8CpboqBnA WDDh2cuUs4ArpM0CSIORBOhxvujTdsVOLMJYvGTqq9jnT/dtA226hHuU6x1eAnpjQFNt n4Wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=Id2yJtVp; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id c200si1172051pfb.301.2018.02.07.06.12.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Feb 2018 06:12:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=Id2yJtVp; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BF52189F71; Wed, 7 Feb 2018 14:11:41 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from lelnx193.ext.ti.com (lelnx193.ext.ti.com [198.47.27.77]) by gabe.freedesktop.org (Postfix) with ESMTPS id DEECC89310 for ; Wed, 7 Feb 2018 14:11:39 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by lelnx193.ext.ti.com (8.15.1/8.15.1) with ESMTP id w17EBbqd014145; Wed, 7 Feb 2018 08:11:37 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1518012697; bh=Sjw3HLHy59pai6o6pT+xLmqa2ARAlK5HVDgralJxSpo=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=Id2yJtVpRfDK2062XpGwFZubsi/GzAbmjENk4z0XYnot5kxggZV8FfzNXUJiL2LtN m6rgeGM3FCO1LVyJD3VOZwMdGTmI25fwZiWw4hSzQoP2NozDvCHVuCjpwpLkctMSEV 89Zisk97uK3eHewvqUMpmVxOBg5SrksAp9DvFa+Y= Received: from DFLE110.ent.ti.com (dfle110.ent.ti.com [10.64.6.31]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id w17EBbtb029922; Wed, 7 Feb 2018 08:11:37 -0600 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.35; Wed, 7 Feb 2018 08:11:36 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1261.35 via Frontend Transport; Wed, 7 Feb 2018 08:11:36 -0600 Received: from jadmar.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id w17EBXH2004400; Wed, 7 Feb 2018 08:11:35 -0600 From: Jyri Sarha To: Subject: [PATCH v3 1/3] drm/omap: Fail probe if irq registration fails Date: Wed, 7 Feb 2018 16:11:26 +0200 Message-ID: <802e7cedf8a697deeef3f143cc1068520b35f2f6.1518001667.git.jsarha@ti.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com, Jyri Sarha Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Call to omap_drm_irq_install() may fail with an error code. In such a case the driver probe should fail. Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c index 71ea43f..e6e7a2c 100644 --- a/drivers/gpu/drm/omapdrm/omap_drv.c +++ b/drivers/gpu/drm/omapdrm/omap_drv.c @@ -329,9 +329,9 @@ static int omap_modeset_init(struct drm_device *dev) drm_mode_config_reset(dev); - omap_drm_irq_install(dev); + ret = omap_drm_irq_install(dev); - return 0; + return ret; } /*