From patchwork Thu Dec 15 20:51:45 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 5787 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id CAE7E23E19 for ; Thu, 15 Dec 2011 20:51:48 +0000 (UTC) Received: from mail-ey0-f180.google.com (mail-ey0-f180.google.com [209.85.215.180]) by fiordland.canonical.com (Postfix) with ESMTP id C210BA1825A for ; Thu, 15 Dec 2011 20:51:48 +0000 (UTC) Received: by eaak10 with SMTP id k10so2811373eaa.11 for ; Thu, 15 Dec 2011 12:51:48 -0800 (PST) Received: by 10.205.120.135 with SMTP id fy7mr2356354bkc.54.1323982307884; Thu, 15 Dec 2011 12:51:47 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.205.129.2 with SMTP id hg2cs53026bkc; Thu, 15 Dec 2011 12:51:47 -0800 (PST) Received: by 10.52.175.9 with SMTP id bw9mr4265102vdc.130.1323982305549; Thu, 15 Dec 2011 12:51:45 -0800 (PST) Received: from mail-vw0-f50.google.com (mail-vw0-f50.google.com [209.85.212.50]) by mx.google.com with ESMTPS id r10si3717651vdw.132.2011.12.15.12.51.45 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Dec 2011 12:51:45 -0800 (PST) Received-SPF: pass (google.com: domain of robdclark@gmail.com designates 209.85.212.50 as permitted sender) client-ip=209.85.212.50; Authentication-Results: mx.google.com; spf=pass (google.com: domain of robdclark@gmail.com designates 209.85.212.50 as permitted sender) smtp.mail=robdclark@gmail.com; dkim=pass (test mode) header.i=@gmail.com Received: by vbbey12 with SMTP id ey12so2514986vbb.37 for ; Thu, 15 Dec 2011 12:51:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=qIb4k4Lu9pYMeMKz2EgHSoLVfwzxCJYP7PlLUR8xaTk=; b=KEvswmg8mIPDTG67T5snv7Yp9RKuOTytAk4I/2jPzmfRJrFlsU92uZW7f2qbbYPUxz 3FyWIo6QSMba8ztAocMDbC0fNLmoa2MzX7dtq9veZ/oFsooayEkJcb74lpj1gXUrymK1 tzYYWLrUlatiIXTlfuAJubXxnVAvR8Azrf7Cs= MIME-Version: 1.0 Received: by 10.52.28.15 with SMTP id x15mr4404867vdg.46.1323982305036; Thu, 15 Dec 2011 12:51:45 -0800 (PST) Sender: robdclark@gmail.com Received: by 10.220.148.3 with HTTP; Thu, 15 Dec 2011 12:51:45 -0800 (PST) In-Reply-To: <20111213003905.GA3935@kroah.com> References: <1323637997-18045-1-git-send-email-rob.clark@linaro.org> <20111213003905.GA3935@kroah.com> Date: Thu, 15 Dec 2011 14:51:45 -0600 X-Google-Sender-Auth: EKSa7d3X_4fslBu3T6CPwR3hRt8 Message-ID: Subject: Re: [PATCH] staging: drm/omap: fix for connectors not enabled at bootup From: Rob Clark To: Greg KH Cc: dri-devel@lists.freedesktop.org, patches@linaro.org On Mon, Dec 12, 2011 at 6:39 PM, Greg KH wrote: > On Sun, Dec 11, 2011 at 03:13:17PM -0600, Rob Clark wrote: >> From: Rob Clark >> >> The connector's dpms fxn is only triggered by userspace.  When the >> driver is loaded and detected displays configured, drm core only >> calls the crtc and encoder's dpms functions. >> >> Signed-off-by: Rob Clark >> --- >> Arguably, this could be called a work-around, and instead drm core >> should call connector's dpms functions and rely on >> drm_helper_connector_dpms to call encoder and crtc dpms functions. >> If people think it is better to fix this in drm core, and don't >> mind me making that change, then I will do that instead. > > Sounds like you should do that in the drm core itself, so I'll not queue > up this patch for now. Ok, seems to be a one line change in drm core, which I'm about to send a patch for: } } drm_helper_disable_unused_functions(dev); > thanks, > > greg k-h > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index d2619d7..2f1ec7c 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -710,7 +710,7 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set) for (i = 0; i < set->num_connectors; i++) { DRM_DEBUG_KMS("\t[CONNECTOR:%d:%s] set DPMS on\n", set->connectors[i]->base.id, drm_get_connector_name(set->connectors[i])); - set->connectors[i]->dpms = DRM_MODE_DPMS_ON; + set->connectors[i]->funcs->dpms(set->connectors[i], DRM_MODE_DPMS_ON);