From patchwork Tue May 17 09:13:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Greenhalgh X-Patchwork-Id: 67932 Delivered-To: patch@linaro.org Received: by 10.140.92.199 with SMTP id b65csp1962939qge; Tue, 17 May 2016 02:14:00 -0700 (PDT) X-Received: by 10.66.136.41 with SMTP id px9mr284571pab.80.1463476440175; Tue, 17 May 2016 02:14:00 -0700 (PDT) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id o6si3330936pac.147.2016.05.17.02.13.59 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 May 2016 02:14:00 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-427438-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org; spf=pass (google.com: domain of gcc-patches-return-427438-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-427438-patch=linaro.org@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version:content-type; q=dns; s=default; b=sunbELlpnONdIjUeeRPPiit8JLFFlMVbVoE+dR26AvWkptSqrD yq3vjYTZ/dXKv9/J83au1SG26pE053LHc7JXkUiYhuhC67o395ntFov1n6ZzJ1HR qrZpo1SoJoDjyDzb930mEZQsAVnAvBKERzAWnHZFPEfhgz0/xeuFm/CwQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version:content-type; s= default; bh=I+ssMhQJU+jSzXBqM+Ulu7XW8kE=; b=lfilXOEzzrTQ0APoWWI9 OokZzv48sTkSwok9ZH0J7Vs1mqHTXZXLBiT+/RAPCy+1XmFgVdlDSbDGF/78tLEF PO5me5SNQ6R/PrjBJNLdVdwhzH3beBgimNeig3gEo1FRHPX3SosCui+ZvJr6BRTN P8wFzpFXzZcaGW5sr81qu9A= Received: (qmail 31989 invoked by alias); 17 May 2016 09:13:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 31926 invoked by uid 89); 17 May 2016 09:13:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 spammy=elfos.h, elfosh, UD:elfos.h, Hx-languages-length:1512 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 May 2016 09:13:35 +0000 Received: from emea01-db3-obe.outbound.protection.outlook.com (mail-db3lrp0080.outbound.protection.outlook.com [213.199.154.80]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-3-OFxQG-0XRWSxsyX4TiZF5g-1; Tue, 17 May 2016 10:13:31 +0100 Received: from DB5PR08CA0015.eurprd08.prod.outlook.com (2a01:111:e400:52c3::25) by AM3PR08MB0231.eurprd08.prod.outlook.com (2a01:111:e400:8852::16) with Microsoft SMTP Server (TLS) id 15.1.497.12; Tue, 17 May 2016 09:13:30 +0000 Received: from AM1FFO11FD039.protection.gbl (2a01:111:f400:7e00::152) by DB5PR08CA0015.outlook.office365.com (2a01:111:e400:52c3::25) with Microsoft SMTP Server (TLS) id 15.1.497.12 via Frontend Transport; Tue, 17 May 2016 09:13:29 +0000 Received: from nebula.arm.com (217.140.96.140) by AM1FFO11FD039.mail.protection.outlook.com (10.174.64.228) with Microsoft SMTP Server (TLS) id 15.1.497.8 via Frontend Transport; Tue, 17 May 2016 09:13:29 +0000 Received: from e107456-lin.cambridge.arm.com (10.1.2.79) by mail.arm.com (10.1.105.66) with Microsoft SMTP Server id 14.3.279.2; Tue, 17 May 2016 10:13:27 +0100 From: James Greenhalgh To: CC: , , Subject: [Patch AArch64] Delete ASM_OUTPUT_DEF and fallback to default .set directive Date: Tue, 17 May 2016 10:13:26 +0100 Message-ID: <1463476406-839-1-git-send-email-james.greenhalgh@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:217.140.96.140; IPV:CAL; SCL:-1; CTRY:GB; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(438002)(377424004)(189002)(199003)(92566002)(5008740100001)(4326007)(586003)(11100500001)(229853001)(512874002)(4610100001)(19580395003)(19580405001)(33646002)(568964002)(104016004)(5003600100002)(5890100001)(2476003)(50226002)(1220700001)(6806005)(189998001)(2906002)(84326002)(8936002)(5000100001)(450100001)(106466001)(86362001)(110136002)(77096005)(8676002)(50986999)(15975445007)(2351001)(87936001)(36756003)(142923001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR08MB0231; H:nebula.arm.com; FPR:; SPF:Pass; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; AM1FFO11FD039; 1:gMznhBMjcZS2rNuN5EjL24gduyzkSqvnIQYYpo9JdUXV30QwLsh2K9sZvWy7jNZp/LV+OCOmPp1QVNpSMQhbRvuRRgw/Dmp0ooYKRCRVtsKh2ngx9PIQw0B8l2SuFoj9NY7uVL7UZfUZsOLFLbnuGiiovqaUREXLYjMHyw0bXiiGs0+zQLA1i+JXS8nYcGX8zCL7cIWpTBTlnEnJT9xRmDIvd2SLW5mA1Yg+SGX7voxH0QbfW8eV3tYPTIChQ6PLCavT3sxt7AK/s1fx+rhbHy4S3gPAtLeU7Ynz62zVFspBU4esnS/b3g4WxYNISEk1G1IfJNBa37/DakhKWXWOdGLXT98lW461TYVx3RWM3llWnoXgIxgZWZBEQOfltqMEeRkbDzZ2bP/8S/Zk3vVvpS20Nd+WEngbZI+pH3UkpXqmh6asTwkTZrtEuwJtcG3B0qrpGjfV32Xmx0xTswGCQcgGrxT+Df4qjIbExSrmhtcTRoEFX8qhpl2s+Jb20/qO X-MS-Office365-Filtering-Correlation-Id: 1ae04d17-bac1-4372-4c90-08d37e3382eb X-Microsoft-Exchange-Diagnostics: 1; AM3PR08MB0231; 2:PmnEJNEnGpwbpKsKHD4XEt2D32HvNtdTZbCrvcHTNNckKg8gEEksgPlo+njimGY7nl4+UYeBN29zOhWWHUpHPVbAtOhEExFb/+5w9XjT5gq5akXWlko4AyGfWIgEuE6IPgdf/r2TRg6MwHJbe7MH/hUAO/A0GLEt/rLuIdQ97EJa66suxn1edsnB5W3xyjFI; 3:x5Nld7ygDgFliO94xNOfIOYwdL8okW6h81oaiOQjhy/3fSPSuR1mEb60WhRFU2hKO1dse7FZiwMr6XZsczeTjUzUs4ZC2Q2ffsbScqVBcQ6s3UdRY3FfIt9RW0KhM1A2Mz+bpZlMT0l6K5IOHPEhVlakwAPEDETLFtuCtpKCawtdVo+iVvbE89e5Mg6gWsoTxHPBMKcmeTvON3SCIYQQLRNCSJ+kgfKcu21uFRZYRNgn5YERZrNtRZXp2Ln4t+EnyF3SFn6g8400bwyyGfeETA== X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(8251501002); SRVR:AM3PR08MB0231; X-Microsoft-Exchange-Diagnostics: 1; AM3PR08MB0231; 25:PSBtLzqALzjWHpoK6jilvFK0VKHRpThy1mGUcNdjA8Ltn89qvvw8AS4Cgl0WCaZA+h3uaiR6wfwEuIqV/Y5ZxGKow+rzrea0WZk5RWBkoSzbpgjUnpMszfd6rKBk/z0UJWmSBIVtJTIcark+Vhh5TDjmBD5cA7TELLX7rfhMIjEm/IOy/ohbPTGDSBeA4pfAoC45iw74DjgowN8pCliQkDPPSBcRJqwuHbjHvqFwWh+9GQ4Ngakw7/Rp+ZOfHIh11y2ySqbd5DF5Ph/X2n2dykj5ceIvfAzmDkq3kFYBir0OQ9F3mle1lZy0TjL80AyckhYFQTUBKZnWHOsUzbq2ipeqfKtZiSKX8gCzPOVbHJRqIlGB4Qq8Fu0IvVfGWG+gvfFyBplR9rUr04Nk4jyreGJufYe+DgyYk+dvB6EplLAxdohrpydkKK2zIYPm0wqRiJOJ0xqsOCSsGKEcS7eRFB7Yj8YrM3sHWjwby88/jW9XfjLJMgCAfWQiMleDnyjh; 20:o8nTnjbQITtmqU2dvHtdMkfiemdtK6+ToXrTsifhgvC+dCBDB2Qq1hBXXH2aNTnpjR91ObXvywXCshGQMlr6CpLnR2bqjxK3GoFP2aX2jUn3V/q/MrBJWuJWTXECiCPiMxhsYnJnT/1y38GEJyq5n5qKaiKAusQ8SM6IN4KuAeay7kHcW0PtHpaR10+M55Kn3MlCwKKRV0V/SxMQGaLAlTaXRcmAW4CzUtMV9mRwuBoujan0b7DVSuCgCc2Bm40g NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(102415293)(102615271)(601004)(2401047)(5005006)(8121501046)(13020025)(13023025)(13024025)(13013025)(3002001)(10201501046)(6055026); SRVR:AM3PR08MB0231; BCL:0; PCL:0; RULEID:; SRVR:AM3PR08MB0231; X-Microsoft-Exchange-Diagnostics: 1; AM3PR08MB0231; 4:f34pzQUZMD70u2vk/j+Q1fv3dtDjvFuaYSqgzAY+v80S2LEoTb7EL2bFTAdCeFsU0QwpgOc36KbBIPu19eYLGpov2Yzzju54J9UGEEumhR7I5prIYxw8NbXprRB0/poMLBakv2iltCr8mIDtRuzM3ak8I0gMlPhiQIZXs78frG3G5NiDcPTa8S9iBXmFVINWTMIWWXiBGo48Lr3OCDz+gOVmJ1gC3NSWUkNrODw2DRxs9bg+pggDwYdWU/SUQ8DhHiqaMTcbEQ7rDJYQaJz+vAKKlKuc4zqDqiymyOhQPtkC7w8/zBek/3RqK8OZgrQ84qakf40KpcYOgK0aCKKQjTj1h2Clq8414w/1AYjIBXfuXBM5/753heVArbUehnHlS/N01wRCWiv7/Dos1jhk52tsIbJcALgSJ858I25vFU3njxb7phmhGowhpyOBoFka8PCVGOEyrGPMiD9oDadr5eZmM08KI8K14sj1IfJJzHb5EAA8eC5d0m5nRV37rm+E X-Forefront-PRVS: 0945B0CC72 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM3PR08MB0231; 23:eHj1MPtNmz/+SY/8/l2pA1WMkLuUjYwbM0+gTf1dK?= =?us-ascii?Q?IHKw/LAL32RBHRUGKO2REGMFKNh2JfKFoFG214D6zpvJjd6RPEO7YmnQuDfx?= =?us-ascii?Q?ZbgCjILZTw/eu6DYa4mIB9M3GPRwAbcJNE8s5pztrKMsxe8QnfPWLdWbGwuH?= =?us-ascii?Q?TMetENRckiDiOQdF1dQynmdiSMLkNcgdShzoo/ukR5yIwjOxmCB/2w4WvKNh?= =?us-ascii?Q?NZKHkYTrOTkjFc/PoSIrAg48vbb90ooUd2xYATJ0hQnm+7JUv3Ar54C3AAJq?= =?us-ascii?Q?ZbjnNSv6H4/QlTa7dXmU9Ocw/TmMDQQnUWyhkh6g91jYmQBz/IRpGYtVslIL?= =?us-ascii?Q?8iCUPN9BWfzb/PmPuw/Dj6dN7orCuZprT0KOY913SR425bIyCHO3KmLNy1Yb?= =?us-ascii?Q?St5qprJ8FW1BBwZHSeWdfAAl/o81gv/zdAUYiuauTZFkLOi7ksMxqPGdSJ+F?= =?us-ascii?Q?+Xlt6n37t3ArJbVn+/ScHyf6S9+40TB3z7vAZoqIPtdRDDt5bCO/kqaCC+c2?= =?us-ascii?Q?xDpwLTwQz4QDOuMc9SoRHPz5/TttVlYsNz5E9GV6UHig3bYHHEWXbDsGFPQn?= =?us-ascii?Q?QHAlU6YEl/41VlGbGwsADWrTooLBlPndad+1d/NggI6nhBuE7PkP7c7Udw6i?= =?us-ascii?Q?8RfyT5sJ1E5OWnGl4vyeH61v94doPg3pAXKkPDNXGh5P9j83Tpr/U+bbdY/K?= =?us-ascii?Q?rIPJeuDjFpYJv2K533RmeXcLVdGjpiE6RIZVZ1fO9AALtqD8pTDKkyM35wwF?= =?us-ascii?Q?otagCwosnsP8kYM9qEPHHhZ+PLoIgyVvVwf9wwg8Le4OA3VccefaO8FZ6ND5?= =?us-ascii?Q?Hzl9yk/X3EpMbR0ytPLnHPu2NFVgm5BioC0FuZUHV704c/In4Mf0sqwMQ2Mu?= =?us-ascii?Q?a1/ZtmhluyaHXSNnV6MwlEizjQMKpNMlQS69IMawvEeT+H6DflwGb5FGCpkN?= =?us-ascii?Q?US0QXftMfVjBqe6qYmLxzourrfbltRPSIlhAOpf9ovFp4gNDf8+M4hkBQ7WF?= =?us-ascii?Q?DLjmomApKTCAuXCiZy7si3BmxnQc1Ftn6B6UwS/EFw6+fZmjKMW60ZyE1JvJ?= =?us-ascii?Q?UkbRjGC9b5qSMhZ/za5scUEqUKy42UxeNQqBJTUmrszyqZPXTOOhXbDiKIRO?= =?us-ascii?Q?HI0a/V4AWw=3D?= X-Microsoft-Exchange-Diagnostics: 1; AM3PR08MB0231; 5:sdbtlztQ7QIMsz8fZuaFjs9zKCzA9AqTMzccGKJt276oOV2Nfx3daC9/70t+hJB09KHz8GHefHhJr0WWtbuwatuEnnKdPwW9Kj8KGRlBooQJ9CA9oM3o1qnsDJhl3oVtIV8zgZG7Uf5oE9lc+d0pMw==; 24:Bxd33sQzQhgvhFG2cPwp7ZpMwFKsQ+cBTfZI2p0Lve7GZNbhAZ5eJL9AyFPjdvq72tCVQd3vXV/daA20BFLMAXIdVeTaOFQWtc74Qq7iq+Q=; 7:HlptuFE9W39/kQEZVumF7cK7QdRy3LWj7VOSG/ANlw2EfU3PoJp9fXEpBp4/AuCSLTVIMO7eK7Xx2H4U6cIlLOEZCxZP6gf8QNHFBIecOV6vVU8X3jznAaj9meJtIaOFlWBkyl8weQE1XtT97Fo4aGHJQ8FhhN2ACBaNhlkP2HOTfdt4Rf1nOLe+8gjObgbz; 20:66GoO/8WCHXV9qNt2fl8BNYFl+AcLNJtFrGwruB2/KgCj7o70OxDMWfEClQtuSS9sykVTh1/w8GccxWuv7rrwgINmlL2g6XQ0XHEn+AQ7hhWmOmG1vQJK02zMCbd2H4+0Py92/DnIHnS9My21MOVsWe7Hi1sHscT33hfjUkhJcM= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2016 09:13:29.1922 (UTC) X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[217.140.96.140]; Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0231 X-MC-Unique: OFxQG-0XRWSxsyX4TiZF5g-1 X-IsSubscribed: yes Hi, As in the ARM port [1] , the AArch64 port wants to put out "b = a" to set an alias. This doesn't cause us any trouble yet, as the AArch64 port doesn't warn for this construct - but at the same time there is no reason for us not to put out a .set directive - this seems to have been copied from the ARM port when section anchor support was added in 2012. Looking through the chain, we'll get a default definition for ASM_OUTPUT_DEF if SET_ASM_OP is defined, and we get SET_ASM_OP defined through config/elfos.h for all the AArch64 targets I can see in config.gcc. So we're safe to drop this. Bootstrapped on aarch64-none-linux-gnu. OK? Thanks, James [1]: https://gcc.gnu.org/ml/gcc-patches/2016-03/msg01691.html --- 2016-05-17 James Greenhalgh * config/aarch64/aarch64-elf.h (ASM_OUTPUT_DEF): Delete. diff --git a/gcc/config/aarch64/aarch64-elf.h b/gcc/config/aarch64/aarch64-elf.h index 66c0bb2..1fbee6f 100644 --- a/gcc/config/aarch64/aarch64-elf.h +++ b/gcc/config/aarch64/aarch64-elf.h @@ -25,15 +25,6 @@ #define ASM_OUTPUT_LABELREF(FILE, NAME) \ aarch64_asm_output_labelref (FILE, NAME) -#define ASM_OUTPUT_DEF(FILE, NAME1, NAME2) \ - do \ - { \ - assemble_name (FILE, NAME1); \ - fputs (" = ", FILE); \ - assemble_name (FILE, NAME2); \ - fputc ('\n', FILE); \ - } while (0) - #define TEXT_SECTION_ASM_OP "\t.text" #define DATA_SECTION_ASM_OP "\t.data" #define BSS_SECTION_ASM_OP "\t.bss"