From patchwork Tue Nov 1 13:58:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Greenhalgh X-Patchwork-Id: 80351 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp643515qge; Tue, 1 Nov 2016 06:59:40 -0700 (PDT) X-Received: by 10.99.50.67 with SMTP id y64mr15899855pgy.146.1478008780762; Tue, 01 Nov 2016 06:59:40 -0700 (PDT) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id b4si30715124pge.46.2016.11.01.06.59.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Nov 2016 06:59:40 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-440037-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org; spf=pass (google.com: domain of gcc-patches-return-440037-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-440037-patch=linaro.org@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version:content-type; q=dns; s=default; b=wii4ILBAy6SJGdlQZAat8PN39OpfPZwZhvlK4U6Ydb2c8duUSe 72rxI6Hojc5EbfptmRMzK5mMCdfYX1gRoFsRKPBXJyv5hz9nVuT2cY7dNwQzMre4 RAwUoDEcHpXLmY2Jx4P4VwzG4u/y1m7yFg13pkH+XGfy2g/vFZSKgNxGs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version:content-type; s= default; bh=xMI8eN/5OXVs8J3tUftypod6j9k=; b=LbhR6kBqI3M/mtG8+U9a wXV9Iks1J4GiAycysXh5mhjjKVL7SPw6TebWrb38D1MYs1kMdquITbQeiaEQ34Da wCBEMkKFjNAknJmKZnpfGGgksCWCrzl6CV1W4LrlJVo5+Sv/LUuQQOZWZv6wqyYq MqPtCJ3nDn71dIMPijZjihQ= Received: (qmail 44845 invoked by alias); 1 Nov 2016 13:59:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 44834 invoked by uid 89); 1 Nov 2016 13:59:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.0 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, UNSUBSCRIBE_BODY autolearn=no version=3.3.2 spammy=HX-HELO:sk:EUR01-V, HX-MS-Exchange-CrossTenant-OriginalArrivalTime:Nov, james.greenhalgh@arm.com, sk:james.g X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0053.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Nov 2016 13:59:16 +0000 Received: from HE1PR08CA0013.eurprd08.prod.outlook.com (10.161.112.23) by HE1PR08MB0443.eurprd08.prod.outlook.com (10.161.120.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.693.12; Tue, 1 Nov 2016 13:59:13 +0000 Received: from AM1FFO11FD050.protection.gbl (2a01:111:f400:7e00::167) by HE1PR08CA0013.outlook.office365.com (2a01:111:e400:5097::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.693.12 via Frontend Transport; Tue, 1 Nov 2016 13:59:12 +0000 Authentication-Results: spf=pass (sender IP is 217.140.96.140) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=none (message not signed) header.d=none; gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 217.140.96.140 as permitted sender) receiver=protection.outlook.com; client-ip=217.140.96.140; helo=nebula.arm.com; Received: from nebula.arm.com (217.140.96.140) by AM1FFO11FD050.mail.protection.outlook.com (10.174.65.213) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.693.6 via Frontend Transport; Tue, 1 Nov 2016 13:59:11 +0000 Received: from e107456-lin.cambridge.arm.com (10.1.2.79) by mail.arm.com (10.1.105.66) with Microsoft SMTP Server id 14.3.294.0; Tue, 1 Nov 2016 13:58:45 +0000 From: James Greenhalgh To: CC: , , Subject: [Patch AArch64] aarch64-c.o should depend on TARGET_H Date: Tue, 1 Nov 2016 13:58:44 +0000 Message-ID: <1478008724-34066-1-git-send-email-james.greenhalgh@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:217.140.96.140; IPV:CAL; SCL:-1; CTRY:GB; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(199003)(377424004)(189002)(86362001)(229853001)(626004)(4610100001)(77096005)(7846002)(2351001)(87936001)(4326007)(26826002)(5890100001)(36756003)(189998001)(586003)(104016004)(50986999)(6916009)(19580395003)(19580405001)(5000100001)(5660300001)(50226002)(305945005)(2906002)(512874002)(8936002)(450100001)(568964002)(2476003)(33646002)(110136003)(356003)(246002)(84326002)(106466001)(8676002)(92566002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR08MB0443; H:nebula.arm.com; FPR:; SPF:Pass; PTR:fw-tnat.cambridge.arm.com; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; AM1FFO11FD050; 1:HViVOvja8xKZeiwkrFRAsx21Wkm3fUDld/Kxxa3gXJ6O88npGQBOnLwP9sEeqYK+BqrnRTBDdTIkErBVuQ2eUb504wunG4Jn176VFgZJjf70idlIfsiQqQmW/NsjBgGaosncegGOp2J60B7OkxBUgGiAh1sZaSE/2cyWOdNw6ctgO/T+93oAofC70WZKnBXT/E9qk4XRiaoqgsVSDngodi0q2wFWaXJOsNg942pea97oYKHp8/pQXtnggb58fWdIvGVTbYLOeC+dGC1tXyfxS8tzMgntQ2MUkt9LXFUY6mQFXM/cEAZWy2ODipgnz11Qi9yE/c4Ar+K90NiqC6ASjTmPVmkSI3BIKY2oWFEXXJUFN/4g+B45NIRJ5/1yo53vIpqZ/O5nEs9udwaKwWqnJeRRoWHNCSZC9kQcoOQ8fh60yx7Z7VPxkkziTfenQxX7kNHIfrOCPWrJAboVoH1nFhb0/ZT7gMZeeJJblo9YHi+7cNTlUIpri8Gd2R2ioE+H5FkF0CDqZhwLchuhJ7OYa4iRPrjDlRFRlbb8Wdd9iOXDl5aaFbTnSn3A77g6M+D4ugFpjrybw3FW1VRFFAUGAg== X-MS-Office365-Filtering-Correlation-Id: 7778fb99-3fa4-4e81-f8a9-08d4025f4207 X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB0443; 2:PotU7ZXC0Xu6t3aC8peALT0//AAvPjJFm+hEoXhLWo6gHX4YmlRJucIp+Bja5pBBv7vV/VJK/SDuIC4pb2KaweDldchcAJg+SWF9bwIi4HxiFClyu7T5GeEMeV72gcuGGoQ5ScPTwahIo/hZCnh4kzBnQYE63gYZY6kfbun2VW9hwnwfhQhv0PfaxYWuBAruCGFml9rEglfM5w2EDn1IpA==; 3:5Hf8zjQGSMedMpKnKvM5jw8TAAMHh9znxyS1ZZOYBjI4apJS8GqZtIMNaZI1EK+hKXjrZWiIxpJO4GhZq81IkxqttrQqWl1wmvZhNKra3rbnvtHeZOKffnGzaiI8tzWmQm9v449mR6baLmKZa+/CBrc+ODXyYyQm5KNO/njnA4z1pQcp42EjWx8kIFn77zR/47DVbedgLS++W4CzpHGlvw4lPNCzkSP2Zcl1qVar6feR10hbBU2yRQkYB5KMKQOVmgVY366/jAo7lVfDKo0ghE84E/wE4KVqAMNDs5ZG1Qw= X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(8251501002); SRVR:HE1PR08MB0443; X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB0443; 25:GQQaWq9g/BMdhh8tSQVsfmA1RTeeExoFS/CKN4LPYW7LKCTGq6xSY/QgvE26eOTeCZ12TVF0FL9ayLkKgx1MuhkFk/XPvp8I30sAPbiGBrAsqaZOPpZvzr6lIh35zq/WlzHMy6bMElBvWS3M6m5gmg1xjgAotHGQEmjoNJaGcakB6//DedllcVH0h8Vf47wqJ8YJQOcTCtb360RKDGB3AErHFnUOECaiL6U7cK9ujCppeCo3ewHZfD3iYTA/fvEEKOXOLDnTStc71fSZojGEaRorZ1y43J6d7DFOHfduYmPlS8kUsvlYOSYXD3iRSaf1gK/cU7UApTrDbv7Ygsefra/PHOPCE1UHtDuQ2cUvX005qN8YoLUrb1VihmECAoDV+stHXn3T0P+T2ta81yG7HkZT4w3BZOBXzOiwK7jnZiAGoSsuLa09RK4B6VMZw96GoNMjMZSaeBHe1wqvfCNPtqj1RKNqtiwhyD9IWraudgHTLRXB94VmLrDG8+wxUXtvZYkBenvQRk+QbzP8yw38GzYJ1yOsmEwgi/P8PnMc/QH0a+UfOFC9zUxtNKhARJEg46NWlWCZ9IqLr5oDS4rU1UPS3RV0T6xdQtUniypwihLXBNKWZRNpa7sO0YhYo/oUFxbib/yF/oryNp1DXuFNAsPN3IIlFis9tcuvVQkUd/fCRTW0NR/vpLualjDdjZw6Aui5+VNFwY/x/zEdZSehVRPbI4k+/sOMcmu1JYNyMWxgl6qhNzxAcXK9ShOBh00RKEnEtbe8LMEBiKWp2+c5MAbC7X3zBRWku/1hCbWgLBx/budEH/PTSY6wgiWsWQ6fWkX4/Kp9CRzEDcCCS47P2Q1iYrn/evIwJ6B5+KAoCgIqVwMYuk7HUTxtR4jD4tQheyd/Qqbxwo65OAjgxb40J3xRi/nBrE2vaKTsvFlipfw= X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB0443; 31:ErH+gF0VHLnJlc0xpmzU7szAvoX0pk/7rmlLhJZ5L/uNIVLMKUEJigpxkVJMVG1PZNkrwy0k+NR7JAPd8Ajew3YrsvGEa1tBvifSOxy4UZl9S4ZtGrYMXYd+laVg6NGGNcnU8QE1MrfStvq+DcLUuJb9gAQ/xdVSiwdilx4SkquefqtRaDKfBRfG50+8KLjI4mq3MXTgdIh2PMY1WY4yyjPmg32KzXmeSL30JD2O8x3eq1YYGaXxMHZWxeoDI6ERlK45exo5yWVgZy/eQHy+6Fh3JZ7nqlb8aB6GVTZY6mxQqPF+B9fouIk+iG4Zzx6/; 20:BzMf/82v+HDBkmJqUcWb0iuLP1087KrIgNrUOPwN16pihiceqGJiYYH96OtJav06dxVvbug7MXpLxdRQLWMtO2ufgLRT7Z8J32rOxWvhwb4/4kPIY+oCR5Xui9tNEO9KW6s1WkoWauzfc0Eg8PryI7AHYeXQPkcOXaeMe0o5Ci96ZQmKOdbWswzz80N5kCPkwdayK4lJr80LVQFLOQBD/rwZHRcV5fESH3fehVRj25eAiXRXC3/F84k6oZII6Tif NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(102415321)(6040176)(601004)(2401047)(13020025)(8121501046)(5005006)(13013025)(13023025)(13024025)(10201501046)(3002001)(6055026); SRVR:HE1PR08MB0443; BCL:0; PCL:0; RULEID:; SRVR:HE1PR08MB0443; X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB0443; 4:pcm6x2Zu3//+NZSDf+5/Brf2mbNjkJJyFzrlOBTUR1TzLTxlsHaoynPs6tilMLAMiAkQcBY30rcNWokW2fRGr1dz+q+WiXll8R8lS3wHx4aE2dQsyQ9N8uNOLzcJzqw3bES78UmdKZceinzTtJDf8F9o5BE3Mx1n3itpNBaHG4qyWIUNZwZydP8fKftb2P1uNwFUlGIlr+OW4IhNaaBQ/7TKwqZNWzcYQVsNCNdHxURuAuCtwcKIo2lIMa4KES/qtxD8NiREJs7mPaW1eAb3ytHt38sLv+YeRCshF3UHB3lNvos26lSebYssIVXrsuK9E5C2gfnYGzdrLPrzG0mWqXTib0qOix01AJv1T+eghwsZIYIJ2HcQcdajGKWwn2fnsUb9E9TmRVAIW0DFQJjdV18HzDuFaEZC7geeyQ6rG6VOB3pOFE/m6FhFVAXviIGILc86vw5v3aqwTa1iJwjEvvZdP4ZIaaUNNERHKu4sbV3Cdp/fCZEHJz4i2AGaxguUMOko2DU2huyXA4DxMKnNcjntM6uXcBktD3zB7/spqf/yqG2617y8uUMUn+2IByVH X-Forefront-PRVS: 01136D2D90 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR08MB0443; 23:G8TSxz+Xsimv4D2TJqGAUlyT36lm0IUmj5BkT+u1i?= =?us-ascii?Q?M2dtFoi6e4YHkQaaqrjahzPyWthbsUvOys/LIYLs1+pM4TcXZdpgvVNESoPc?= =?us-ascii?Q?a8MWKJCWk6v9sw8rYYLUguUz0NdTcgkd1nU0tJJVIz0m2gZNjuQRx3QPWIiq?= =?us-ascii?Q?glztxH+ADvqpZXhPP4tn8DY83WfknWOUfTcEfxZnegNwm1nXF4E27okI5Zxj?= =?us-ascii?Q?TPOuqBf+2z7HcA6Tjc9d3dDrYo0nl4YAMJBMgi3b0sqU9zotXpA61htyZWg2?= =?us-ascii?Q?GSD0Nf9JT5eVORlxr7J8XZeJzutivAIvg7lBPINcnN/6QuEiKFWaJXuK5bOP?= =?us-ascii?Q?NP+Z65xdZbMGy9lXgmf4bVhuMVCvny//jpGjyAvDw7Kiy9TH2h4hA2MFs/LJ?= =?us-ascii?Q?Hc//mRbh5xGHMnN7RkUkaFnij5XhscZcNR/RLjIMhyTj8kCd9NG/HkNVjO5t?= =?us-ascii?Q?36VjH6ZAG+gpyvc1ORWwkHiReXzsjndV95ByDumzqVpizBiw2o0T72V0U+/2?= =?us-ascii?Q?vOygr73ZPzd01EJmfxJUw4kMpZKSx7UNQGatc+N8wXvpxInJjODuXmb6NWp9?= =?us-ascii?Q?735IReO6kStuVKYT0xhYoZS+w55+nXBiSke/07d+A8J9sGhHz6HMgs8bxnXd?= =?us-ascii?Q?PvnOYHlQHVwoiQrilT145Ry5phW85NVbzwx4D/8vK5x07uHq5OE78AaVI8nE?= =?us-ascii?Q?2OCsLYVlolyxWKlAoS8UhE3AwzoZg3wAWHSZCbRsLFZJ4n4UkF2hdxlTzadv?= =?us-ascii?Q?jLrGfSDhDvgA6PKC87eMI5r9KFCG3Z1ZVIpgiCJZn6fE6JL4G5vynuXV3kq/?= =?us-ascii?Q?K4lc//n+xkJt5OMmWw51FVwEKEuZypZ4x2mTo9yhDEAZMOIdESZn9ozyDN4w?= =?us-ascii?Q?du2RhVI4coO/vp2A7KGTZc+pWSgbvXRz6KZRhv3j/1VZcXqujVVWTP3HMGd9?= =?us-ascii?Q?nHLgau+avOB5AsCwtikYbA4RRHyr5pkZCr46utYSoqY/yqVS/qR7XD91ijho?= =?us-ascii?Q?SIk3u9hdLX7jSdWnj+daz2jCriECCL7M84BtmeukGGcqye2v9O9ZBVfF9Sk4?= =?us-ascii?Q?pNebA7ga1bp9pUFdf1PtpEe2LnaUkKc8nP9xNpWK1k7xyXEKQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB0443; 6:rOBVX8D72IIwg46LsP/L6gEuX1rpRsr4i09WIRYUt3oYMTSVy1fhYnGaGkYdgR0TNfH5VnW/4SaOgNnlsSFYdcZ0w+NWxTkjx9tE95zVUYppvp7upFw1CcIQMZWigALAHUuMEWfBYxTrmayv8uyWc32epH4KcQvq0zkWBK80DslIgtUT6ziIm06YBnCjWlrxctEH6qsTR5DeEcl1gARFCstkuXsAd/92HSHd26YQ0lQULrPMKGwpZyfXLIpynHsDIqoFppugJFemyPndWUKUkO0TK75onZU7/KB67+k2GIdc1fvaTbTh2d0Y4xXQlbUqfFzprakRSFczhwj53JspVnfVviqFHjtHK0KwJNNtTUI=; 5:/JFwdfWmIdlf7L257qehsFEOWcFpqXMZmQ9DpV9VEQz6fZW9xOe649+ZTPO6gIIr+d7xOqkrSF6HhoOtCJDDptvRSTSOeeeJA2FirzcAC3DlgVhoN3WF2eMMbLZRioUlisDWJ/sxPtrqSlVpxkDpyQ==; 24:ZXC24tkHQsyBFX40p5CU+vwG9s6HZoGzMzJA5uvPDyYYXUtDguqyksSLWyocPwhAfFNBXUVHd3gDZgbeZYWRVjf8z2ZPO7enERZCCFe8yw8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB0443; 7:Bq8lyQu+PyinkBlmvnJSyxjjAH9Anj5smiBX05LZoUmRHj2kqLUOiYveP7LjCY/iAmGNF4759GDGrwDzWdmwsUGbsRsPqRm7BoVqiWPaqGnLVuv8fRy+LAUQcxREC9TmWyl9dDUgLwZRqbPBgyprEp7I3k3B1ZtD1XkGjwYECd8INIdgfzHF3j6Gn0yd8Rb9WUHu8H8PJkY2izgU20XzwEXlzJLjLEMvZAN08mxM51FmmxcIDWENa0odWp4IqOVfxoMFzj/FG4uLLHqFmED6vEgBWu11qGDfx6pXkY89I8lNxctEjTMME3Vv2CR6uzFhfuhr7A16FbEwJAeIfquoX0sMEwQF1K0pFq+nGZY+/Ng= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2016 13:59:11.6553 (UTC) X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[217.140.96.140]; Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB0443 X-IsSubscribed: yes Hi, I've noticed that aarch64-c.o doesn't get rebuilt after a change to the target hooks. That leaves it out of sync with the rest of the compiler in incremental builds, which in turn causes this code to write to the wrong memory location: void aarch64_register_pragmas (void) { /* Update pragma hook to allow parsing #pragma GCC target. */ targetm.target_option.pragma_parse = aarch64_pragma_target_parse; } Leaving pragma_parse pointing at the default implementation, and mangling poor innocent targetm.target_option.print (which generally we don't use after the rebuild - else we likely would see it here too). This change adds a dependency on target.h to aarch64-c.o in t-aarch64, which looks correct. Thanks, James --- 2016-11-01 James Greenhalgh * config/aarch64/t-aarch64 (aarch64-c.o): Depend on TARGET_H. diff --git a/gcc/config/aarch64/t-aarch64 b/gcc/config/aarch64/t-aarch64 index 04eb636..b461eb5 100644 --- a/gcc/config/aarch64/t-aarch64 +++ b/gcc/config/aarch64/t-aarch64 @@ -52,7 +52,7 @@ aarch-common.o: $(srcdir)/config/arm/aarch-common.c $(CONFIG_H) $(SYSTEM_H) \ $(srcdir)/config/arm/aarch-common.c aarch64-c.o: $(srcdir)/config/aarch64/aarch64-c.c $(CONFIG_H) $(SYSTEM_H) \ - coretypes.h $(TM_H) $(TREE_H) output.h $(C_COMMON_H) + coretypes.h $(TM_H) $(TREE_H) output.h $(C_COMMON_H) $(TARGET_H) $(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) \ $(srcdir)/config/aarch64/aarch64-c.c