From patchwork Sat Nov 12 20:28:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 81932 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp372396qge; Sat, 12 Nov 2016 12:29:19 -0800 (PST) X-Received: by 10.99.178.6 with SMTP id x6mr55770272pge.63.1478982559431; Sat, 12 Nov 2016 12:29:19 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id a5si16274746pgd.80.2016.11.12.12.29.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Nov 2016 12:29:19 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-441238-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org; spf=pass (google.com: domain of gcc-patches-return-441238-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-441238-patch=linaro.org@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=rTD0mtuAP3e0+pqo8 naXmvIKLGcuRIztTrdSI+8UOv6ced34stNi1YbVwbocCdwQfNbHJ5QQJIXZx8A0A x3hZY0DPYhgUA25uSLEQNGIAwurWvmVPeNFuCwqfUlkrnB6HRfZxu2ADF0vMp4yB 8FIlRgx9x+c5r7KqytYNeqXiWY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=FZ31WzLvguNDRmUFwI3Yeti utn8=; b=CM8bXpoqrb5/rscZdko/W4YWBI+d3aMbo/c14WgbiSTdQIOHMt/CE8m ynKyAQaLb87zv8afmJtIWFLfUO7RiHDa/57ZuJR3MdPZ2s2SNibpIaQwaZc/NHl8 ElrJaK5U4JIOGnX8ZB/piIcKdMQAuTAeqcXEVC2PPs01PhG99Wxk= Received: (qmail 103795 invoked by alias); 12 Nov 2016 20:28:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 103746 invoked by uid 89); 12 Nov 2016 20:28:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=song, Song, 1097, 109, 7 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 12 Nov 2016 20:28:52 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0F7A14E336; Sat, 12 Nov 2016 20:28:51 +0000 (UTC) Received: from localhost (ovpn-116-20.ams2.redhat.com [10.36.116.20]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uACKSnWt022781; Sat, 12 Nov 2016 15:28:50 -0500 Date: Sat, 12 Nov 2016 20:28:48 +0000 From: Jonathan Wakely To: Tim Song Cc: libstdc++@gcc.gnu.org, gcc-patches Subject: Re: [PATCH] Add std::future_error constructor from future_errc Message-ID: <20161112202848.GF21992@redhat.com> References: <20161112033958.GA3703@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.7.1 (2016-10-04) On 12/11/16 02:34 -0500, Tim Song wrote: >On Fri, Nov 11, 2016 at 10:39 PM, Jonathan Wakely wrote: >> making the existing not-required-by-the-standard constructor private. > >> + public: >> + explicit >> + future_error(error_code __ec) >> + : logic_error("std::future_error: " + __ec.message()), _M_code(__ec)+ { } > >That doesn't look private to me... Whoops, fixed by this patch. Tested powerpc64le-linux, committed to trunk. commit 889e7308ad2c7072326698cc76b902d0cb189b6a Author: Jonathan Wakely Date: Sat Nov 12 18:08:06 2016 +0000 * include/std/future (future_error): Fix public typo to private. diff --git a/libstdc++-v3/include/std/future b/libstdc++-v3/include/std/future index 4d125e8..cb42830 100644 --- a/libstdc++-v3/include/std/future +++ b/libstdc++-v3/include/std/future @@ -109,7 +109,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION const error_code& code() const noexcept { return _M_code; } - public: + private: explicit future_error(error_code __ec) : logic_error("std::future_error: " + __ec.message()), _M_code(__ec)