From patchwork Fri Jan 8 08:35:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sujoy Saraswati X-Patchwork-Id: 59332 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp411777lbb; Fri, 8 Jan 2016 00:36:12 -0800 (PST) X-Received: by 10.66.122.36 with SMTP id lp4mr147336336pab.31.1452242172379; Fri, 08 Jan 2016 00:36:12 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id wa7si14749787pab.206.2016.01.08.00.36.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Jan 2016 00:36:12 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-418452-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-return-418452-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-418452-patch=linaro.org@gcc.gnu.org; dkim=pass header.i=@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; q=dns; s= default; b=TcmXmr/lHHXThCOc9fgrTkM9pt7a4yQvCSNW62KOAddMFf34jyvn4 cVPQCQTqMGfyiz6zAJMPMazNXlVzgyj8EZFYl4kmwEsFI4v1VSqZy5ZYPzrk7zBd 6h78hyIHjU8OGw4rAr0iyhHeBvI3ZA/wI+bjebPvsoRGUk2yVshOHs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s=default; bh=MwNU1Yns04OvUsnSkuitu3FibLM=; b=Ua/mUt0t4g5vBruUODkwpP01JxB6 +dNB4sLnCy+YeHAV6efg/H4mxaD/tqfh8QivNC8dy6LGC14DLJ6Rah3n+Nlz+ciM XDLRVj4dJhwWStJECKxLwKMSwcl3wGcKWmG04Klm+weemmGt7tEF24Cv77gTaG2y mWxF43W8SsFh2JE= Received: (qmail 8679 invoked by alias); 8 Jan 2016 08:35:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 8668 invoked by uid 89); 8 Jan 2016 08:35:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=56, 6, 56, 8, 568, mult X-HELO: g4t3426.houston.hp.com Received: from g4t3426.houston.hp.com (HELO g4t3426.houston.hp.com) (15.201.208.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 08 Jan 2016 08:35:57 +0000 Received: from G9W8455.americas.hpqcorp.net (g9w8455.houston.hp.com [16.216.161.94]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by g4t3426.houston.hp.com (Postfix) with ESMTPS id D911062; Fri, 8 Jan 2016 08:35:55 +0000 (UTC) Received: from G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) by G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) with Microsoft SMTP Server (TLS) id 15.0.1076.9; Fri, 8 Jan 2016 08:35:47 +0000 Received: from G9W3615.americas.hpqcorp.net (16.216.186.50) by G9W8455.americas.hpqcorp.net (16.216.161.94) with Microsoft SMTP Server (TLS) id 15.0.1076.9 via Frontend Transport; Fri, 8 Jan 2016 08:35:47 +0000 Received: from G9W0750.americas.hpqcorp.net ([169.254.9.246]) by G9W3615.americas.hpqcorp.net ([16.216.186.50]) with mapi id 14.03.0169.001; Fri, 8 Jan 2016 08:35:46 +0000 From: "Saraswati, Sujoy (OSTL)" To: Jakub Jelinek CC: Joseph Myers , Sujoy Saraswati , GCC Patches , Richard Biener Subject: RE: Fix 61441 [5/5] Disable various transformations for signaling NaN operands Date: Fri, 8 Jan 2016 08:35:45 +0000 Message-ID: <5379BA8D7E9D7E4D87BF6749A92854C248FEC4D4@G9W0750.americas.hpqcorp.net> References: <5379BA8D7E9D7E4D87BF6749A92854C248FC90F6@G4W3297.americas.hpqcorp.net> <20151231093556.GZ18720@tucnak.redhat.com> <5379BA8D7E9D7E4D87BF6749A92854C248FEBF74@G9W0750.americas.hpqcorp.net> <20160107083214.GC18720@tucnak.redhat.com> In-Reply-To: <20160107083214.GC18720@tucnak.redhat.com> MIME-Version: 1.0 Hi, > If you have access to x86_64-linux, you can easily test it yourself with: > make -C gcc check-gcc RUNTESTFLAGS='--target_board=unix\{-m64,-m32/- > march=i386\} dg.exp=pr61441.c' > > Your patch does help. Thanks, I tested the changes and it worked fine. > issignalling is a GNU extension of glibc, so supposedly you should limit the > test to the targets that use glibc, so either > /* { dg-do run { target { *-*-linux* *-*-gnu* } } } */ > or perhaps specific target-supports.exp test for this (I wonder if android > and/or uclibc support it). I am making the change to limit it to Linux and gnu targets as you mentioned above. The Github for android/uclibc seems to indicate they don't support it. I checked in the changed test case as - Regards, Sujoy Index: gcc/testsuite/gcc.dg/pr61441.c =================================================================== --- gcc/testsuite/gcc.dg/pr61441.c (revision 232151) +++ gcc/testsuite/gcc.dg/pr61441.c (working copy) @@ -1,5 +1,5 @@ -/* { dg-do run } */ -/* { dg-options "-O1 -lm" } */ +/* { dg-do run { target { *-*-linux* *-*-gnu* } } } */ +/* { dg-options "-O1 -lm -fexcess-precision=standard" } */ #define _GNU_SOURCE #include @@ -56,6 +56,8 @@ int main (void) operation(Add); operation(Mult); operation(Div); +#if __FLT_EVAL_METHOD__ == 0 operation(Abs); +#endif return 0; }