From patchwork Sat Jul 12 22:40:22 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kugan Vivekanandarajah X-Patchwork-Id: 33536 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f69.google.com (mail-qa0-f69.google.com [209.85.216.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 0D9BB20CB3 for ; Sat, 12 Jul 2014 22:40:48 +0000 (UTC) Received: by mail-qa0-f69.google.com with SMTP id v10sf9744789qac.0 for ; Sat, 12 Jul 2014 15:40:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:sender :delivered-to:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:x-original-sender :x-original-authentication-results:content-type; bh=pHrluAt+KBKoNU1Hc7EzEgShSCDf+aQYul5hd1DMCos=; b=Jt9NfUH1oQi8Ti7uoEvTLXW0oww8JQQOnEDkqZM6mdx68UF1zvCrIBVsDjTFsyybYy Nq4aoWsPYAaPnVPZuw6CNvrCMOjPjA2/l6CSwrLOzkdgOoohGoqmSSEtAEqY85S3VgNM yUEJtl098ksEi8wUlDx9nA7S1Ak/RZ8I1199Idv6xw4hK7MRCarj4kDG1rgRmTd2gD7G 1tomUqB/od6+KqrD1DUOO2F+ng0/cNRiY+qP2P0sgf4fYQXqKaCLeYPXXC7ulx+I27SI xVxqYcS4BbtKPAlY6Gcswor3gF5fOX9DFjN+qfLXRmc4OobJeYZUGyujfwokZO5TaczL eiFw== X-Gm-Message-State: ALoCoQnXd3hkF6qUhaKEA6moPvLEcSNJN4hPaYzhCbzJWdsgzYPq6kVHhRDMxBVSqP5v/g7c+2Jh X-Received: by 10.236.1.198 with SMTP id 46mr3125816yhd.16.1405204848376; Sat, 12 Jul 2014 15:40:48 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.25.144 with SMTP id 16ls639657qgt.45.gmail; Sat, 12 Jul 2014 15:40:48 -0700 (PDT) X-Received: by 10.220.174.137 with SMTP id t9mr7584714vcz.12.1405204848266; Sat, 12 Jul 2014 15:40:48 -0700 (PDT) Received: from mail-vc0-x22a.google.com (mail-vc0-x22a.google.com [2607:f8b0:400c:c03::22a]) by mx.google.com with ESMTPS id pv20si3910531vdb.48.2014.07.12.15.40.48 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 12 Jul 2014 15:40:48 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2607:f8b0:400c:c03::22a as permitted sender) client-ip=2607:f8b0:400c:c03::22a; Received: by mail-vc0-f170.google.com with SMTP id lf12so886398vcb.1 for ; Sat, 12 Jul 2014 15:40:48 -0700 (PDT) X-Received: by 10.58.114.113 with SMTP id jf17mr2770694veb.20.1405204848156; Sat, 12 Jul 2014 15:40:48 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp29148vcb; Sat, 12 Jul 2014 15:40:47 -0700 (PDT) X-Received: by 10.70.36.7 with SMTP id m7mr7222907pdj.91.1405204845961; Sat, 12 Jul 2014 15:40:45 -0700 (PDT) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id l4si2969720pdo.177.2014.07.12.15.40.45 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Jul 2014 15:40:45 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-372433-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 31493 invoked by alias); 12 Jul 2014 22:40:32 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 31478 invoked by uid 89); 12 Jul 2014 22:40:31 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f49.google.com Received: from mail-pa0-f49.google.com (HELO mail-pa0-f49.google.com) (209.85.220.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 12 Jul 2014 22:40:30 +0000 Received: by mail-pa0-f49.google.com with SMTP id lj1so3305940pab.8 for ; Sat, 12 Jul 2014 15:40:27 -0700 (PDT) X-Received: by 10.70.90.207 with SMTP id by15mr7359802pdb.31.1405204827525; Sat, 12 Jul 2014 15:40:27 -0700 (PDT) Received: from [10.1.1.4] (58-6-183-210.dyn.iinet.net.au. [58.6.183.210]) by mx.google.com with ESMTPSA id cr3sm8299696pdb.43.2014.07.12.15.40.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 12 Jul 2014 15:40:26 -0700 (PDT) Message-ID: <53C1B956.1050407@linaro.org> Date: Sun, 13 Jul 2014 08:40:22 +1000 From: Kugan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Ramana Radhakrishnan , "gcc-patches@gcc.gnu.org" CC: Richard Earnshaw , Jay Foad , Uros Bizjak Subject: Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook References: In-Reply-To: X-IsSubscribed: yes X-Original-Sender: kugan.vivekanandarajah@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2607:f8b0:400c:c03::22a as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@gcc.gnu.org X-Google-Group-Id: 836684582541 > > - if (!TARGET_VFP) > - return; > + if (!TARGET_VFP || TARGET_THUMB1) > + return default_atomic_assign_expand_fenv (hold, clear, update); > > You don't need to call default function here. It is empty, the > documentation says: > > "The default implementation leaves all three expressions as @code{NULL_TREE}." > > Also, the function is declared as void, so returning something looks > strange to me. Thanks for the comment. Here is a patch to change this. There was also a comment from Jay with respect to a cut and paste error that might confuse the readers. I am fixing that as well. regression tested on qemu for arm-none-linux-gnueabi with no new regressions. Please let me know if this is OK? Thanks, Kugan gcc/ 2014-057-12 Kugan Vivekanandarajah * config/arm/arm.c (bdesc_2arg): Fix typo. (arm_atomic_assign_expand_fenv): Remove The default implementation. diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index 78cae73..b84594d 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -24366,8 +24366,8 @@ static const struct builtin_description bdesc_2arg[] = {0, CODE_FOR_##L, "__builtin_arm_"#L, ARM_BUILTIN_##U, \ UNKNOWN, 0}, - FP_BUILTIN (set_fpscr, GET_FPSCR) - FP_BUILTIN (get_fpscr, SET_FPSCR) + FP_BUILTIN (get_fpscr, GET_FPSCR) + FP_BUILTIN (set_fpscr, SET_FPSCR) #undef FP_BUILTIN #define CRC32_BUILTIN(L, U) \ @@ -31582,7 +31582,7 @@ arm_atomic_assign_expand_fenv (tree *hold, tree *clear, tree *update) tree update_call, atomic_feraiseexcept, hold_fnclex; if (!TARGET_VFP || !TARGET_HARD_FLOAT) - return default_atomic_assign_expand_fenv (hold, clear, update); + return; /* Generate the equivalent of : unsigned int fenv_var;