From patchwork Tue Dec 1 11:57:32 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyrylo Tkachov X-Patchwork-Id: 57483 Delivered-To: patch@linaro.org Received: by 10.112.155.196 with SMTP id vy4csp2119601lbb; Tue, 1 Dec 2015 03:57:54 -0800 (PST) X-Received: by 10.98.73.1 with SMTP id w1mr79931009pfa.103.1448971074065; Tue, 01 Dec 2015 03:57:54 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id r20si10317876pfa.51.2015.12.01.03.57.53 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Dec 2015 03:57:54 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-415897-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-return-415897-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-415897-patch=linaro.org@gcc.gnu.org; dkim=pass header.i=@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; q=dns; s= default; b=P0EIvPlMszvN4fZNu5O5RTepd4dC102C9Jodx/TBdiO5VCln8K+Bb 54Ec7pw/E1jc6ZsEsPptJMOtj0ZEhdRaGGr3a4RlHBhlRDpK/HU4u/vU5sLM7LIP CAXHtGso9wCUGIhih+4Qqy0H2qQkcEhBaazZvP8jGTAOgFArPfb7rc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; s=default; bh=lXr/qJMnoDR1HEnX8UEQM8e0VxM=; b=Pp6w//LTTgQCBtoUvOdGQ1Bm3N3e 0+4hQ4RL6/3jSwYNFvFqOlVUewW9c68lPABp9+QN/bCCWLxFGFbhXpjLnsE72sIU had+QpVLm7qf8hviD8+8E9RpuyY5YQFkfeF/aImgMtFGQBtYPB58+kQTQzG2RYsm l+KK7cJFxOVnVy4= Received: (qmail 128658 invoked by alias); 1 Dec 2015 11:57:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 128619 invoked by uid 89); 1 Dec 2015 11:57:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Dec 2015 11:57:40 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-1-RF75R6M9RnivSxuYsO02Zg-1; Tue, 01 Dec 2015 11:57:32 +0000 Received: from [10.2.206.200] ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 1 Dec 2015 11:57:32 +0000 Message-ID: <565D8B2C.2050501@arm.com> Date: Tue, 01 Dec 2015 11:57:32 +0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Christian Bruel , ramana.radhakrishnan@foss.arm.com CC: "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH, ARM] PR target/68617 Fix armv6 unaligned_access with attribute thumb References: <565D65E3.2060806@st.com> In-Reply-To: <565D65E3.2060806@st.com> X-MC-Unique: RF75R6M9RnivSxuYsO02Zg-1 X-IsSubscribed: yes Hi Christian, On 01/12/15 09:18, Christian Bruel wrote: > Hi, > > This patches fixes the PR my making the unaligned_access flag sensitive to the attribute target, since some armv6 might use unaligned loads depending on the TARGET_32BIT flag. > > OK for stage3 ? > Index: gcc/testsuite/gcc.target/arm/attr-unaligned-load-ice.c =================================================================== --- gcc/testsuite/gcc.target/arm/attr-unaligned-load-ice.c (revision 0) +++ gcc/testsuite/gcc.target/arm/attr-unaligned-load-ice.c (working copy) @@ -0,0 +1,19 @@ +/* PR target/68617 + Verify that unaligned_access is correctly with attribute target. */ +/* { dg-do compile } */ +/* { dg-skip-if "avoid conflicting multilib options" { *-*-* } { "-march=*" } { "-march=armv6" } } */ +/* { dg-options "-Os -mfloat-abi=softfp -mtp=soft" } */ +/* { dg-add-options arm_arch_v6 } */ Do you need the -mtp=soft ? This is ok for trunk. Thanks for picking this up. Kyrill