From patchwork Mon Jan 23 16:52:19 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ramana Radhakrishnan X-Patchwork-Id: 6349 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 458E723E0E for ; Mon, 23 Jan 2012 16:52:23 +0000 (UTC) Received: from mail-bk0-f52.google.com (mail-bk0-f52.google.com [209.85.214.52]) by fiordland.canonical.com (Postfix) with ESMTP id 28942A18627 for ; Mon, 23 Jan 2012 16:52:23 +0000 (UTC) Received: by bkar19 with SMTP id r19so2978987bka.11 for ; Mon, 23 Jan 2012 08:52:23 -0800 (PST) Received: by 10.205.134.129 with SMTP id ic1mr3456221bkc.92.1327337542848; Mon, 23 Jan 2012 08:52:22 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.204.130.220 with SMTP id u28cs77671bks; Mon, 23 Jan 2012 08:52:22 -0800 (PST) Received: by 10.182.182.65 with SMTP id ec1mr8539884obc.6.1327337540298; Mon, 23 Jan 2012 08:52:20 -0800 (PST) Received: from mail-tul01m020-f178.google.com (mail-tul01m020-f178.google.com [209.85.214.178]) by mx.google.com with ESMTPS id b4si3326310obo.124.2012.01.23.08.52.19 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 23 Jan 2012 08:52:20 -0800 (PST) Received-SPF: neutral (google.com: 209.85.214.178 is neither permitted nor denied by best guess record for domain of ramana.radhakrishnan@linaro.org) client-ip=209.85.214.178; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.214.178 is neither permitted nor denied by best guess record for domain of ramana.radhakrishnan@linaro.org) smtp.mail=ramana.radhakrishnan@linaro.org Received: by obbwc7 with SMTP id wc7so4448446obb.37 for ; Mon, 23 Jan 2012 08:52:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.38.70 with SMTP id e6mr8572515obk.13.1327337539759; Mon, 23 Jan 2012 08:52:19 -0800 (PST) Received: by 10.182.88.7 with HTTP; Mon, 23 Jan 2012 08:52:19 -0800 (PST) In-Reply-To: <20120123091556.GF18768@tyan-ft48-01.lab.bos.redhat.com> References: <20120123091556.GF18768@tyan-ft48-01.lab.bos.redhat.com> Date: Mon, 23 Jan 2012 16:52:19 +0000 Message-ID: Subject: Re: [Patch testsuite] Fix vec_interleave and vec_extract_even_odd to fall back to vec_perm From: Ramana Radhakrishnan To: Jakub Jelinek Cc: gcc-patches , Patch Tracking X-Gm-Message-State: ALoCoQn/4Y0okEj41syyUSc2HJ9BIT1PNEUTfWi9YZDUdJGhMXFysyNZ1KQuY1yUBMuQ/noK8LT3 On 23 January 2012 09:15, Jakub Jelinek wrote: > On Mon, Jan 23, 2012 at 08:30:46AM +0000, Ramana Radhakrishnan wrote: >> Now that we have vec_perm support, vec_interleave and >> vec_extract_even_odd should fall out from that rather than having to >> handle an additional target in each of these. This fixes >> gcc.dg/vect/slp-11a.c for ARM Neon testing with no other regressions >> in gcc.dg/vect >> >> Ok ? > > That will disable ia64 testing of tests that need vect_extract_even_odd > and vect_interleave.  Not sure if ia64 has good enough vect_perm > support that it can be enabled there though.  Some targets might be > supporting only a couple of specific permutations like these two > and not general permutations. > So safer would be to add [is-effective-target arm_neon_ok] to these > two checks for now. Right ok - Sorry I missed ia64 when I looked at those routines. This is what I committed in the end . cheers Ramana 2012-01-23 Ramana Radhakrishnan * lib/target-supports.exp (check_effective_target_vect_extract_even_odd): Handle ARM neon. (check_effective_target_vect_interleave): Likewise. diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index be33407a..2747089 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -3480,6 +3480,7 @@ proc check_effective_target_vect_extract_even_odd { } { } else { set et_vect_extract_even_odd_saved 0 if { [istarget powerpc*-*-*] + || [is-effective-target arm_neon_ok] || [istarget i?86-*-*] || [istarget x86_64-*-*] || [istarget ia64-*-*] @@ -3502,6 +3503,7 @@ proc check_effective_target_vect_interleave { } { } else { set et_vect_interleave_saved 0 if { [istarget powerpc*-*-*] + || [is-effective-target arm_neon_ok] || [istarget i?86-*-*] || [istarget x86_64-*-*] || [istarget ia64-*-*]