From patchwork Wed Nov 11 12:08:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charles Baylis X-Patchwork-Id: 56376 Delivered-To: patch@linaro.org Received: by 10.112.155.196 with SMTP id vy4csp1321394lbb; Wed, 11 Nov 2015 04:09:08 -0800 (PST) X-Received: by 10.66.219.228 with SMTP id pr4mr13549745pac.99.1447243748029; Wed, 11 Nov 2015 04:09:08 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id pu2si12410311pac.80.2015.11.11.04.09.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Nov 2015 04:09:08 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-413631-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-return-413631-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-413631-patch=linaro.org@gcc.gnu.org; dkim=pass header.i=@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=D+8ojvBZLyxpYdAwDA v4EZInT3rfbwY5Az8c11uYn8Qv3SZE+uIpUEKnA9y/1pjch9yAmdnvFAv0NlBXTm 8Nfg4Hhp+C+0jId/jBVvIO/w6CWcntM5S5KMZUHpXXbI7XILP8ztdxUlDFDXxSA9 d9sx5p4/5HIllkCfPsPMyy9FY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=bRjhuSoDATHSL0ayl1Ijn1iZ VLs=; b=lCuyujidYZTf2dq1vjVyg9VJ2bDt8+BlzbGbbG1P1kQzWCjQHxQMyE4J jdQEH7eNS0lhRbYTdGpQX5CSpt3XcZD+frogQPuv9zo0/jqaFSv93p2HSVWGX39+ WbCUqgRd64dkVdRc7IS90a8WoqBffk+wTo3SRHxXlpZFlpL/Rj8= Received: (qmail 16601 invoked by alias); 11 Nov 2015 12:08:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 16590 invoked by uid 89); 11 Nov 2015 12:08:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f177.google.com Received: from mail-ob0-f177.google.com (HELO mail-ob0-f177.google.com) (209.85.214.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 11 Nov 2015 12:08:54 +0000 Received: by obbww6 with SMTP id ww6so20454876obb.0 for ; Wed, 11 Nov 2015 04:08:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=PzWqy0Ujs4aoffuj7YUFiUZxoEmrgL6iN7ADQrziKoY=; b=grS5gBtK8kdDRuiby1g1dBuwSct68G1Y0r5cUmPbN2+rm93B9x4W1OEVMqV8xeFTtF i2wXpRfiDFsDc+BopkUmJw06Onmu90Imylvlw+Bh029HHpiXVkHP8Wipb55IqrF/yaA5 eyaxqzkFjkhZWeuQf+Ew/RjZLkxF1So3wFzQyA9U4CtU8ApJ3H8SJWjirVvkrBo9V5MM KFQ4Il2/S6xExdp4iGk+UDcUsBJCp9TP5gvarxo9LIIM1kORAaMbNxS1qgR1ClSyQrcv 7VH9J+w7s63GpS4b0m3s+4IfhjuTLJdyBfPJV5TiAw6D/Si0y6YJ2/lSjXQOwItCT5s7 1PVA== X-Gm-Message-State: ALoCoQmEUboRzIveUmv+PesfXf/HkvbRAUm1bmYnEd5ehF2ALQSjYO1gdfEEgR0ctu35XRRgOlPe MIME-Version: 1.0 X-Received: by 10.60.158.198 with SMTP id ww6mr4718692oeb.1.1447243732380; Wed, 11 Nov 2015 04:08:52 -0800 (PST) Received: by 10.202.215.215 with HTTP; Wed, 11 Nov 2015 04:08:52 -0800 (PST) In-Reply-To: <5643250F.9000000@arm.com> References: <1446942404-11561-1-git-send-email-charles.baylis@linaro.org> <1446942404-11561-6-git-send-email-charles.baylis@linaro.org> <5643250F.9000000@arm.com> Date: Wed, 11 Nov 2015 12:08:52 +0000 Message-ID: Subject: Re: [PATCH 4b/4] [ARM] PR63870 Remove error for invalid lane numbers From: Charles Baylis To: Kyrill Tkachov Cc: Ramana Radhakrishnan , Alan Lawrence , Richard Earnshaw , GCC Patches X-IsSubscribed: yes On 11 November 2015 at 11:22, Kyrill Tkachov wrote: > Hi Charles, > > On 08/11/15 00:26, charles.baylis@linaro.org wrote: >> >> From: Charles Baylis >> >> Charles Baylis >> >> * config/arm/neon.md (neon_vld1_lane): Remove error for >> invalid >> lane number. >> (neon_vst1_lane): Likewise. >> (neon_vld2_lane): Likewise. >> (neon_vst2_lane): Likewise. >> (neon_vld3_lane): Likewise. >> (neon_vst3_lane): Likewise. >> (neon_vld4_lane): Likewise. >> (neon_vst4_lane): Likewise. >> > In this pattern the 'max' variable is now unused, causing a bootstrap > -Werror failure on arm. > I'll test a patch to fix it unless you beat me to it... Thanks for catching this. I have a patch, and have started a bootstrap. Unless you have objections, I'll apply as obvious once the bootstrap is complete later this afternoon. gcc/ChangeLog: 2015-11-11 Charles Baylis * config/arm/neon.md: (neon_vld2_lane): Remove unused max variable. (neon_vst2_lane): Likewise. (neon_vld3_lane): Likewise. (neon_vst3_lane): Likewise. (neon_vld4_lane): Likewise. (neon_vst4_lane): Likewise. >From f111cb543bff0ad8756a0240f8bb1af1f19bbbbb Mon Sep 17 00:00:00 2001 From: Charles Baylis Date: Wed, 11 Nov 2015 11:59:44 +0000 Subject: [PATCH] [ARM] remove unused variable gcc/ChangeLog: 2015-11-11 Charles Baylis * config/arm/neon.md: (neon_vld2_lane): Remove unused max variable. (neon_vst2_lane): Likewise. (neon_vld3_lane): Likewise. (neon_vst3_lane): Likewise. (neon_vld4_lane): Likewise. (neon_vst4_lane): Likewise. Change-Id: Ifed53e2d4c5a581770848cab65cf2e8d1d9039c3 --- gcc/config/arm/neon.md | 6 ------ 1 file changed, 6 deletions(-) diff --git a/gcc/config/arm/neon.md b/gcc/config/arm/neon.md index 119550c..62fb6da 100644 --- a/gcc/config/arm/neon.md +++ b/gcc/config/arm/neon.md @@ -4464,7 +4464,6 @@ if (BYTES_BIG_ENDIAN) "TARGET_NEON" { HOST_WIDE_INT lane = NEON_ENDIAN_LANE_N(mode, INTVAL (operands[3])); - HOST_WIDE_INT max = GET_MODE_NUNITS (mode); int regno = REGNO (operands[0]); rtx ops[4]; ops[0] = gen_rtx_REG (DImode, regno); @@ -4579,7 +4578,6 @@ if (BYTES_BIG_ENDIAN) "TARGET_NEON" { HOST_WIDE_INT lane = NEON_ENDIAN_LANE_N(mode, INTVAL (operands[2])); - HOST_WIDE_INT max = GET_MODE_NUNITS (mode); int regno = REGNO (operands[1]); rtx ops[4]; ops[0] = operands[0]; @@ -4723,7 +4721,6 @@ if (BYTES_BIG_ENDIAN) "TARGET_NEON" { HOST_WIDE_INT lane = NEON_ENDIAN_LANE_N (mode, INTVAL (operands[3])); - HOST_WIDE_INT max = GET_MODE_NUNITS (mode); int regno = REGNO (operands[0]); rtx ops[5]; ops[0] = gen_rtx_REG (DImode, regno); @@ -4895,7 +4892,6 @@ if (BYTES_BIG_ENDIAN) "TARGET_NEON" { HOST_WIDE_INT lane = NEON_ENDIAN_LANE_N(mode, INTVAL (operands[2])); - HOST_WIDE_INT max = GET_MODE_NUNITS (mode); int regno = REGNO (operands[1]); rtx ops[5]; ops[0] = operands[0]; @@ -5045,7 +5041,6 @@ if (BYTES_BIG_ENDIAN) "TARGET_NEON" { HOST_WIDE_INT lane = NEON_ENDIAN_LANE_N(mode, INTVAL (operands[3])); - HOST_WIDE_INT max = GET_MODE_NUNITS (mode); int regno = REGNO (operands[0]); rtx ops[6]; ops[0] = gen_rtx_REG (DImode, regno); @@ -5225,7 +5220,6 @@ if (BYTES_BIG_ENDIAN) "TARGET_NEON" { HOST_WIDE_INT lane = NEON_ENDIAN_LANE_N(mode, INTVAL (operands[2])); - HOST_WIDE_INT max = GET_MODE_NUNITS (mode); int regno = REGNO (operands[1]); rtx ops[6]; ops[0] = operands[0]; -- 1.9.1