From patchwork Tue May 17 12:25:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 67945 Delivered-To: patch@linaro.org Received: by 10.140.92.199 with SMTP id b65csp2042910qge; Tue, 17 May 2016 05:26:25 -0700 (PDT) X-Received: by 10.66.254.1 with SMTP id ae1mr1591697pad.32.1463487985117; Tue, 17 May 2016 05:26:25 -0700 (PDT) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id es13si4347973pad.113.2016.05.17.05.26.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 May 2016 05:26:25 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-427477-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org; spf=pass (google.com: domain of gcc-patches-return-427477-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-427477-patch=linaro.org@gcc.gnu.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=bA/0PUiQtjCEbhnzQ9 qML0VLfbUYSUb2EWxTmLdQ6zHUnqfMUYP2cjuZRlc7nbVcdHeiUYzGChc8RLtKMF Matd9PZ8Jf+H04SuIJABXw48kk5FEkOmnHwKl6BCsYum6zEVQULyz/0X4ZEDRoBt XrVyJgKUhaIk0Lu+IPAiP1P4c= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=ENEQBnBAeKKepPo65kyptYhE tSM=; b=bT3bgX5kUbSBIaUE7H2tmqmXcngY1WV8sOvb2tGUYMrZKAn0tKUAFuMT AGy34QGJbIgXM89oy5l7tK2g1Or/opWI/C8FDsaFv5rJoGMD5L4nDqLYwSPPLFO1 KEb7GAYgVP3zfa82scZsj6NTs9W2o5XXsB+UM7InOK7QhSYNwlY= Received: (qmail 84069 invoked by alias); 17 May 2016 12:26:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 84053 invoked by uid 89); 17 May 2016 12:26:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL, BAYES_00, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:2089, queued X-HELO: mail-qk0-f178.google.com Received: from mail-qk0-f178.google.com (HELO mail-qk0-f178.google.com) (209.85.220.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 17 May 2016 12:25:55 +0000 Received: by mail-qk0-f178.google.com with SMTP id n63so7113188qkf.0 for ; Tue, 17 May 2016 05:25:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=pYbUt1akLPUj2UP9jSeVXA7CS3ihoFs1DrRPIdV0ets=; b=Pmr3jvYFhVFqklvB8fTQkhlVqDbF+O+hL9LiDpX009M9NodXYtjJbmeBVooHTa8VTr hlZM1VpR5YI8PUC10aC7uwjSmXAfnwBioJ6mv2BCCm1QRmC8iqGgx9NCiMqoRgX04avs RfUXc92lvyv31SzrrSVzOynljUXwUopkT35XufsNZx1xZJCFqa+ljaSCSfc/QZ1VE84a ssq89yE9gyRHxzOBNJWOnhwiTrEQnFXFLSJlrsylYl40wZeAVJbHpzB8xqLdoa6q3Mvw i74dx8INvtupJef6q9o18LYgrZxqj/fRVSkcUn3zy/+ZjZ+Yiy7rnDxx5MGu0qkirBkh uX9Q== X-Gm-Message-State: AOPr4FV93GXymFJqXA12krwPFxmUsuj/KBjVEd4KqwRHusBmElTzSV360cogpWleuVu3o+SH6H9uFeJQRFmZ5l9v MIME-Version: 1.0 X-Received: by 10.55.58.77 with SMTP id h74mr991485qka.95.1463487953382; Tue, 17 May 2016 05:25:53 -0700 (PDT) Received: by 10.140.99.73 with HTTP; Tue, 17 May 2016 05:25:53 -0700 (PDT) In-Reply-To: <56FE9479.9080000@foss.arm.com> References: <56FE9479.9080000@foss.arm.com> Date: Tue, 17 May 2016 14:25:53 +0200 Message-ID: Subject: Re: [Patch ARM] Fix PR target/53440 - handle generic thunks better for TARGET_32BIT. From: Christophe Lyon To: Ramana Radhakrishnan Cc: "gcc-patches@gcc.gnu.org" X-IsSubscribed: yes On 1 April 2016 at 17:32, Ramana Radhakrishnan wrote: > I've had this in my tree for a few months now but never got > around to submitting it. > > This partially fixes PR target/53440 atleast in ARM and > Thumb2 state. I haven't yet managed to get my head around > rewriting the Thumb1 support yet. > > Tested on armhf with a bootstrap and regression test > with no regressions. > Hi Ramana, It took me a while to understand why the test was failing on a Thumb1 target despite the dg-skip directive. The problem was that dg-do was after dg-skip. I've checked in the swap, I hope it is "obvious" enough. Christophe. > Queued for stage1 now as it isn't technically a regression. > > regards > Ramana > > > Ramana Radhakrishnan > > PR target/53440 > * config/arm/arm.c (arm32_output_mi_thunk): New. > (arm_output_mi_thunk): Rename to arm_thumb1_mi_thunk. Rework > to split Thumb1 vs TARGET_32BIT functionality. > (arm_thumb1_mi_thunk): New. > > > * g++.dg/inherit/thunk1.C: Support arm / aarch64. Index: gcc/testsuite/ChangeLog =================================================================== --- gcc/testsuite/ChangeLog (revision 236318) +++ gcc/testsuite/ChangeLog (revision 236319) @@ -1,3 +1,7 @@ +2016-05-17 Christophe Lyon + + * g++.dg/inherit/think1.C: Fix dg-do and dg-skip order. + 2016-05-17 Kyrylo Tkachov PR target/70809 Index: gcc/testsuite/g++.dg/inherit/thunk1.C =================================================================== --- gcc/testsuite/g++.dg/inherit/thunk1.C (revision 236318) +++ gcc/testsuite/g++.dg/inherit/thunk1.C (revision 236319) @@ -1,5 +1,5 @@ +// { dg-do run { target arm*-*-* aarch64*-*-* i?86-*-* x86_64-*-* s390*-*-* alpha*-*-* ia64-*-* sparc*-*-* } } // { dg-skip-if "" { arm_thumb1_ok } } -// { dg-do run { target arm*-*-* aarch64*-*-* i?86-*-* x86_64-*-* s390*-*-* alpha*-*-* ia64-*-* sparc*-*-* } } #include