From patchwork Fri Jul 10 11:35:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 51032 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f70.google.com (mail-wg0-f70.google.com [74.125.82.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5279C228E5 for ; Fri, 10 Jul 2015 11:36:05 +0000 (UTC) Received: by wgfk9 with SMTP id k9sf86596982wgf.1 for ; Fri, 10 Jul 2015 04:36:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:sender :delivered-to:mime-version:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-original-sender :x-original-authentication-results; bh=D+P9ScP8Ei1GYSpOp58ZXStoqvmblAwICf7RU146JyE=; b=iyCyXSS+gymLrfc8YzNLjZElfSpbdK3xyt1J+PoFGkBCa3zWLsel0irPMo5itcAO2D MRlMor0HCMTK6EoJDgbvSNSo8elzqw6L+1wSu62UTGONE7MFKZ/xVHI44FZ07Bq43VdG a5n3EKdNM93mDiFMN3QAXhpDjgDOYSYhQZGHUkrE00x60QoyNW0JKqVf0bcJDiG1lAdy H5qjfnTfyHZVGDV1Jq45Gg4SXbqxv31ZfS7TxK6iwjabsG+s6XcfoV65pX7FQhh/8oKB /RIpPM8XJAx83HBnAI6OHgr9VcEHDovcE7uicNXAGOt3Uog44TkXqSH7tYuzn5fPMQ1Y hH2Q== X-Gm-Message-State: ALoCoQn9QYQu7HZ/GxvFoZJmxViVGpiRi2RX0WApl2JNxR6K01Zju0BHWfmI0HRW5BXD/35X0R8k X-Received: by 10.152.22.163 with SMTP id e3mr10611277laf.6.1436528164614; Fri, 10 Jul 2015 04:36:04 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.36.136 with SMTP id q8ls1323631laj.91.gmail; Fri, 10 Jul 2015 04:36:04 -0700 (PDT) X-Received: by 10.112.180.37 with SMTP id dl5mr13208455lbc.108.1436528164468; Fri, 10 Jul 2015 04:36:04 -0700 (PDT) Received: from mail-la0-x234.google.com (mail-la0-x234.google.com. [2a00:1450:4010:c03::234]) by mx.google.com with ESMTPS id kx6si7124031lac.108.2015.07.10.04.36.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Jul 2015 04:36:04 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c03::234 as permitted sender) client-ip=2a00:1450:4010:c03::234; Received: by lagx9 with SMTP id x9so263441077lag.1 for ; Fri, 10 Jul 2015 04:36:04 -0700 (PDT) X-Received: by 10.152.36.102 with SMTP id p6mr19489571laj.19.1436528164348; Fri, 10 Jul 2015 04:36:04 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp1319123lbb; Fri, 10 Jul 2015 04:36:03 -0700 (PDT) X-Received: by 10.70.89.199 with SMTP id bq7mr40662925pdb.168.1436528162532; Fri, 10 Jul 2015 04:36:02 -0700 (PDT) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id r8si14192270pds.154.2015.07.10.04.36.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Jul 2015 04:36:02 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-402610-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 75043 invoked by alias); 10 Jul 2015 11:35:51 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 75034 invoked by uid 89); 10 Jul 2015 11:35:50 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qk0-f171.google.com Received: from mail-qk0-f171.google.com (HELO mail-qk0-f171.google.com) (209.85.220.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 10 Jul 2015 11:35:49 +0000 Received: by qkhu186 with SMTP id u186so204677976qkh.0 for ; Fri, 10 Jul 2015 04:35:47 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.140.165.150 with SMTP id l144mr32307356qhl.99.1436528147161; Fri, 10 Jul 2015 04:35:47 -0700 (PDT) Received: by 10.140.102.164 with HTTP; Fri, 10 Jul 2015 04:35:47 -0700 (PDT) In-Reply-To: <559F6D42.9090901@st.com> References: <1436456373-3369-1-git-send-email-christophe.lyon@linaro.org> <559F6D42.9090901@st.com> Date: Fri, 10 Jul 2015 13:35:47 +0200 Message-ID: Subject: Re: [PATCH] [testsuite] Disable attr_thumb.c test when Thumb mode is not supported. From: Christophe Lyon To: Christian Bruel Cc: "gcc-patches@gcc.gnu.org" X-IsSubscribed: yes X-Original-Sender: christophe.lyon@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c03::234 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@gcc.gnu.org X-Google-Group-Id: 836684582541 On 10 July 2015 at 09:14, Christian Bruel wrote: > > On 07/09/2015 05:39 PM, Christophe Lyon wrote: >> Some multilibs do not support Thumb mode on ARM targets. This is the >> case for instance when target is arm-linux-gnueabihf and with >> -march=armv5-t: Thumb-1 hard-float VFP ABI is not implemented. >> >> In this configuration, gcc.target/arm/attr_thumb.c is failing because >> we switch thumb mode via an attribute. >> >> This patch makes this test unsupported, by adding a new function in >> lib/target-supports.exp: check_effective_target_arm_thumb_ok. >> >> OK? >> > > What about just skip-if { ! { arm_thumb1_ok || arm_thumb2_ok } } , for > consistency with the other tests using -mthumb ? OK, let's be consistent. > Can you add the same check to flip-thumb.c as well (must have been also FAIL > for your configuration) ? Indeed, I noticed it when you added that test, then forgot to merge both fixes. > thanks > > Christian > 2015-07-10 Christophe Lyon * gcc.target/arm/attr_thumb.c: Skip if Thumb is not supported. * gcc.target/arm/flip-thumb.c: Likewise. diff --git a/gcc/testsuite/gcc.target/arm/attr_thumb.c b/gcc/testsuite/gcc.target/arm/attr_thumb.c index 02ddfda..eac4713 100644 --- a/gcc/testsuite/gcc.target/arm/attr_thumb.c +++ b/gcc/testsuite/gcc.target/arm/attr_thumb.c @@ -1,5 +1,7 @@ /* Check that attribute target thumb is recognized. */ /* { dg-do compile } */ +/* Make sure the current multilib supports thumb. */ +/* { dg-skip-if "" { ! { arm_thumb1_ok || arm_thumb2_ok } } } */ /* { dg-options "-O2 -mno-restrict-it" } */ /* { dg-final { scan-assembler-not "\\.arm" } } */ /* { dg-final { scan-assembler "\\.thumb_func" } } */ diff --git a/gcc/testsuite/gcc.target/arm/flip-thumb.c b/gcc/testsuite/gcc.target/arm/flip-thumb.c index 9154799..355d663 100644 --- a/gcc/testsuite/gcc.target/arm/flip-thumb.c +++ b/gcc/testsuite/gcc.target/arm/flip-thumb.c @@ -1,5 +1,7 @@ /* Check -mflip-thumb. */ /* { dg-do compile } */ +/* Make sure the current multilib supports thumb. */ +/* { dg-skip-if "" { ! { arm_thumb1_ok || arm_thumb2_ok } } } */ /* { dg-options "-O2 -mflip-thumb -mno-restrict-it" } */ /* { dg-final { scan-assembler "\\.arm" } } */ /* { dg-final { scan-assembler-times "\\.thumb_func" 1} } */