From patchwork Wed Jun 15 16:44:17 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulrich Weigand X-Patchwork-Id: 1945 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 32E8923DE6 for ; Wed, 15 Jun 2011 16:44:24 +0000 (UTC) Received: from mail-vx0-f180.google.com (mail-vx0-f180.google.com [209.85.220.180]) by fiordland.canonical.com (Postfix) with ESMTP id EE389A18824 for ; Wed, 15 Jun 2011 16:44:23 +0000 (UTC) Received: by vxk12 with SMTP id 12so633055vxk.11 for ; Wed, 15 Jun 2011 09:44:23 -0700 (PDT) Received: by 10.52.98.97 with SMTP id eh1mr366225vdb.7.1308156263332; Wed, 15 Jun 2011 09:44:23 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.52.183.130 with SMTP id em2cs136619vdc; Wed, 15 Jun 2011 09:44:22 -0700 (PDT) Received: by 10.227.202.205 with SMTP id ff13mr826369wbb.102.1308156260717; Wed, 15 Jun 2011 09:44:20 -0700 (PDT) Received: from mtagate4.uk.ibm.com (mtagate4.uk.ibm.com [194.196.100.164]) by mx.google.com with ESMTPS id n11si1837175wbh.64.2011.06.15.09.44.20 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 15 Jun 2011 09:44:20 -0700 (PDT) Received-SPF: pass (google.com: domain of uweigand@de.ibm.com designates 194.196.100.164 as permitted sender) client-ip=194.196.100.164; Authentication-Results: mx.google.com; spf=pass (google.com: domain of uweigand@de.ibm.com designates 194.196.100.164 as permitted sender) smtp.mail=uweigand@de.ibm.com Received: from d06nrmr1507.portsmouth.uk.ibm.com (d06nrmr1507.portsmouth.uk.ibm.com [9.149.38.233]) by mtagate4.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p5FGiJSH007842; Wed, 15 Jun 2011 16:44:19 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p5FGiJXb2416730; Wed, 15 Jun 2011 17:44:19 +0100 Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p5FGiI0C018119; Wed, 15 Jun 2011 10:44:19 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p5FGiHYb018103; Wed, 15 Jun 2011 10:44:17 -0600 Message-Id: <201106151644.p5FGiHYb018103@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 15 Jun 2011 18:44:17 +0200 Subject: Re: [rfc/rfa] VFP/NEON register set support for ARM core files To: amodra@gmail.com (Alan Modra) Date: Wed, 15 Jun 2011 18:44:17 +0200 (CEST) From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, binutils@sourceware.org, patches@linaro.org, dave.martin@linaro.org, will.deacon@arm.com In-Reply-To: <20110406030027.GL19002@bubble.grove.modra.org> from "Alan Modra" at Apr 06, 2011 12:30:27 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Alan Modra wrote: > On Tue, Apr 05, 2011 at 08:50:14PM +0200, Ulrich Weigand wrote: > > * elf-bfd.h (elfcore_write_arm_vfp): Add prototype. > > * elf.c (elfcore_grok_arm_vfp): New function. > > (elfcore_grok_note): Call it to handle NT_ARM_VFP notes. > > (elfcore_write_arm_vfp): New function. > > (elfcore_write_register_note): Call it to handle .reg-arm-vfp. > > Looks OK to me. The kernel parts have now been accepted (and will be available with 3.0), so I've committed the binutils and gbd parts as well. Note that I had originally forgotten to update readelf to properly display the new note type; the version I've committed includes this part as well (see additional patch below). Thanks, Ulrich ChangeLog: binutils/ * readelf.c (get_note_type): Handle NT_ARM_VFP. Index: binutils/readelf.c =================================================================== RCS file: /cvs/src/src/binutils/readelf.c,v retrieving revision 1.547 diff -u -p -r1.547 readelf.c --- binutils/readelf.c 13 Jun 2011 15:18:53 -0000 1.547 +++ binutils/readelf.c 15 Jun 2011 15:00:37 -0000 @@ -12284,6 +12284,8 @@ get_note_type (unsigned e_type) return _("NT_S390_CTRS (s390 control registers)"); case NT_S390_PREFIX: return _("NT_S390_PREFIX (s390 prefix register)"); + case NT_ARM_VFP: + return _("NT_ARM_VFP (arm VFP registers)"); case NT_PSTATUS: return _("NT_PSTATUS (pstatus structure)"); case NT_FPREGS: