From patchwork Tue Oct 2 02:56:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Doan X-Patchwork-Id: 11900 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 5325223F5A for ; Tue, 2 Oct 2012 02:56:16 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id E13CAA1820D for ; Tue, 2 Oct 2012 02:56:15 +0000 (UTC) Received: by ieje10 with SMTP id e10so13271170iej.11 for ; Mon, 01 Oct 2012 19:56:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf :content-type:mime-version:x-launchpad-project:x-launchpad-branch :x-launchpad-message-rationale:x-launchpad-branch-revision-number :x-launchpad-notification-type:to:from:subject:message-id:date :reply-to:sender:errors-to:precedence:x-generated-by :x-launchpad-hash:x-gm-message-state; bh=G99iwKFqQJoXVSPoSVZBIBTojyYDLc3NifA8xcPVRRc=; b=nKJLA1Rd8V+j1jr5XsKZXj2gazCfQzXXTh5CVYq+kQYN4IlyF2z800pYg3ZmD0iMis Hv6H6OXfrAWPI/UZN7C9vGyQOZk4CruH0aFPffDLn8RVBg5nfCthgGXcL0Iqv6OPVF+J D6AffHYvARnkH7xdgWy2M3ogqreSmUhw4Vls1TLxZwekJ4xpL1YmHM+mUMm2TXE4gLVP dZRPsNDapAEyRk+Ux4T3tgiAnOuOcQx+8mOiFW8EKy6LUV3AXdFocxXSuG35YytPEP0z qe//mEttRsc3TP0SIg4+Sqo4cEvWhQrkwYsUw9VG3422ag1wTU7XH1WSea+W7R6Ln4+H hg+A== Received: by 10.50.154.137 with SMTP id vo9mr6971236igb.28.1349146575343; Mon, 01 Oct 2012 19:56:15 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp61304igc; Mon, 1 Oct 2012 19:56:14 -0700 (PDT) Received: by 10.180.81.38 with SMTP id w6mr18545615wix.10.1349146573956; Mon, 01 Oct 2012 19:56:13 -0700 (PDT) Received: from indium.canonical.com (indium.canonical.com. [91.189.90.7]) by mx.google.com with ESMTPS id f7si61135wiv.40.2012.10.01.19.56.13 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 01 Oct 2012 19:56:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of bounces@canonical.com designates 91.189.90.7 as permitted sender) client-ip=91.189.90.7; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of bounces@canonical.com designates 91.189.90.7 as permitted sender) smtp.mail=bounces@canonical.com Received: from ackee.canonical.com ([91.189.89.26]) by indium.canonical.com with esmtp (Exim 4.71 #1 (Debian)) id 1TIseb-0006vt-5f for ; Tue, 02 Oct 2012 02:56:13 +0000 Received: from ackee.canonical.com (localhost [127.0.0.1]) by ackee.canonical.com (Postfix) with ESMTP id 19B6DE03B5 for ; Tue, 2 Oct 2012 02:56:13 +0000 (UTC) MIME-Version: 1.0 X-Launchpad-Project: lava-dispatcher X-Launchpad-Branch: ~linaro-validation/lava-dispatcher/trunk X-Launchpad-Message-Rationale: Subscriber X-Launchpad-Branch-Revision-Number: 395 X-Launchpad-Notification-Type: branch-revision To: Linaro Patch Tracker From: noreply@launchpad.net Subject: [Branch ~linaro-validation/lava-dispatcher/trunk] Rev 395: workaround bug in python's tarfile implementation Message-Id: <20121002025613.15015.69212.launchpad@ackee.canonical.com> Date: Tue, 02 Oct 2012 02:56:13 -0000 Reply-To: noreply@launchpad.net Sender: bounces@canonical.com Errors-To: bounces@canonical.com Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="16061"; Instance="launchpad-lazr.conf" X-Launchpad-Hash: 988e13d5c3c73f4f234f5a32dc8f75f0cdd574d5 X-Gm-Message-State: ALoCoQl/5aAFe1DflPSzRer6J8wp8L6JaWyRt8+ksdYUoDMEJgoIYnbW+BzIYq/t/Mq83ilVOLeg ------------------------------------------------------------ revno: 395 committer: Andy Doan branch nick: lava-dispatcher timestamp: Mon 2012-10-01 21:53:01 -0500 message: workaround bug in python's tarfile implementation Our version of python has an issue with unicode filenames in a tarball. We had old code that just shelled out to "tar -xzf" and that seems like the safest bet for the time being. modified: lava_dispatcher/device/master.py --- lp:lava-dispatcher https://code.launchpad.net/~linaro-validation/lava-dispatcher/trunk You are subscribed to branch lp:lava-dispatcher. To unsubscribe from this branch go to https://code.launchpad.net/~linaro-validation/lava-dispatcher/trunk/+edit-subscription === modified file 'lava_dispatcher/device/master.py' --- lava_dispatcher/device/master.py 2012-10-01 19:17:31 +0000 +++ lava_dispatcher/device/master.py 2012-10-02 02:53:01 +0000 @@ -24,7 +24,6 @@ import logging import os import shutil -import tarfile import time import traceback @@ -254,8 +253,7 @@ tfdir = os.path.join(self.scratch_dir, str(time.time())) try: os.mkdir(tfdir) - tar = tarfile.open(tf, 'r:gz') - tar.extractall(tfdir) + logging_system('tar -C %s -xzf %s' % (tfdir, tf)) yield tfdir finally: