From patchwork Thu Oct 6 12:09:13 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zygmunt Krynicki X-Patchwork-Id: 4551 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 2530B23EF8 for ; Thu, 6 Oct 2011 12:14:00 +0000 (UTC) Received: from mail-gx0-f180.google.com (mail-gx0-f180.google.com [209.85.161.180]) by fiordland.canonical.com (Postfix) with ESMTP id CCBB1A18D1B for ; Thu, 6 Oct 2011 12:13:59 +0000 (UTC) Received: by ggni2 with SMTP id i2so2486449ggn.11 for ; Thu, 06 Oct 2011 05:13:59 -0700 (PDT) Received: by 10.223.58.138 with SMTP id g10mr3158840fah.20.1317902957348; Thu, 06 Oct 2011 05:09:17 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.152.23.170 with SMTP id n10cs126533laf; Thu, 6 Oct 2011 05:09:16 -0700 (PDT) Received: by 10.227.156.70 with SMTP id v6mr913374wbw.27.1317902954363; Thu, 06 Oct 2011 05:09:14 -0700 (PDT) Received: from indium.canonical.com (indium.canonical.com. [91.189.90.7]) by mx.google.com with ESMTPS id ft20si3806171wbb.29.2011.10.06.05.09.13 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 06 Oct 2011 05:09:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of bounces@canonical.com designates 91.189.90.7 as permitted sender) client-ip=91.189.90.7; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of bounces@canonical.com designates 91.189.90.7 as permitted sender) smtp.mail=bounces@canonical.com Received: from ackee.canonical.com ([91.189.89.26]) by indium.canonical.com with esmtp (Exim 4.71 #1 (Debian)) id 1RBmlF-0001OB-Dr for ; Thu, 06 Oct 2011 12:09:13 +0000 Received: from ackee.canonical.com (localhost [127.0.0.1]) by ackee.canonical.com (Postfix) with ESMTP id 602B4E01EF for ; Thu, 6 Oct 2011 12:09:13 +0000 (UTC) MIME-Version: 1.0 X-Launchpad-Project: lava-server X-Launchpad-Branch: ~linaro-validation/lava-server/trunk X-Launchpad-Message-Rationale: Subscriber X-Launchpad-Branch-Revision-Number: 252 X-Launchpad-Notification-Type: branch-revision To: Linaro Patch Tracker From: noreply@launchpad.net Subject: [Branch ~linaro-validation/lava-server/trunk] Rev 252: Fix a few typos/reword a few docstrings Message-Id: <20111006120913.6390.88177.launchpad@ackee.canonical.com> Date: Thu, 06 Oct 2011 12:09:13 -0000 Reply-To: noreply@launchpad.net Sender: bounces@canonical.com Errors-To: bounces@canonical.com Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="14085"; Instance="launchpad-lazr.conf" X-Launchpad-Hash: cd446516728e6ac325254c6a5746d491bfab0836 ------------------------------------------------------------ revno: 252 committer: Zygmunt Krynicki branch nick: trunk timestamp: Thu 2011-10-06 14:00:37 +0200 message: Fix a few typos/reword a few docstrings modified: lava_server/bread_crumbs.py --- lp:lava-server https://code.launchpad.net/~linaro-validation/lava-server/trunk You are subscribed to branch lp:lava-server. To unsubscribe from this branch go to https://code.launchpad.net/~linaro-validation/lava-server/trunk/+edit-subscription === modified file 'lava_server/bread_crumbs.py' --- lava_server/bread_crumbs.py 2011-10-03 14:07:55 +0000 +++ lava_server/bread_crumbs.py 2011-10-06 12:00:37 +0000 @@ -20,12 +20,12 @@ """ Bread crumb management for LAVA server. -This system allows one to construct static trees of views (come to think about -it it could also be used as a site map generator) where each view has at most -one parent. In such model any view could be followed back through the parent -link to create a bread crumb trail of named URLs. +This system allows one to construct static trees of views or even site maps, +where each view has at most one parent. In this model any view could be +followed back through the parent link to create a bread crumb trail of named +URLs. -It is important to emphasise that this system is STATIC, that is, it is not +It is important to emphasize that this system is STATIC, that is, it is not based on browsing history. Regardless on how the user got to a particular view the bread crumb system will report the same set of pages. The idea is not to let users go back (that's the what the browser allows them to do) but to put @@ -39,7 +39,7 @@ passing any of the keyword arguments specified in needs of your and any parent views (yes this is annoying). -A mistake in paring 'needs' to keywords passed to BreadCrumbTrail.leading_to() +A mistake in pairing 'needs' to keywords passed to BreadCrumbTrail.leading_to() will result in logged warnings (either a name of the URL being not constructible). To fix that simply add the missing keyword argument and reload. """ @@ -80,7 +80,7 @@ Call method, used when decorating function-based views Id does not redefine the function (so is not a real decorator) but - instead stores the bradcrubm object in the _bread_crumb attribute of + instead stores the brad crumb object in the _bread_crumb attribute of the function. """ self.view = view @@ -91,7 +91,7 @@ """ Get the name of this crumb. - The name is formatted with the specfied keyword argments. + The name is formatted with the specified keyword arguments. """ try: return self.name.format(**kwargs) @@ -103,7 +103,7 @@ """ Get the URL of this crumb. - The URL is constructed with a call to dajngo's reverse() function. It + The URL is constructed with a call to Dajngo's reverse() function. It is supplemented with the same variables that were listed in needs array in the bread crumb constructor. The arguments are passed in order, from the kwargs dictionary.