From patchwork Mon Mar 21 15:13:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 64113 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp1463307lbc; Mon, 21 Mar 2016 08:13:52 -0700 (PDT) X-Received: by 10.66.142.132 with SMTP id rw4mr45118162pab.26.1458573232101; Mon, 21 Mar 2016 08:13:52 -0700 (PDT) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id 75si5438468pfs.118.2016.03.21.08.13.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Mar 2016 08:13:52 -0700 (PDT) Received-SPF: pass (google.com: domain of libc-alpha-return-68248-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libc-alpha-return-68248-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=libc-alpha-return-68248-patch=linaro.org@sourceware.org; dkim=pass header.i=@sourceware.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; q=dns; s= default; b=yvXrxCEoate8NXfhGbZ9dcZ6Ecf2ni6AYZTo/e5OYpwSrKCk2GQx1 C7D5zQDtpbJLbv/HDyQgPSYM/3gc2+ul1N+wNGJg+NwkMux3TUyJL2mh6iVM6RJM OerZtqEgcDffxqQIzLPj2ZhbrMBLD9Kof59gi674tZURM2HLf8uq/4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; s=default; bh=UBcoMtRSpa8uRt/qCdyuHyojiXU=; b=JPpR7rZuhaslTJPfzzaFLnynUhQH c+FTT5chJZFcJ4asQtuN/iqZbPGtkNRlammTcTyDyZWZ1rBU5zTWPQ6kZ7nGWVeX voWNKFMl6iBrreebmq9eGvxpa/pqiAFMrncTnpzumcA/MurevJwBv31xLJqdKRG4 628tLsb5KF/jlf4= Received: (qmail 68233 invoked by alias); 21 Mar 2016 15:13:33 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 68220 invoked by uid 89); 21 Mar 2016 15:13:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-yw0-f170.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=eZObOCCI2aIpLWxfwsUmSSGO3i57sfboiz3UM657Tkc=; b=BGjDVySRhRuByK3r5Lb7yBDFxQFziT+RbKo1eEDQ/4w3+DAcqkgfdEnLp9KpkYdd1C 87XPDxQz2IC+LnOstMdk4UneyKF+YuslS6Nb9qx28kNf6q3REEmuFHvHIWAuvNbQiaxF OVXH4uZV6qdyGisZD4M+87h98BXXp47q/KI08fXskPCd/cwpiUKkAk1dD2o4b9xRiYYG 7V0a5k5DD3MZK60dLruKfIKbrfNXCatpLTXNj/hRPkTGTKLDSbXYh+AFTytvnAojNYVb j8dkTNsx4wkTBmduwFj2dfoGaDKx09+oueT98/+19/f5F5SViIvDQNpWuA1o/KOOjVhY mR4Q== X-Gm-Message-State: AD7BkJKSgGzwLuiVM7BFJof2JnGxK4lK+f+15vzQ8+JJ0HGRaP0UBbPpdVAZSN1Xn0OYG/RQ X-Received: by 10.13.238.194 with SMTP id x185mr15548371ywe.35.1458573200701; Mon, 21 Mar 2016 08:13:20 -0700 (PDT) From: Adhemerval Zanella X-Google-Original-From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [COMMITTED] [PATCH] posix: Fix posix_spawn implict check style Date: Mon, 21 Mar 2016 12:13:13 -0300 Message-Id: <1458573193-18181-1-git-send-email-adhemerval.zanella@linaro.com> This patch fixes the implicit check style add in 2a69f853c for the general convention one. Checked on x86_64. * sysdeps/unix/sysv/linux/spawni.c (__spawnix): Fix implict checks style. --- ChangeLog | 5 +++++ sysdeps/unix/sysv/linux/spawni.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) -- 1.9.1 diff --git a/sysdeps/unix/sysv/linux/spawni.c b/sysdeps/unix/sysv/linux/spawni.c index cb80cea..ee05de5 100644 --- a/sysdeps/unix/sysv/linux/spawni.c +++ b/sysdeps/unix/sysv/linux/spawni.c @@ -381,7 +381,7 @@ __spawnix (pid_t * pid, const char *file, close_not_cancel (args.pipe[0]); - if (!ec && pid) + if ((ec == 0) && (pid != NULL)) *pid = new_pid; __sigprocmask (SIG_SETMASK, &args.oldmask, 0);