From patchwork Thu Dec 12 18:16:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 181507 Delivered-To: patch@linaro.org Received: by 2002:ac9:44c4:0:0:0:0:0 with SMTP id t4csp1118422och; Thu, 12 Dec 2019 10:17:28 -0800 (PST) X-Google-Smtp-Source: APXvYqy2rZVDHqVjPP/twHcvvE5B/dBl83c9EDby2NU1XF3wHeBzofa29OJfPflZ4LAU9aiHKIM1 X-Received: by 2002:a9d:7393:: with SMTP id j19mr9312188otk.336.1576174648282; Thu, 12 Dec 2019 10:17:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576174648; cv=none; d=google.com; s=arc-20160816; b=D8rBDEjdsNS+EoreGHpSmPnqwMqkfSfWEKS+haAS8ydJFGvW0tpM1QywoTK1l5JyPe 4HcMTg0IkSkWtLBA+qF9JBABrU73rsmuCacFkbkhjxE/IVxgKk1ZlLvHggtNMYnGyd+C 4ZjOc879TVMlz6n74+R6MI1jL7PiSlJu69JB+RhK4yseBBxxeTwaX32Pdv/0MfsWa7ZP q05GLqrU95urb0uu/k44I/eILHcK860HeZ5mzqChitxPrtjLQ/YfRRguqHaGHU56S4QX N3nJ0BPjHriAt2RVoVa97SHflK+cm/6vMjgP4lHQWDGOsMvot1kHGGxR38nsRygoyT3f KWFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:to:from :dkim-signature:delivered-to:sender:list-help:list-post:list-archive :list-subscribe:list-unsubscribe:list-id:precedence:mailing-list :dkim-signature:domainkey-signature; bh=gOXzOviMky7jSLkvY7KfqCXxD+bwH8eAZo8h6YWtCbE=; b=iGZzLKFpnZNlJSw5lLPxVPYDnmgkFyKh082InPs57JT+FW6/U8MVs8TRe3oRqtQnff H55ge0MjAiJBCcnmZI08MwZtniXk/x8a0WaUOB19uUVgBRF8eNVezV2JXe7xNCR05Olb 8JIS49G6eRWNUyGE18hoGd74g09gRi5r1jag7wp4cnzCiF7toSA/lCDjw28zVGpWito7 LZdZ5eV/0U6mqYe/4QUXLlCzStVtOntcbWkwzJ0UixR7W2L1t+8pJLOuq2mqDND0to1c PCazKr3yxT1pkkMKR5VIecn9CvtWdxrufQDqRvse+4uf40ixoxuXY4eqOmhb/3E2poJO KcMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=gAySxwt2; dkim=pass header.i=@linaro.org header.s=google header.b=DOX44jUv; spf=pass (google.com: domain of libc-alpha-return-108019-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-108019-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id v18si3898853oic.27.2019.12.12.10.17.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Dec 2019 10:17:28 -0800 (PST) Received-SPF: pass (google.com: domain of libc-alpha-return-108019-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=gAySxwt2; dkim=pass header.i=@linaro.org header.s=google header.b=DOX44jUv; spf=pass (google.com: domain of libc-alpha-return-108019-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-108019-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=dsdCPZHFDpI3zyFHuSpjXogFkk1cZRa 5seGa65Tn1ggr4oP+7GxdY8p/NwOfbt49P5nt2iuevK/jmzstl4/TdZpRWJ9IDQM BGPpbXIY/48uftrAafiqZwD/p4Gd/Aae3T9z0tecrdaPdgl8MMgO4NPiFr4WklF4 UyMBqYwR8jwc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=EEPjI1DuT5djOl42TqUsxKG4jKc=; b=gAySx wt24t3nubfjAnuwJnvjqC6OtZ8D+jQPOib3Uz75yVooXeVy12385cqqantY1NGcg Exeh2YW7QszWzU3vWR/FX4gbGtxQvBmxYepGfKVU208QVh4392cfvHvgvuoNXX1S GXD78ojCwxRv5OVnjUu6HtrRHb4dEYt+DGw/Zw= Received: (qmail 43997 invoked by alias); 12 Dec 2019 18:16:30 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 43882 invoked by uid 89); 12 Dec 2019 18:16:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=o, sk:shared-, HX-Received:72d0 X-HELO: mail-ua1-f53.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=gOXzOviMky7jSLkvY7KfqCXxD+bwH8eAZo8h6YWtCbE=; b=DOX44jUvGEcBoaNHHOwFY+/MRwxc6S8BwvofgGM0mWGiqCJINgtUEHYrc+Rib1bcp/ A8Ak3gMhDPYbNozI6mDT/MGfjFoHrZu08pjaeiMCi3/uqfQHMPrjtnqcf6py4Hcjz5CV cVJtF9tlJA8TamX631qNaxFEos8uyVRpFpbrnt/m4O1CSmCAVSltqhQSquYgdwi07N03 sFB3ecjXT4RXv2pgypM38rlWW4cKdjOaLr7vjUIzpuMLuR+GfuwAV/ZUcl7C8XdV4afG CnBWk4LLLC2a4SEqX6yZ6nvRm/WmzA1CFSVnUdSZlkhY9Xs/mvipxTAjK+UphfQJ1jkS 0ORg== Return-Path: From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH 05/12] Remove vDSO support from make-syscall.sh Date: Thu, 12 Dec 2019 15:16:07 -0300 Message-Id: <20191212181614.31782-5-adhemerval.zanella@linaro.org> In-Reply-To: <20191212181614.31782-1-adhemerval.zanella@linaro.org> References: <20191212181614.31782-1-adhemerval.zanella@linaro.org> The auto-generated vDSO call show some issues: - It requires sync the auto-generated C file with current glibc implementation; - It still uses still uses symbol redirections hacks where libc-symbols.h provide macros that uses compiler builtins (libc_ifunc_redirected for instance); - It does not handle all required compiler handling (inhibit_stack_protector on iFUNC resolver). - It does not have any usage currently. Checked with a build against all major ABIs. --- sysdeps/unix/make-syscalls.sh | 45 +---------------------------------- 1 file changed, 1 insertion(+), 44 deletions(-) -- 2.17.1 diff --git a/sysdeps/unix/make-syscalls.sh b/sysdeps/unix/make-syscalls.sh index fe24bbc78f..c07626677f 100644 --- a/sysdeps/unix/make-syscalls.sh +++ b/sysdeps/unix/make-syscalls.sh @@ -149,14 +149,6 @@ emit_weak_aliases() echo "$calls" | while read file srcfile caller syscall args strong weak; do - vdso_syscall= - case x"$syscall" in - *:*@*) - vdso_syscall="${syscall#*:}" - syscall="${syscall%:*}" - ;; - esac - case x"$syscall" in x-) callnum=_ ;; *) @@ -233,10 +225,9 @@ while read file srcfile caller syscall args strong weak; do if test $shared_only = t; then # The versioned symbols are only in the shared library. echo "shared-only-routines += $file" - test -n "$vdso_syscall" || echo "\$(objpfx)${file}.os: \\" + echo "\$(objpfx)${file}.os: \\" else object_suffixes='$(object-suffixes)' - test -z "$vdso_syscall" || object_suffixes='$(object-suffixes-noshared)' echo "\ \$(foreach p,\$(sysd-rules-targets),\ \$(foreach o,${object_suffixes},\$(objpfx)\$(patsubst %,\$p,$file)\$o)): \\" @@ -268,40 +259,6 @@ while read file srcfile caller syscall args strong weak; do echo ' ) | $(compile-syscall) '"\ \$(foreach p,\$(patsubst %$file,%,\$(basename \$(@F))),\$(\$(p)CPPFLAGS))" - if test -n "$vdso_syscall"; then - # In the shared library, we're going to emit an IFUNC using a vDSO function. - # $vdso_syscall looks like "name@KERNEL_X.Y" where "name" is the symbol - # name in the vDSO and KERNEL_X.Y is its symbol version. - vdso_symbol="${vdso_syscall%@*}" - vdso_symver="${vdso_syscall#*@}" - vdso_symver=`echo "$vdso_symver" | sed 's/\./_/g'` - cat <'; \\ - echo '#undef ${strong}'; \\ - echo '#define vdso_ifunc_init()'; \\ - echo '__ifunc (__redirect_${strong}, ${strong},'; \\ - echo ' get_vdso_symbol ("${vdso_symbol}"), void,'; \\ - echo ' vdso_ifunc_init)'; \\ -EOF - # This is doing "hidden_def (${strong})", but the compiler - # doesn't know that we've defined ${strong} in the same file, so - # we can't do it the normal way. - cat <