From patchwork Mon Jun 24 16:37:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 807056 Delivered-To: patch@linaro.org Received: by 2002:a5d:508d:0:b0:362:4979:7f74 with SMTP id a13csp1971444wrt; Mon, 24 Jun 2024 09:41:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX63aElWj5GD08lV9aj80Oo6WQg2XxAHz0tBF8OijGv7t94imLPnEZTbNo3k4kQAU+izfiSddWjfNwatyBGGv2f X-Google-Smtp-Source: AGHT+IFlxta4DIH5QmVIiXLpotbd94MhU6JBaHIxaM1mQ11UoraZokfCOK05rJTnJqdiAewqCiUz X-Received: by 2002:a05:622a:40e:b0:441:6021:df43 with SMTP id d75a77b69052e-444d6599bd7mr61317931cf.62.1719247307501; Mon, 24 Jun 2024 09:41:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1719247307; cv=pass; d=google.com; s=arc-20160816; b=kTgFkN+3XWSJL+okxyvTnzyTrTpbIke3YmDMr0PK6orliu0+cqlh3+yWe+G7857Qhi b845/Oin6LavOtZXhTluNTN9GUtuyq501Q3sD28fZcbZE40IPBc2JJ4hfZUmajnVfQgX qG/lvowI9Mvlx1jVtuF85ZXsbRxhjNJP48rOeLTUGfEXPwh2WtfR+9IKjTDzJlEAHkYY SrdqelTvdshKUjYYDKlCkRzy+XyfneWzHQ4etFcjLxa6/ETFc3Tu++/QBwBTMbCZF6i/ xPtiqIAkxdUJJjsUCc4e6cnOnwNHRbgV0DY10jHfHmtKfjECrFWGg3wANIn521FOXKoq 2fqQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=JYyRkEkDw8lM/ygWDkUX1Jrg8RjdzKZ4bc07AFDYh6o=; fh=oUdlCGl+3qy3cXVPxX2rni00O5FZdQ9LfqUzmQ4bHLM=; b=c9tCdldxPOifKA4+snlv3yeeL2SDt3Kb2TJE+N/HKr73NAiMJU/GuN3ANN+agtpSIZ PJhAAWdQd4mPdBz9K69qcHu02vqX0reicbRRmGTIvBk9YseCnkR6bc+T1ghga5EPNAYJ sW1K3TN38frIb1DEwzZyLCa01Ab4UaQEF7OP94vP7z9MdrBD3qlatIY1F4RKwKZvoTzt kSnc8CxE0/KC5fx8dD3zd/4qgmcU8L9sXdWQAtRawiV9LDYtRR5pyj/3lUeL3rKh6wUl POGX/NH6+ewCMgs/GmR47PSFoH0AFhnLeKu7Dvc2L0Ydwy8qqTjaLwt/a+eActrHAYvy 1ayw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uL3MGier; arc=pass (i=1); spf=pass (google.com: domain of libc-alpha-bounces+patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="libc-alpha-bounces+patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id d75a77b69052e-444c2b71cdasi85882481cf.199.2024.06.24.09.41.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 09:41:47 -0700 (PDT) Received-SPF: pass (google.com: domain of libc-alpha-bounces+patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uL3MGier; arc=pass (i=1); spf=pass (google.com: domain of libc-alpha-bounces+patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="libc-alpha-bounces+patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 21120384AB48 for ; Mon, 24 Jun 2024 16:41:47 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by sourceware.org (Postfix) with ESMTPS id EFD8C384AB44 for ; Mon, 24 Jun 2024 16:38:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EFD8C384AB44 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EFD8C384AB44 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2604:1380:4641:c500::1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719247094; cv=none; b=FXtWa0SWKT0CaBwTVoVWWbCJa7ilMN0ZipqiY21MueCUnIW0fxHRvHtC5G5kkbwKIZtwvf5JYYezSmgNcnRMz/SChH3dkbCrEnGhHyBtB0D3pY3MrCh5WgNj6EJK8M4X2XIbbIiA6JP8LxX2BB73rP5nHTA/mFpW3INJ7Nnfyl0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719247094; c=relaxed/simple; bh=IgP0M8xmd5rjKhDPUrYgB64lu58oqh0y0crOb4BZD9U=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=gtbJoFU4sNVW5yP0Ger5S9v1n1Ol7qBW2Hf/eir2Y1umLH4mcvmOGEFAa4SrNbSCRnic1KRyIKD+kMkQyL9YSKFNncvUu1NlVWv+LHAykeKtRcvvrjFRXIVC7/dKrRvYjE7nz39oLqY/EF3tJ+yH6L59aY5n0dvCtV1YjPXRuGw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9AAB360DF2; Mon, 24 Jun 2024 16:38:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A628C32786; Mon, 24 Jun 2024 16:38:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719247092; bh=IgP0M8xmd5rjKhDPUrYgB64lu58oqh0y0crOb4BZD9U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uL3MGier3znplmaR7ZT6dWU/wpMoIe4gnslzma/NaCokwco6hNNz/242/pTrmZOnN 4+wIbkcqyl/+nWHsL0pDj8yUnBc1srg2b1tkEQOhMgZsgAfiqSysXcAabbIc6PqjLB W58PkXZvWU6v4pKUO7S+b/c83SFUzAmR3qQdGO4WdA8Cj04KVUFj4pJZ/vguuTwqXJ XVQzo8MhTcluDAglatkg1lY1q27QSmzXYOZq7NErvn0v2tJfhwmD46fByBV5VQh52r Meb9HdgzdfdnxkPDa/ongCQL8TK5a/lXXQtjPtmxTRxxTPI7hjInVaJq2O/gyGnV1/ otrEBJFQ1xLOQ== From: Arnd Bergmann To: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Arnd Bergmann , Thomas Bogendoerfer , linux-mips@vger.kernel.org, Helge Deller , linux-parisc@vger.kernel.org, "David S. Miller" , Andreas Larsson , sparclinux@vger.kernel.org, Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N . Rao" , linuxppc-dev@lists.ozlabs.org, Brian Cain , linux-hexagon@vger.kernel.org, Guo Ren , linux-csky@vger.kernel.org, Heiko Carstens , linux-s390@vger.kernel.org, Rich Felker , John Paul Adrian Glaubitz , linux-sh@vger.kernel.org, "H. Peter Anvin" , Alexander Viro , Christian Brauner , linux-fsdevel@vger.kernel.org, libc-alpha@sourceware.org, musl@lists.openwall.com, stable@vger.kernel.org Subject: [PATCH v2 08/13] sh: rework sync_file_range ABI Date: Mon, 24 Jun 2024 18:37:06 +0200 Message-Id: <20240624163707.299494-9-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240624163707.299494-1-arnd@kernel.org> References: <20240624163707.299494-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+patch=linaro.org@sourceware.org From: Arnd Bergmann The unusual function calling conventions on SuperH ended up causing sync_file_range to have the wrong argument order, with the 'flags' argument getting sorted before 'nbytes' by the compiler. In userspace, I found that musl, glibc, uclibc and strace all expect the normal calling conventions with 'nbytes' last, so changing the kernel to match them should make all of those work. In order to be able to also fix libc implementations to work with existing kernels, they need to be able to tell which ABI is used. An easy way to do this is to add yet another system call using the sync_file_range2 ABI that works the same on all architectures. Old user binaries can now work on new kernels, and new binaries can try the new sync_file_range2() to work with new kernels or fall back to the old sync_file_range() version if that doesn't exist. Cc: stable@vger.kernel.org Fixes: 75c92acdd5b1 ("sh: Wire up new syscalls.") Signed-off-by: Arnd Bergmann Acked-by: John Paul Adrian Glaubitz --- arch/sh/kernel/sys_sh32.c | 11 +++++++++++ arch/sh/kernel/syscalls/syscall.tbl | 3 ++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/arch/sh/kernel/sys_sh32.c b/arch/sh/kernel/sys_sh32.c index 9dca568509a5..d6f4afcb0e87 100644 --- a/arch/sh/kernel/sys_sh32.c +++ b/arch/sh/kernel/sys_sh32.c @@ -59,3 +59,14 @@ asmlinkage int sys_fadvise64_64_wrapper(int fd, u32 offset0, u32 offset1, (u64)len0 << 32 | len1, advice); #endif } + +/* + * swap the arguments the way that libc wants them instead of + * moving flags ahead of the 64-bit nbytes argument + */ +SYSCALL_DEFINE6(sh_sync_file_range6, int, fd, SC_ARG64(offset), + SC_ARG64(nbytes), unsigned int, flags) +{ + return ksys_sync_file_range(fd, SC_VAL64(loff_t, offset), + SC_VAL64(loff_t, nbytes), flags); +} diff --git a/arch/sh/kernel/syscalls/syscall.tbl b/arch/sh/kernel/syscalls/syscall.tbl index bbf83a2db986..c55fd7696d40 100644 --- a/arch/sh/kernel/syscalls/syscall.tbl +++ b/arch/sh/kernel/syscalls/syscall.tbl @@ -321,7 +321,7 @@ 311 common set_robust_list sys_set_robust_list 312 common get_robust_list sys_get_robust_list 313 common splice sys_splice -314 common sync_file_range sys_sync_file_range +314 common sync_file_range sys_sh_sync_file_range6 315 common tee sys_tee 316 common vmsplice sys_vmsplice 317 common move_pages sys_move_pages @@ -395,6 +395,7 @@ 385 common pkey_alloc sys_pkey_alloc 386 common pkey_free sys_pkey_free 387 common rseq sys_rseq +388 common sync_file_range2 sys_sync_file_range2 # room for arch specific syscalls 393 common semget sys_semget 394 common semctl sys_semctl