From patchwork Fri Jan 10 18:12:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 856282 Delivered-To: patch@linaro.org Received: by 2002:a5d:525c:0:b0:385:e875:8a9e with SMTP id k28csp366617wrc; Fri, 10 Jan 2025 10:21:14 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXVu4iZ7sD+DUdTX34VCnEftrhHYXkM+w85DOAMgjw92wnNVcXA8y8RQF9+axqfxqXeS1TF6A==@linaro.org X-Google-Smtp-Source: AGHT+IFRllqwxB3HNswkFPQrOsii2ohJNB50Eb12rocMl+V6yk0XfL0PAf1H3zf+Nd3t6aHQ2Atl X-Received: by 2002:a05:6102:94a:b0:4b2:bceb:1ac6 with SMTP id ada2fe7eead31-4b3d0e5f60amr12405341137.17.1736533274310; Fri, 10 Jan 2025 10:21:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1736533274; cv=pass; d=google.com; s=arc-20240605; b=Yc/o6uZBnSMdTgTwsimv5Y87XAaAQuE7+C6wYHsu3pgR/8s8R9CCVYbhi3rBwuF30C 2dIE09wSu1JJ5GvssXxLwwv8cY7DqQkkcShUldNK26f18opRd0oFw/UBFHc7vdQ1gZuq 3UhGovi6znVNGkoDGODVcAbWQury7/hrOEAatufG10ek9zfyuGdy4ck0oykZUHi4eQC4 Cs3nwulMwQtgnskwV3uFuRMwKgsoh143t4f0e5+uhcY6G75/a+qwMItRNhMub3TJLX3F NArcvx34iAKLvMANwkQy60uCD9iD5drfjupEkHcjtRpn0Hdp5KMKgy2HrdZCrgVFwVF6 ONNw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dkim-filter:arc-filter:dmarc-filter :delivered-to:dkim-filter; bh=gmAaSuT0ipWqpxpmqeUSjAJI5n1R9I1Bv5E0fJQtBCM=; fh=d7KdQ+eBG5Owb97PZQUBRjccSsV/hB6hMlyGG6W37vA=; b=G0k+tlI76HOt3pt/hFOjM9/Icgqdfs3SoMzNoi4rp9nfsw96v0c0h+xNiqERDb9VyI 56+aPJAhYpMHo2JuNl3qkaEwbv6gSTbQnix5HUZWlFlgacram+YZfYhAv3Q9VN32Fb2x vWOkuTCfyVGbhX70ES1ualKtEzJiripWlFOosysiM+B4wPLtXF8/qQJV2Sf4ZqWCwpaQ YtKfUHI9ExxwIxhXvgSmmm3J6oN5TPZRNqhISBIc+vvhgSyNiMLbR3bXjao3fE5Zq0+t Whb9NyP/1ssWLDcSL92b7qysnPFbb0xPDMXTZzI/0LmxHOLgD8SFJPIIgu6xpS6XCcdp NC3A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BT7Cjz4d; arc=pass (i=1); spf=pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="libc-alpha-bounces~patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id ada2fe7eead31-4b608ff7272si367623137.189.2025.01.10.10.21.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 10:21:14 -0800 (PST) Received-SPF: pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BT7Cjz4d; arc=pass (i=1); spf=pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="libc-alpha-bounces~patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 32EA53858C35 for ; Fri, 10 Jan 2025 18:21:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 32EA53858C35 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=BT7Cjz4d X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-vk1-xa2c.google.com (mail-vk1-xa2c.google.com [IPv6:2607:f8b0:4864:20::a2c]) by sourceware.org (Postfix) with ESMTPS id 592B13858402 for ; Fri, 10 Jan 2025 18:15:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 592B13858402 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 592B13858402 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::a2c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736532924; cv=none; b=ICxn5VpyfFinJtJct/OO1ldZEyZqpzdlq/RJyGpsEwJCSM/IErckEY3av2l36sA4of9pf1l0cRaunlRiDVOKtKySoSR7rifU6tldGy/6WH3hforOhVS+RiFDn+QRbGQ234fILYV7jfzcwwtYlF9BIoiJqPiAXx0OI5u1Sbmqt+U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736532924; c=relaxed/simple; bh=xvyKptPaMqeV4HdIjwp1BwA2j9M9zcmJ8FdYktH9Rzo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ek8BTnEdMDLGp7n0s4wdtoHDL2gsP2SU/FJODKYyr6peRp52bTGgcDFyBHqPZbki4vpxt7VT/n54gbjVVIAfyqaTht0eeNgH24X01pgHrd7qwxs+KEvSr8+sG2l3JYn9hxC0Yiia005kWUm3yAojxwcUVHGwMrq4gcoVQAEF1dg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 592B13858402 Received: by mail-vk1-xa2c.google.com with SMTP id 71dfb90a1353d-51889930cb1so779430e0c.0 for ; Fri, 10 Jan 2025 10:15:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736532923; x=1737137723; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gmAaSuT0ipWqpxpmqeUSjAJI5n1R9I1Bv5E0fJQtBCM=; b=BT7Cjz4dBp/k/IelDhG3uWgBUo2pMwQ0MlMJtdOFcX0lEdkdNrmsFu85Pg0VsE8ny9 eWT6l+MNDsxt292eSb9vOKtHGrz6tkxpQeRfth26I7QAQqLkcBv8V2Oc0rMvJzvPuwXV m6PZSAxAO2W7vqNYCCRPjbxStbFO6pUcRgv6s9m50XnNID2+3bjhzOFp+os3FymYapbm 8S6XkhXzNZeJWJYQACn4X9D6bslTp2FC7OI0iLS4nKGJybImAY4xbrWhwfkx8oFbU7bF vSAugc0Im1xVwPbW5Gu9rHKW/NrTqsxeq+jNJGhAN9wyO0mflX++gjVwm7a9ITI18lXH OhOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736532923; x=1737137723; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gmAaSuT0ipWqpxpmqeUSjAJI5n1R9I1Bv5E0fJQtBCM=; b=Vgh/Lwi6/EjnZpvzr7tOS3h985Q16rJDDK2vKf+OfmcrTDDaMIrvJKceggIL5fLcGi y7KAfXovnevHPaZuTC5+j+TA/himq6T/AJG69L5+QMwmiM7SH8jGUCVUPqC3dO7jLnB0 0PLfKs7o2Yekj9FV1T9/A3wM/gtN56xOvabCGq5szMK/czQTdWtn6OQMA+2PGOhPzqcN 5viMQ+hKl0Y/b5GXi1uZnb2kexHJUHZM6c4Lm1lDH7kD1aWBnM1BXuKMpW5drB+5Hnse I2Kemxux4WU7Gq8BujG3KJNKq8j4AjFbIQ1APEqOqReBSCuin8jI0Nfz6zQUEmytqBTQ OACA== X-Gm-Message-State: AOJu0YySogYqKfznj0qXb7pXW7i+UqnGdmEFkPXfHF/xwzwWKH3k2870 n/vAN4pntv2Fgi9TVKUgroxga7y91XL8kKe2Pddx1u0FNxw1Y5TJDQS66E+OGNg7X2uaa11U8uM s X-Gm-Gg: ASbGncv6SjjIe+YcUU9WLZT1/6J8MO6Uq3qXGv3rtRDCsjPHOB2Lt8lIIszBN9QktjJ OV86ANUlzE4rxAg1B4odwvM+qsgO/6FLnAzAFXq6QHIObnepEzdt17kSMpiKQ4i5t8iVDq2ziwH F4fqVO1KPEwSWIcia0Ii6shzLvr0RVyq2Fmw8r8Ce1xoVvaXCeo/uBVwmIRYtr4P7dnra95JZwi wNq8SmAWNF21Hu5JVt5CZAgZnx4BFBcn1uJNSv/fqhrnDGmpF4BRyiBrFYY+8498cojkg== X-Received: by 2002:a05:6122:a29:b0:515:ed1b:e6dd with SMTP id 71dfb90a1353d-51c6c2b5573mr10866286e0c.0.1736532923309; Fri, 10 Jan 2025 10:15:23 -0800 (PST) Received: from ubuntu-vm.. ([191.23.120.207]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-51c7fb9d621sm2469139e0c.1.2025.01.10.10.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 10:15:22 -0800 (PST) From: Adhemerval Zanella To: libc-alpha@sourceware.org Cc: Sam James , "H . J . Lu" Subject: [PATCH v2 4/4] stdio-common: Suppress Clang warnings on scanf13.c with fortify enable Date: Fri, 10 Jan 2025 15:12:14 -0300 Message-ID: <20250110181508.350378-5-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250110181508.350378-1-adhemerval.zanella@linaro.org> References: <20250110181508.350378-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patch=linaro.org@sourceware.org clang-19 shows: scanf13.c:28:40: error: 'sscanf' may overflow; destination buffer in argument 4 has size 8, but the corresponding specifier may require size 11 [-Werror,-Wfortify-source] 28 | "A%ms%10ms%4m[bcd]%4mcB", &sp1, &sp2, &sp3, &sp4) != 4) | ^ scanf13.c:94:34: error: 'sscanf' may overflow; destination buffer in argument 3 has size 8, but the corresponding specifier may require size 2049 [-Werror,-Wfortify-source] 94 | if (sscanf (buf, "%2048ms%mc", &sp3, &sp4) != 2) | ^ scanf13.c:110:61: error: 'sscanf' may overflow; destination buffer in argument 4 has size 8, but the corresponding specifier may require size 1501 [-Werror,-Wfortify-source] 110 | if (sscanf (buf, "%4mc%1500m[dr/]%548m[abc/d]%3mc", &sp1, &sp2, &sp3, &sp4) | ^ scanf13.c:110:67: error: 'sscanf' may overflow; destination buffer in argument 5 has size 8, but the corresponding specifier may require size 549 [-Werror,-Wfortify-source] 110 | if (sscanf (buf, "%4mc%1500m[dr/]%548m[abc/d]%3mc", &sp1, &sp2, &sp3, &sp4) --- stdio-common/scanf13.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/stdio-common/scanf13.c b/stdio-common/scanf13.c index 65b1429720..131abb33de 100644 --- a/stdio-common/scanf13.c +++ b/stdio-common/scanf13.c @@ -24,6 +24,7 @@ main (void) DIAG_PUSH_NEEDS_COMMENT_CLANG; DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wformat-invalid-specifier"); DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wformat-extra-args"); + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source"); if (sscanf ("A \xc3\x84-\t\t\xc3\x84-abcdefbcd\t\xc3\x84-B", "A%ms%10ms%4m[bcd]%4mcB", &sp1, &sp2, &sp3, &sp4) != 4) FAIL (); @@ -91,6 +92,8 @@ main (void) FAIL (); free (sp2); } + DIAG_PUSH_NEEDS_COMMENT_CLANG; + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source"); if (sscanf (buf, "%2048ms%mc", &sp3, &sp4) != 2) FAIL (); else @@ -131,6 +134,7 @@ main (void) FAIL (); free (sp4); } + DIAG_POP_NEEDS_COMMENT_CLANG; if (sscanf (buf, "%mS%mC", &lsp1, &lsp2) != 2) FAIL (); else @@ -150,6 +154,7 @@ main (void) DIAG_PUSH_NEEDS_COMMENT_CLANG; DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wformat-invalid-specifier"); DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wformat-extra-args"); + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source"); if (sscanf (buf, "%2048mls%mlc", &lsp3, &lsp4) != 2) FAIL (); else