From patchwork Sat Nov 10 12:56:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radoslaw Biernacki X-Patchwork-Id: 150734 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp1034606ljp; Sat, 10 Nov 2018 05:12:37 -0800 (PST) X-Google-Smtp-Source: AJdET5eAknec09mvF5YyWYWixi9VYwQh7U7p8/PpGpcpY9fDKIPFHZ3dhHImkBvqSGLhj293jTyi X-Received: by 2002:a37:90e:: with SMTP id 14mr11734702qkj.63.1541855557129; Sat, 10 Nov 2018 05:12:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541855557; cv=none; d=google.com; s=arc-20160816; b=Af6tPiT7ujCJ5k9VT4B/AJyekMNdn4bl44fcm64w91XzllrkF3xWOj5upyiv1V0Y+P N8q9XYETSRwGpnyDGFUmkeF2VRhccpDJoR3+EsKYPhYARvOVUfdnV/5ViiVn8TsNJRZX 7PSmx4u9yD87IRg41oHmUDouBo8hB4Q6ZyPuXcyrizhgsU6qjz0ymkBm1C4p+hnBrr7e aSoQQJAbP23DE+oJKp9zaySqLcFERRkBVIg3K4NYKTI+iu1errH/mLqMpgtNOOrwSDRx yaUlZFJd/PRVBMCdUn6llrqu4zbrKk+lrHSvhD1YZ1EEnCN7+C9qP9ozYsCzLhkPA25w vfKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:message-id:date:to:from :dkim-signature:delivered-to; bh=3IL0uQh5NBbMYkd4Dv2dZyyxhNMWWXcb9IgDY5CTWCk=; b=zbsKMAHkKT+0e0TW2oP4r0MLJYOCXGmWD4cEDfTHKWA9FR0wVnMPni3aQV9K7m/L5b w64VNZMr5fWoiF1cD5eVW+kKMMxiRPjiTVc4yoxX0vyjJHiXj7RhWKl1iQ070i+YmaSk TS/IfX3JS/8FHNLJfC/3dXg1HztZDQyJl26gDvpOu+O0JiMXUOnLDjIl7F5bthcaLkhi ce5LB6/zbtbQ9dlufr/ExGLdO1PPxH0dDTDM1k/Ju3UZKctwFY7hlWeoSV0EtLe1DNxe N0Puih9SUBGpG7EGKDd7FHl+hN86/rz/pUPCcgjI3JY5cTkSvlWAXO5LS+806ZIavsGg bHQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=MZSspt2r; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id j49si8358524qta.341.2018.11.10.05.12.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Nov 2018 05:12:37 -0800 (PST) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=MZSspt2r; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 46E07308624C; Sat, 10 Nov 2018 13:12:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A4993608DA; Sat, 10 Nov 2018 13:12:32 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6E3B14BB79; Sat, 10 Nov 2018 13:12:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wAACuZEa022788 for ; Sat, 10 Nov 2018 07:56:35 -0500 Received: by smtp.corp.redhat.com (Postfix) id 6612019754; Sat, 10 Nov 2018 12:56:35 +0000 (UTC) Delivered-To: libvir-list@redhat.com Received: from mx1.redhat.com (ext-mx02.extmail.prod.ext.phx2.redhat.com [10.5.110.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5C91119753 for ; Sat, 10 Nov 2018 12:56:33 +0000 (UTC) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3FD6787623 for ; Sat, 10 Nov 2018 12:56:31 +0000 (UTC) Received: by mail-lf1-f44.google.com with SMTP id q6-v6so3200436lfh.9 for ; Sat, 10 Nov 2018 04:56:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=y6doeauUJXC8b4rMUyfToCjwfOOXa46Xo8jykb2ENso=; b=MZSspt2r8NFiGBRjHQu5zI5n0r1zk3ZuCgVjh6e/YlOXWP/spQKMAg7OZS6h70n12j dAVGw3yOCgluh2Wf7Nu2eXwmEJFRoqfHHBp58UjG0mVSkM//iA5Sw9NAA/UKe/huddib W7dvW2aoANi11M2BZTzrEjzKqZpX+818W/NpA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=y6doeauUJXC8b4rMUyfToCjwfOOXa46Xo8jykb2ENso=; b=bwTGHmyW2j5MeM4MGPXPAe+hn/cjfZqcMj7R/XporESUwIYK+RfLdMMALkNQWuuwUy A0nkmEHrugGl6FRbMhxzsRNssCct0LbOikfmHsyxosSCcZXw5IOPRmSVmPE5A1LkbtN9 oQvf4x7IXnPuMhSHPECY3SIOYYkI5iTu4KC08LGje9lUMIx2SZZqt3xzWr2xHx7ijeF2 CvusV+pmlx5XZ47KjUwlp4sP0HgeyRNHs6J2nq1Z2ExCGVtql9zbHROURFUVCsF+9XMl v1AK38x9vplRuQN3aMD5umwRloAyR4JB8hG6sAgML5Wle642OKSYXQIwfTFdfq/W3mxr nWnA== X-Gm-Message-State: AGRZ1gLiHbTcj5yObVfbT/R6AGind4zUlTL77O2lZSYz8tITh6bvB16U 89kygX4yTVGEQwcuWhjC/60z1JXpxZE= X-Received: by 2002:a19:7019:: with SMTP id h25-v6mr7884511lfc.147.1541854589338; Sat, 10 Nov 2018 04:56:29 -0800 (PST) Received: from rad-H81M-S1.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id h16-v6sm2145024lfc.0.2018.11.10.04.56.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Nov 2018 04:56:28 -0800 (PST) From: Radoslaw Biernacki To: libvir-list@redhat.com Date: Sat, 10 Nov 2018 13:56:20 +0100 Message-Id: <20181110125624.1168-1-radoslaw.biernacki@linaro.org> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Sat, 10 Nov 2018 12:56:31 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Sat, 10 Nov 2018 12:56:31 +0000 (UTC) for IP:'209.85.167.44' DOMAIN:'mail-lf1-f44.google.com' HELO:'mail-lf1-f44.google.com' FROM:'radoslaw.biernacki@linaro.org' RCPT:'' X-RedHat-Spam-Score: -0.111 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_NONE, SPF_PASS) 209.85.167.44 mail-lf1-f44.google.com 209.85.167.44 mail-lf1-f44.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.26 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: laine@laine.org Subject: [libvirt] [PATCH 0/4] util: Fixing libvirt errors on cavium/thunder-nicvf X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Sat, 10 Nov 2018 13:12:35 +0000 (UTC) ThunderX is Cavium SoC. This platform contain SRIOV NIC. Unlike other commonly known network devices it does not have VF functionality duplicated in its PF. PF is purely management device (on HW level). This creates several problems with existing libvirt code as in many places libvirt assumes that each VF netdev has PF netdev assigned. This patch series trying to address issues which can be easily fixed. (mostly bug fixes found while working on full featured solution) First patch in series is most important as it allows to unblock the netdev detection and use on this platform. More details about those issues can be found at: https://bugs.linaro.org/show_bug.cgi?id=3778 https://bugs.launchpad.net/charm-nova-compute/+bug/1771662 Radoslaw Biernacki (4): util: fixing wrong assumption that PF has to have netdev assigned util: Code simplification util: Fix for NULL dereference util: Fixing invalid error checking from virPCIGetNetname() src/qemu/qemu_domain_address.c | 11 ++--- src/util/virhostdev.c | 2 +- src/util/virnetdev.c | 50 ++++---------------- 3 files changed, 16 insertions(+), 47 deletions(-) -- 2.14.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list